mmc: sdhci-pci: Add some CD GPIO related quirks
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest6 patches 7 repliesIn review
- v16 patches 9 repliesSuperseded
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/6 | mmc: sdhci-pci: Read card detect from ACPI for Intel Merrifielddrivers/ | +24 | 2 replies | |
| 2/6 | mmc: sdhci: Deduplicate sdhci_get_cd_nogpio()drivers/ drivers/ drivers/ +1 more | +21 | 1 reply | |
| 3/6 | mmc: sdhci: Remove unused prototype declaration in the headerdrivers/ | +0 | 1 reply | |
| 4/6 | mmc: sdhci-pci: Remove dead code (struct sdhci_pci_data et al)drivers/ drivers/ drivers/ +2 more | +4 | 1 reply | |
| 5/6 | mmc: sdhci-pci: Remove dead code (cd_gpio, cd_irq et al)drivers/ drivers/ | +1 | 1 reply | |
| 6/6 | mmc: sdhci-pci: Remove dead code (rst_n_gpio et al)drivers/ drivers/ | +0 | 1 reply |
Reviews trailers per patch
All 6 patches have a Reviewed-by or Acked-by.
| Patch | Adrian Hunter |
|---|---|
| 1/6 | A-b |
| 2/6 | A-b |
| 3/6 | A-b |
| 4/6 | A-b |
| 5/6 | A-b |
| 6/6 | A-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v2 0/6] mmc: sdhci-pci: Add some CD GPIO related quirks
It appears that one of the supported platform magically worked with the custom IRQ handler (any hints how?) while having two PCB designs with an opposite CD sense level. Here is an attempt to fix it by quirking out CD GPIO.
Patch 1 is an actual fix for the mentioned platform. Patch 2 is code deduplication to save few LOCs. Patch 3-6 are dead code removals.
In v2:
- redone fix to use ->get_cd() instead of quirks (Adrian)
- due to above transformed previous clean up to the current patch 2
- added a new patch, i.e. patch 3
- added commit IDs to patch 4 (Adrian)
- mentioned dependencies on previous patches in patch 5 and 6 (Adrian)
Andy Shevchenko (6):
mmc: sdhci-pci: Read card detect from ACPI for Intel Merrifield
mmc: sdhci: Deduplicate sdhci_get_cd_nogpio()
mmc: sdhci: Remove unused prototype declaration in the header
mmc: sdhci-pci: Remove dead code (struct sdhci_pci_data et al)
mmc: sdhci-pci: Remove dead code (cd_gpio, cd_irq et al)
mmc: sdhci-pci: Remove dead code (rst_n_gpio et al)
drivers/mmc/host/Makefile | 1 - drivers/mmc/host/sdhci-acpi.c | 14 +-- drivers/mmc/host/sdhci-pci-core.c | 159 ++++------------------------- drivers/mmc/host/sdhci-pci-data.c | 6 -- drivers/mmc/host/sdhci-pci.h | 5 - drivers/mmc/host/sdhci.c | 19 ++++ drivers/mmc/host/sdhci.h | 2 +- include/linux/mmc/sdhci-pci-data.h | 18 ---- 8 files changed, 39 insertions(+), 185 deletions(-) delete mode 100644 drivers/mmc/host/sdhci-pci-data.c delete mode 100644 include/linux/mmc/sdhci-pci-data.h
Signature · 1 line
2.33.0