Skip to content

KVM: selftests: Add tests for SEV and SEV-ES guests

Michael Roth kvm linux-kselftest lkml 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest13 patches 10 repliesIn review
  2. v1 RFC16 patches 39 repliesApplied

Changes in v2 from the cover letter

- rebased on ucall_ops patchset (which is based on kvm/next 2021-12-10)
- remove SEV-SNP support for now
- provide encryption bitmap as const* to original rather than as a copy (Mingwei, Paolo)
- drop SEV-specific synchronization helpers in favor of ucall_ops_halt (Paolo)
- don't pass around addresses with c-bit included, add them as-needed via addr_gpa2raw() (e.g. when adding PTEs, or initializing initial cr3/vm->pgd) (Paolo)
- rename lib/sev.c functions for better consistency (Krish)
- move more test setup code out of main test function and into setup_test_common() (Krish)
- suppress compiler warnings due to -Waddress-of-packed-member like kernel does
- don't require SNP support in minimum firmware version detection (Marc)
- allow SEV device path to be configured via make SEV_PATH= (Marc)

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/13KVM: selftests: move vm_phy_pages_alloc() earlier in filetools/testing/selftests/kvm/lib/kvm_util.c+73 -730 replies
2/13KVM: selftests: sparsebit: add const where appropriatetools/testing/selftests/kvm/include/sparsebit.h tools/testing/selftests/kvm/lib/sparsebit.c+42 -420 replies
3/13KVM: selftests: add hooks for managing encrypted guest memorytools/testing/selftests/kvm/include/kvm_util_base.h tools/testing/selftests/kvm/lib/kvm_util.c tools/testing/selftests/kvm/lib/kvm_util_internal.h+66 -30 replies
4/13KVM: selftests: handle encryption bits in page tablestools/testing/selftests/kvm/include/kvm_util_base.h tools/testing/selftests/kvm/lib/kvm_util.c tools/testing/selftests/kvm/lib/x86_64/processor.c+65 -80 replies
5/13KVM: selftests: add support for encrypted vm_vaddr_* allocationstools/testing/selftests/kvm/include/kvm_util_base.h tools/testing/selftests/kvm/lib/kvm_util.c+18 -60 replies
6/13KVM: selftests: ensure ucall_shared_alloc() allocates shared memorytools/testing/selftests/kvm/lib/ucall_common.c+2 -20 replies
7/13KVM: selftests: add library for creating/interacting with SEV gueststools/testing/selftests/kvm/Makefile tools/testing/selftests/kvm/include/x86_64/sev.h tools/testing/selftests/kvm/lib/x86_64/sev.c+297 -13 replies
8/13KVM: selftests: add SEV boot teststools/testing/selftests/kvm/.gitignore tools/testing/selftests/kvm/Makefile tools/testing/selftests/kvm/x86_64/sev_all_boot_test.c+257 -04 replies
9/13KVM: SVM: include CR3 in initial VMSA state for SEV-ES guestsarch/x86/include/asm/kvm-x86-ops.h arch/x86/include/asm/kvm_host.h arch/x86/kvm/svm/svm.c +2 more+28 -01 reply
10/13KVM: selftests: account for error code in #VC exception frametools/testing/selftests/kvm/lib/x86_64/handlers.S+3 -10 replies
11/13KVM: selftests: add support for creating SEV-ES gueststools/testing/selftests/kvm/lib/x86_64/sev.c+9 -20 replies
12/13KVM: selftests: add library for handling SEV-ES-related exitstools/testing/selftests/kvm/Makefile tools/testing/selftests/kvm/include/x86_64/sev_exitlib.h tools/testing/selftests/kvm/include/x86_64/svm.h +2 more+301 -20 replies
13/13KVM: selftests: add SEV-ES boot teststools/testing/selftests/kvm/x86_64/sev_all_boot_test.c+62 -10 replies

Reviews trailers per patch

2 of 13 patches have a Reviewed-by or Acked-by.

PatchMingwei Zhang
1/13R-b
2/13
3/13R-b
4/13
5/13
6/13
7/13
8/13
9/13
10/13
11/13
12/13
13/13

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 00/13] KVM: selftests: Add tests for SEV and SEV-ES guests

These patches and are also available at:

https://github.com/mdroth/linux/commits/sev-selftests-v2

They are based on top of the recent RFC:

"KVM: selftests: Add support for test-selectable ucall implementations"
https://lore.kernel.org/all/[email protected]/T/

https://github.com/mdroth/linux/commits/sev-selftests-ucall-rfc1

which provides a new ucall implementation that this series relies on. Those patches were in turn based on kvm/next as of 2021-12-10.

== OVERVIEW ==

This series introduces a set of memory encryption-related parameter/hooks in the core kselftest library, then uses the hooks to implement a small library for creating/managing SEV, SEV-ES, and (eventually) SEV-SNP guests. This library is then used to implement a basic boot/memory test that's run for variants of SEV/SEV-ES guests.

- Patches 1-8 implement SEV boot tests and should run against existing kernels
- Patch 9 is a KVM changes that's required to allow SEV-ES/SEV-SNP guests to boot with an externally generated page table, and is a host kernel prequisite for the remaining patches in the series.
- Patches 10-13 extend the boot tests to cover SEV-ES

Any review/comments are greatly appreciated!

v2:
- rebased on ucall_ops patchset (which is based on kvm/next 2021-12-10)
- remove SEV-SNP support for now
- provide encryption bitmap as const* to original rather than as a copy (Mingwei, Paolo)
- drop SEV-specific synchronization helpers in favor of ucall_ops_halt (Paolo)
- don't pass around addresses with c-bit included, add them as-needed via addr_gpa2raw() (e.g. when adding PTEs, or initializing initial cr3/vm->pgd) (Paolo)
- rename lib/sev.c functions for better consistency (Krish)
- move more test setup code out of main test function and into setup_test_common() (Krish)
- suppress compiler warnings due to -Waddress-of-packed-member like kernel does
- don't require SNP support in minimum firmware version detection (Marc)
- allow SEV device path to be configured via make SEV_PATH= (Marc)

----------------------------------------------------------------
Michael Roth (13):
KVM: selftests: move vm_phy_pages_alloc() earlier in file
KVM: selftests: sparsebit: add const where appropriate
KVM: selftests: add hooks for managing encrypted guest memory
KVM: selftests: handle encryption bits in page tables
KVM: selftests: add support for encrypted vm_vaddr_* allocations
KVM: selftests: ensure ucall_shared_alloc() allocates shared memory
KVM: selftests: add library for creating/interacting with SEV guests
KVM: selftests: add SEV boot tests
KVM: SVM: include CR3 in initial VMSA state for SEV-ES guests
KVM: selftests: account for error code in #VC exception frame
KVM: selftests: add support for creating SEV-ES guests
KVM: selftests: add library for handling SEV-ES-related exits
KVM: selftests: add SEV-ES boot tests

 arch/x86/include/asm/kvm-x86-ops.h                 |   1 +
 arch/x86/include/asm/kvm_host.h                    |   1 +
 arch/x86/kvm/svm/svm.c                             |  19 ++
 arch/x86/kvm/vmx/vmx.c                             |   6 +
 arch/x86/kvm/x86.c                                 |   1 +
 tools/testing/selftests/kvm/.gitignore             |   1 +
 tools/testing/selftests/kvm/Makefile               |  10 +-
 .../testing/selftests/kvm/include/kvm_util_base.h  |  10 +
 tools/testing/selftests/kvm/include/sparsebit.h    |  36 +--
 tools/testing/selftests/kvm/include/x86_64/sev.h   |  44 +++
 .../selftests/kvm/include/x86_64/sev_exitlib.h     |  14 +
 tools/testing/selftests/kvm/include/x86_64/svm.h   |  35 +++
 .../selftests/kvm/include/x86_64/svm_util.h        |   1 +
 tools/testing/selftests/kvm/lib/kvm_util.c         | 270 ++++++++++++------
 .../testing/selftests/kvm/lib/kvm_util_internal.h  |  10 +
 tools/testing/selftests/kvm/lib/sparsebit.c        |  48 ++--
 tools/testing/selftests/kvm/lib/ucall_common.c     |   4 +-
 tools/testing/selftests/kvm/lib/x86_64/handlers.S  |   4 +-
 tools/testing/selftests/kvm/lib/x86_64/processor.c |  16 +-
 tools/testing/selftests/kvm/lib/x86_64/sev.c       | 252 ++++++++++++++++
 .../testing/selftests/kvm/lib/x86_64/sev_exitlib.c | 249 ++++++++++++++++
 .../selftests/kvm/x86_64/sev_all_boot_test.c       | 316 +++++++++++++++++++++
 22 files changed, 1215 insertions(+), 133 deletions(-)
 create mode 100644 tools/testing/selftests/kvm/include/x86_64/sev.h
 create mode 100644 tools/testing/selftests/kvm/include/x86_64/sev_exitlib.h
 create mode 100644 tools/testing/selftests/kvm/lib/x86_64/sev.c
 create mode 100644 tools/testing/selftests/kvm/lib/x86_64/sev_exitlib.c
 create mode 100644 tools/testing/selftests/kvm/x86_64/sev_all_boot_test.c