RFC s390x: Improvements to SIGP handling [KVM]
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 RFC Latest2 patches 5 repliesIn review
- v1 RFC6 patches 20 repliesApplied
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/2 | Capability/IOCTL/DocumentationDocumentation/ include/ | +31 | 0 replies | |
| 2/2 | KVM: s390: Extend the USER_SIGP capabilityarch/ arch/ arch/ +1 more | +70 | 5 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.
Cover letter [RFC PATCH v2 0/2] s390x: Improvements to SIGP handling [KVM]
Here is a new variation of the SIGP handling discussed a few weeks ago [1]. Notable changes:
- Patches 1 and 6 from v1 were picked for 5.16 (Thank you!) [2]
- Patches 2 through 5 were removed, and replaced with this iteration that relies on a KVM capability and IOCTL
I opted to use David's suggestion [3] for the kernel to automatically set a vcpu "busy" and userspace to reset it when complete. I made it dependent on the existing USER_SIGP stuff, which maybe isn't great for potential non-SIGP scenarios in the future, but this at least shows how it could work.
According to the Principles of Operation, only a subset of SIGP orders would generate a "busy" condition, and a different subset would even notice it. But I did the entirety of the SIGP orders, even the invalid ones that would otherwise return some status bits and CC1 instead of the CC2 (BUSY) condition. Perhaps that's too much, perhaps not.
As I'm writing this, I'm realizing that I probably need to look at the cpu reset paths clearer, to ensure the "busy" indicator is actually reset to zero.
Since this is an RFC, I've left the CAP/IOCTL definitions as a standalone patch, so I see it easier when working with the QEMU code. Ultimately this would be squashed together, and might have some refit after the merge window anyway.
I'll send the QEMU series shortly, which takes advantage of this.
Thoughts?
[1] https://lore.kernel.org/r/[email protected]/
[2] https://lore.kernel.org/r/[email protected]/
[3] https://lore.kernel.org/r/[email protected]/
Eric Farman (2):
Capability/IOCTL/Documentation
KVM: s390: Extend the USER_SIGP capability
Documentation/virt/kvm/api.rst | 27 +++++++++++++++++++++ arch/s390/include/asm/kvm_host.h | 2 ++ arch/s390/kvm/kvm-s390.c | 18 ++++++++++++++ arch/s390/kvm/kvm-s390.h | 10 ++++++++ arch/s390/kvm/sigp.c | 40 ++++++++++++++++++++++++++++++++ include/uapi/linux/kvm.h | 4 ++++ 6 files changed, 101 insertions(+)
Signature · 1 line
2.25.1