Skip to content

Correct race conditions in rdma_rxe

Bob Pearson linux-rdma 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest13 patches 9 repliesIn review
  2. v310 patches 3 repliesSuperseded
  3. v210 patches 0 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v16 patches14 repliesSuperseded

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/13RDMA/rxe: Replace irqsave locks with bh locksdrivers/infiniband/sw/rxe/rxe_comp.c drivers/infiniband/sw/rxe/rxe_cq.c drivers/infiniband/sw/rxe/rxe_mcast.c +6 more+59 -860 replies
2/13RDMA/rxe: Cleanup rxe_pool_entrydrivers/infiniband/sw/rxe/rxe_cq.c drivers/infiniband/sw/rxe/rxe_loc.h drivers/infiniband/sw/rxe/rxe_mcast.c +8 more+89 -910 replies
3/13RDMA/rxe: Copy setup parameters into rxe_pooldrivers/infiniband/sw/rxe/rxe_pool.c drivers/infiniband/sw/rxe/rxe_pool.h+27 -330 replies
4/13RDMA/rxe: Save object pointer in pool elementdrivers/infiniband/sw/rxe/rxe_pool.c drivers/infiniband/sw/rxe/rxe_pool.h+18 -130 replies
5/13RDMA/rxe: Replace RB tree by xarray for indexesdrivers/infiniband/sw/rxe/rxe.c drivers/infiniband/sw/rxe/rxe_mr.c drivers/infiniband/sw/rxe/rxe_mw.c +3 more+62 -2881 reply
6/13RDMA/rxe: Remove #include "rxe_loc.h" from rxe_pool.cdrivers/infiniband/sw/rxe/rxe_pool.c+0 -10 replies
7/13RDMA/rxe: Remove some #defines from rxe_pool.hdrivers/infiniband/sw/rxe/rxe_pool.c drivers/infiniband/sw/rxe/rxe_pool.h+2 -30 replies
8/13RDMA/rxe: Reverse the sense of RXE_POOL_NO_ALLOCdrivers/infiniband/sw/rxe/rxe_pool.c drivers/infiniband/sw/rxe/rxe_pool.h+9 -110 replies
9/13RDMA/rxe: Replaced keyed rxe objects by indexed objectsdrivers/infiniband/sw/rxe/rxe_loc.h drivers/infiniband/sw/rxe/rxe_mcast.c drivers/infiniband/sw/rxe/rxe_mw.c +4 more+230 -3023 replies
10/13RDMA/rxe: Prevent taking references to dead objectsdrivers/infiniband/sw/rxe/rxe_pool.h+9 -13 replies
11/13RDMA/rxe: Fix ref error in rxe_av.cdrivers/infiniband/sw/rxe/rxe_av.c drivers/infiniband/sw/rxe/rxe_loc.h drivers/infiniband/sw/rxe/rxe_net.c +2 more+63 -350 replies
12/13RDMA/rxe: Replace mr by rkey in responder resourcesdrivers/infiniband/sw/rxe/rxe_qp.c drivers/infiniband/sw/rxe/rxe_resp.c drivers/infiniband/sw/rxe/rxe_verbs.h+87 -470 replies
13/13RDMA/rxe: Protect against race between get_index and drop_refdrivers/infiniband/sw/rxe/rxe_pool.c+6 -11 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v4 yet.

Read the v4 thread

Cover letter [PATCH for-next v4 00/13] Correct race conditions in rdma_rxe

There are several race conditions discovered in the current rdma_rxe driver. They mostly relate to races between normal operations and destroying objects. This patch series makes several minor cleanups in rxe_pool.[ch] and replaces the red-black trees currently used by xarrays which have better atomic behavior.

This patch series applies cleanly to current for-next. commit 6a463bc9d999 ("Merge branch 'for-rc' into rdma.git for-next")

---
v4
Restructured patch series to change to xarray earlier which greatly simplified the changes.
Rebased to current for-next
v3
Changed rxe_alloc to use GFP_KERNEL
Addressed other comments by Jason Gunthorp
Merged the previous 06/10 and 07/10 patches into one since they overlapped Added some minor cleanups as 10/10
v2
Rebased to current for-next.
Added 4 additional patches

Bob Pearson (13):
RDMA/rxe: Replace irqsave locks with bh locks RDMA/rxe: Cleanup rxe_pool_entry
RDMA/rxe: Copy setup parameters into rxe_pool RDMA/rxe: Save object pointer in pool element RDMA/rxe: Replace RB tree by xarray for indexes RDMA/rxe: Remove #include "rxe_loc.h" from rxe_pool.c RDMA/rxe: Remove some #defines from rxe_pool.h RDMA/rxe: Reverse the sense of RXE_POOL_NO_ALLOC RDMA/rxe: Replaced keyed rxe objects by indexed objects RDMA/rxe: Prevent taking references to dead objects RDMA/rxe: Fix ref error in rxe_av.c
RDMA/rxe: Replace mr by rkey in responder resources RDMA/rxe: Protect against race between get_index and drop_ref

 drivers/infiniband/sw/rxe/rxe.c       | 100 +-----
 drivers/infiniband/sw/rxe/rxe_av.c    |  19 +-
 drivers/infiniband/sw/rxe/rxe_comp.c  |   8 +-
 drivers/infiniband/sw/rxe/rxe_cq.c    |  24 +-
 drivers/infiniband/sw/rxe/rxe_loc.h   |  25 +-
 drivers/infiniband/sw/rxe/rxe_mcast.c | 167 ++++++---
 drivers/infiniband/sw/rxe/rxe_mr.c    |   7 +-
 drivers/infiniband/sw/rxe/rxe_mw.c    |  25 +-
 drivers/infiniband/sw/rxe/rxe_net.c   |  17 +-
 drivers/infiniband/sw/rxe/rxe_pool.c  | 479 ++++++++------------------
 drivers/infiniband/sw/rxe/rxe_pool.h  | 129 ++-----
 drivers/infiniband/sw/rxe/rxe_qp.c    |  16 +-
 drivers/infiniband/sw/rxe/rxe_queue.c |   9 +-
 drivers/infiniband/sw/rxe/rxe_recv.c  |   3 +-
 drivers/infiniband/sw/rxe/rxe_req.c   |  66 ++--
 drivers/infiniband/sw/rxe/rxe_resp.c  | 125 ++++---
 drivers/infiniband/sw/rxe/rxe_srq.c   |   2 +-
 drivers/infiniband/sw/rxe/rxe_task.c  |  18 +-
 drivers/infiniband/sw/rxe/rxe_verbs.c |  73 ++--
 drivers/infiniband/sw/rxe/rxe_verbs.h |  23 +-
 20 files changed, 542 insertions(+), 793 deletions(-)
Signature · 1 line
2.30.2