Skip to content

tests/fbdev: Additional tests for resolution and panning

Thomas Zimmermann igt-dev 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest2 patches 8 repliesIn review
  2. v32 patches 0 repliesSuperseded
  3. v22 patches 3 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v12 patches4 repliesSuperseded

Changes in v4 from the cover letter

* return early if PAN ioctl failed in pan_test()

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2tests/fbdev: Test for validity of video mode settingstests/fbdev.c+41 -80 replies
2/2tests/fbdev: Add tests for display panningtests/fbdev.c+108 -00 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchVille Syrjälä
1/2R-b
2/2R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [igt-dev] [PATCH v4 0/2] tests/fbdev: Additional tests for resolution and panning

Add addtional tests for resolution and panning operations on fbdev devices. Succeed on successful operations. Fail on invalid operations or state.

DRM's simpledrm driver exposed a bug in DRM's fbdev overallocation code,
[1] which is required for fbdev page flipping. The new test cases intent to test panning and page flipping, and detect such issues early.

Tested with the current simpledrm and a hacked version that supports fbdev overallocation. This will also help to implement the panning functionality for real in simpledrm and other drivers.

v4:
* return early if PAN ioctl failed in pan_test()
v3:
* move pan-test logic into helper function (Ville)
* fixes and comments for FB_VMODE_YWRAP
v2:
* test horizontal resolution against line length (Ville)
* respect FB_VMODE_YWRAP (Ville)
* respect {x,y}panstep (Ville)

[1] https://lore.kernel.org/dri-devel/[email protected]/

Thomas Zimmermann (2):
tests/fbdev: Test for validity of video mode settings tests/fbdev: Add tests for display panning

 tests/fbdev.c | 157 +++++++++++++++++++++++++++++++++++++++++++++++---
 1 file changed, 149 insertions(+), 8 deletions(-)

--
2.33.0