Skip to content

KVM: x86: Revert to fix apic_hw_disabled underflow

Sean Christopherson kvm lkml 1 version Applied

Status from this message: Queued for 5.15, thanks.

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 1 replyApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/2Revert "KVM: x86: Open code necessary bits of kvm_lapic_set_base() at vCPU RESET"arch/x86/kvm/lapic.c+11 -70 replies
2/2KVM: x86: WARN if APIC HW/SW disable static keys are non-zero on unloadarch/x86/kvm/lapic.c+2 -00 replies

Reviews trailers per patch

None of the 2 patches has a Reviewed-by or Acked-by.

PatchTetsuo Handa
1/2Debugged-by
2/2

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/2] KVM: x86: Revert to fix apic_hw_disabled underflow

Revert (mostly) a patch from the vCPU RESET cleanup that open coded some APIC shenanigans to avoid stuffing vcpu->arch.apic_base at vCPU creation, and completely overlooked the side effects on apic_hw_disabled. I went for a revert as I think the original behavior is the least awful solution, just somewhat poorly documented.

The second patch adds WARNs to detect "overflow", where "overflow" means KVM incorrectly increments apic_hw_disabled.

Sean Christopherson (2):
Revert "KVM: x86: Open code necessary bits of kvm_lapic_set_base() at
vCPU RESET"
KVM: x86: WARN if APIC HW/SW disable static keys are non-zero on
unload

 arch/x86/kvm/lapic.c | 20 +++++++++++++-------
 1 file changed, 13 insertions(+), 7 deletions(-)
Signature · 1 line
2.33.0.1079.g6e70778dc9-goog