Skip to content

9p: Add support for darwin

Will Cohen qemu-devel 9 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v9 Latest11 patches 15 repliesIn review
  2. v811 patches 8 repliesSuperseded
  3. v711 patches 3 repliesSuperseded
Earlier versions · 6
VersionPostedPatchesRepliesStatus
v611 patches3 repliesSuperseded
v511 patches22 repliesSuperseded
v411 patches32 repliesSuperseded
v311 patches10 repliesSuperseded
v211 patches19 repliesSuperseded
v111 patches8 repliesSuperseded

Patches in v9 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/119p: linux: Fix a couple Linux assumptionsfsdev/file-op-9p.h hw/9pfs/9p-local.c hw/9pfs/9p.c +1 more+17 -20 replies
2/119p: Rename 9p-util -> 9p-util-linuxhw/9pfs/9p-util-linux.c hw/9pfs/meson.build+2 -20 replies
3/119p: darwin: Handle struct stat(fs) differenceshw/9pfs/9p-proxy.c hw/9pfs/9p-synth.c hw/9pfs/9p.c+36 -40 replies
4/119p: darwin: Handle struct dirent differenceshw/9pfs/9p-local.c hw/9pfs/9p-proxy.c hw/9pfs/9p-synth.c +3 more+52 -40 replies
5/119p: darwin: Ignore O_{NOATIME, DIRECT}hw/9pfs/9p-util.h hw/9pfs/9p.c+14 -10 replies
6/119p: darwin: Move XATTR_SIZE_MAX->P9_XATTR_SIZE_MAXhw/9pfs/9p.c hw/9pfs/9p.h+19 -10 replies
7/119p: darwin: *xattr_nofollow implementationshw/9pfs/9p-util-darwin.c hw/9pfs/meson.build+65 -00 replies
8/119p: darwin: Compatibility for f/l*xattrhw/9pfs/9p-local.c hw/9pfs/9p-util.h+25 -40 replies
9/119p: darwin: Implement compatibility for mknodathw/9pfs/9p-local.c hw/9pfs/9p-util-darwin.c hw/9pfs/9p-util-linux.c +2 more+53 -210 replies
10/119p: darwin: Adjust assumption on virtio-9p-testtests/qtest/virtio-9p-test.c+1 -10 replies
11/119p: darwin: meson: Allow VirtFS on Darwinfsdev/meson.build meson.build+8 -52 replies

Reviews trailers per patch

4 of 11 patches have a Reviewed-by or Acked-by.

PatchPhilippe Mathieu-DaudéGreg KurzPaolo BonziniThomas Huth
1/11R-b R-b
2/11R-b R-b
3/11
4/11
5/11
6/11
7/11
8/11
9/11
10/11R-b A-b
11/11R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v9 thread

Cover letter [PATCH v9 00/11] 9p: Add support for darwin

This is a followup to https://lists.gnu.org/archive/html/qemu-devel/2022-02/msg04391.html,
adding 9p server support for Darwin.

Since v8, the following changes have been made:

Patch 4/11 (9p: darwin: Handle struct dirent differences)
- Declare qemu_dirent_off as static to prevent linker error
- Move qemu_dirent_off above the end-of-file endif to fix compilation

Patch 9/11 (9p: darwin: Implement compatibility for mknodat)
- Fix line over 90 characters formatting error
- Move qemu_mknodat back from osdep to 9p-util and adjust patch notes accordingly

Patch 11/11 (9p: darwin: meson: Allow VirtFS on Darwin)
- Rebase to master

With these changes, this patch set builds and passes 9p synth tests on both linux and darwin.

Keno Fischer (10):
9p: linux: Fix a couple Linux assumptions 9p: Rename 9p-util -> 9p-util-linux
9p: darwin: Handle struct stat(fs) differences 9p: darwin: Handle struct dirent differences 9p: darwin: Ignore O_{NOATIME, DIRECT}
9p: darwin: Move XATTR_SIZE_MAX->P9_XATTR_SIZE_MAX 9p: darwin: *xattr_nofollow implementations 9p: darwin: Compatibility for f/l*xattr 9p: darwin: Implement compatibility for mknodat 9p: darwin: meson: Allow VirtFS on Darwin

Will Cohen (1):
9p: darwin: Adjust assumption on virtio-9p-test

 fsdev/file-op-9p.h                     |  9 ++-
 fsdev/meson.build                      |  1 +
 hw/9pfs/9p-local.c                     | 27 +++++--
 hw/9pfs/9p-proxy.c                     | 38 +++++++++-
 hw/9pfs/9p-synth.c                     |  6 ++
 hw/9pfs/9p-util-darwin.c               | 97 ++++++++++++++++++++++++++
 hw/9pfs/{9p-util.c => 9p-util-linux.c} |  8 ++-
 hw/9pfs/9p-util.h                      | 46 ++++++++++++
 hw/9pfs/9p.c                           | 42 +++++++++--
 hw/9pfs/9p.h                           | 18 +++++
 hw/9pfs/codir.c                        |  4 +-
 hw/9pfs/meson.build                    |  3 +-
 include/qemu/xattr.h                   |  4 +-
 meson.build                            | 13 ++--
 tests/qtest/virtio-9p-test.c           |  2 +-
 15 files changed, 292 insertions(+), 26 deletions(-)
 create mode 100644 hw/9pfs/9p-util-darwin.c
 rename hw/9pfs/{9p-util.c => 9p-util-linux.c} (90%)
Signature · 1 line
2.35.1