Skip to content

RFC rt-tests: cyclictest: Add support to report standard deviation

Punit Agrawal linux-rt-users 1 version NAK

Status from this message: NACK: two different scopes, two different variables.

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest7 patches 15 repliesNAK

Patches in v1

#Subject and filesSizeRepliesApplied
1/7rt-tests: cyclictest: Drop unused definessrc/cyclictest/cyclictest.c+0 -42 replies
2/7rt-tests: cyclictest: Simplify duplicate initialization of "stop"src/cyclictest/cyclictest.c+1 -42 replies
3/7rt-tests: cyclictest: Drop unnecessary variable "stopped"src/cyclictest/cyclictest.c+1 -30 replies
4/7rt-tests: cyclictest: Drop unnecessary variable "bufsize"src/cyclictest/cyclictest.c+0 -14 replies
5/7rt-tests: cyclictest: Move signal handler to avoid function declarationsrc/cyclictest/cyclictest.c+37 -412 replies
6/7rt-tests: cyclictest: Use streaming algorithm to calculate averagessrc/cyclictest/cyclictest.c+12 -60 replies
7/7rt-tests: cyclictest: Add support to report standard deviationMakefile src/cyclictest/cyclictest.c+38 -73 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [RFC 0/7] rt-tests: cyclictest: Add support to report standard deviation

Hi,

Standard deviation is an important measure to evaluate the latency response of a real time system. It is calculated by downstream tools such as rteval but the value cannot be correctly calculated when the latency value exceeds the range of histogram.

This series adds support to report the streaming standard deviation of latencies to cyclictest. This approach avoids having to track all latency values and adds minimal overhead (two additional doubles and compute steps) to each iteration.

In terms of patch organization, the first 5 patches are clean-ups that were noticed in the course of developing the support for standard deviation. It should be possible to apply them indepndently.

Patch 6 converts the existing average calculation to a streaming version. This running average value is needed for the standard deviation.

Patch 7 finally adds support for calculating standard deviation.

The changes were verified by capturing the latency samples and verifying the average and standard deviation with manual calculation.

All feedback welcome.

Thanks,
Punit

Punit Agrawal (7):
rt-tests: cyclictest: Drop unused defines
rt-tests: cyclictest: Simplify duplicate initialization of "stop"
rt-tests: cyclictest: Drop unnecessary variable "stopped"
rt-tests: cyclictest: Drop unnecessary variable "bufsize"
rt-tests: cyclictest: Move signal handler to avoid function
declaration
rt-tests: cyclictest: Use streaming algorithm to calculate averages
rt-tests: cyclictest: Add support to report standard deviation

 Makefile                    |   2 +-
 src/cyclictest/cyclictest.c | 149 +++++++++++++++++++++---------------
 2 files changed, 87 insertions(+), 64 deletions(-)
Signature · 1 line
2.32.0