Skip to content

mmc: sdhci-pci: Remove dead code and deduplicate

Andy Shevchenko linux-mmc lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v3 Latest5 patches 2 repliesIn review

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5mmc: sdhci: Deduplicate sdhci_get_cd_nogpio()drivers/mmc/host/sdhci-acpi.c drivers/mmc/host/sdhci-pci-core.c drivers/mmc/host/sdhci.c +1 more+21 -310 replies
2/5mmc: sdhci: Remove unused prototype declaration in the headerdrivers/mmc/host/sdhci.h+0 -10 replies
3/5mmc: sdhci-pci: Remove dead code (struct sdhci_pci_data et al)drivers/mmc/host/Makefile drivers/mmc/host/sdhci-pci-core.c drivers/mmc/host/sdhci-pci-data.c +2 more+4 -530 replies
4/5mmc: sdhci-pci: Remove dead code (cd_gpio, cd_irq et al)drivers/mmc/host/sdhci-pci-core.c drivers/mmc/host/sdhci-pci.h+1 -770 replies
5/5mmc: sdhci-pci: Remove dead code (rst_n_gpio et al)drivers/mmc/host/sdhci-pci-core.c drivers/mmc/host/sdhci-pci.h+0 -290 replies

Reviews trailers per patch

All 5 patches have a Reviewed-by or Acked-by.

PatchAdrian HunterFerry Toth
SeriesT-b
1/5A-b
2/5A-b
3/5A-b
4/5A-b
5/5A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/5] mmc: sdhci-pci: Remove dead code and deduplicate

It appears that one of the supported platform magically worked with the custom IRQ handler (any hints how?) while having two PCB designs with an opposite CD sense level. Quirking it out reveals the code duplication and dead code.

Patch 1 is code deduplication to save few LOCs.
Patch 2-5 are dead code removals.

In v3:
- dropped the fix as it has been applied (Ulf)
- added tag (Adrian)
- elaborated commit IDs with their short descriptions in patch 3 (Adrian)
- corrected dependency in patch 5 (Adrian)

In v2:
- redone fix to use ->get_cd() instead of quirks (Adrian)
- due to above transformed previous clean up to the current patch 2
- added a new patch, i.e. patch 3
- added commit IDs to patch 4 (Adrian)
- mentioned dependencies on previous patches in patch 5 and 6 (Adrian)

Andy Shevchenko (5):
mmc: sdhci: Deduplicate sdhci_get_cd_nogpio()
mmc: sdhci: Remove unused prototype declaration in the header
mmc: sdhci-pci: Remove dead code (struct sdhci_pci_data et al)
mmc: sdhci-pci: Remove dead code (cd_gpio, cd_irq et al)
mmc: sdhci-pci: Remove dead code (rst_n_gpio et al)

 drivers/mmc/host/Makefile          |   1 -
 drivers/mmc/host/sdhci-acpi.c      |  14 +--
 drivers/mmc/host/sdhci-pci-core.c  | 152 +----------------------------
 drivers/mmc/host/sdhci-pci-data.c  |   6 --
 drivers/mmc/host/sdhci-pci.h       |   5 -
 drivers/mmc/host/sdhci.c           |  19 ++++
 drivers/mmc/host/sdhci.h           |   2 +-
 include/linux/mmc/sdhci-pci-data.h |  18 ----
 8 files changed, 26 insertions(+), 191 deletions(-)
 delete mode 100644 drivers/mmc/host/sdhci-pci-data.c
 delete mode 100644 include/linux/mmc/sdhci-pci-data.h
Signature · 1 line
2.33.0