replace drm_detect_hdmi_monitor() with drm_display_info.is_hdmi
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest13 patches 18 repliesIn review
- v115 patches 14 repliesSuperseded
Changes in v2 from the cover letter
- no helper function
- A separate patch is made for amdgpu
- zte patch is removed because that driver no longer exists
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/13 | gpu/drm: make drm_add_edid_modes() consistent when updating connector->display_infodrivers/ | +5 | 3 replies | |
| 2/13 | drm/vc4: replace drm_detect_hdmi_monitor() with drm_display_info.is_hdmidrivers/ | +3 | 0 replies | |
| 3/13 | drm/radeon: replace drm_detect_hdmi_monitor() with drm_display_info.is_hdmidrivers/ drivers/ drivers/ +1 more | +15 | 0 replies | |
| 4/13 | drm/tegra: replace drm_detect_hdmi_monitor() with drm_display_info.is_hdmidrivers/ | +1 | 0 replies | |
| 5/13 | drm/gma500: replace drm_detect_hdmi_monitor() with drm_display_info.is_hdmidrivers/ drivers/ | +6 | 0 replies | |
| 6/13 | drm/exynos: replace drm_detect_hdmi_monitor() with drm_display_info.is_hdmidrivers/ | +4 | 3 replies | |
| 7/13 | drm/msm: replace drm_detect_hdmi_monitor() with drm_display_info.is_hdmidrivers/ | +1 | 1 reply | |
| 8/13 | drm/sun4i: replace drm_detect_hdmi_monitor() with drm_display_info.is_hdmidrivers/ | +2 | 0 replies | |
| 9/13 | drm/sti: replace drm_detect_hdmi_monitor() with drm_display_info.is_hdmidrivers/ | +6 | 0 replies | |
| 10/13 | drm/rockchip: replace drm_detect_hdmi_monitor() with drm_display_info.is_hdmidrivers/ drivers/ | +3 | 0 replies | |
| 11/13 | drm/bridge: replace drm_detect_hdmi_monitor() with drm_display_info.is_hdmidrivers/ drivers/ drivers/ | +3 | 0 replies | |
| 12/13 | drm/nouveau: replace drm_detect_hdmi_monitor() with drm_display_info.is_hdmidrivers/ drivers/ | +3 | 0 replies | |
| 13/13 | drm/i915: replace drm_detect_hdmi_monitor() with drm_display_info.is_hdmidrivers/ drivers/ | +3 | 9 replies |
Reviews trailers per patch
3 of 13 patches have a Reviewed-by or Acked-by.
| Patch | Ville Syrjälä | Inki Dae | Dmitry Baryshkov |
|---|---|---|---|
| 1/13 | R-b | ||
| 2/13 | |||
| 3/13 | |||
| 4/13 | |||
| 5/13 | |||
| 6/13 | A-b | ||
| 7/13 | R-b | ||
| 8/13 | |||
| 9/13 | |||
| 10/13 | |||
| 11/13 | |||
| 12/13 | |||
| 13/13 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.
Cover letter [PATCH v2 00/13] replace drm_detect_hdmi_monitor() with drm_display_info.is_hdmi
Changelog:
v2:
- no helper function
- A separate patch is made for amdgpu
- zte patch is removed because that driver no longer exists
[Why]
Copy&paste from Documentation/gpu/todo.rst
===
Replace drm_detect_hdmi_monitor() with drm_display_info.is_hdmi
---------------------------------------------------------------
Once EDID is parsed, the monitor HDMI support information is available through drm_display_info.is_hdmi. Many drivers still call drm_detect_hdmi_monitor() to retrieve the same information, which is less efficient.
Audit each individual driver calling drm_detect_hdmi_monitor() and switch to drm_display_info.is_hdmi if applicable.
=====
[How]
I did it in two steps:
- check that drm_display_info has a correct value.
- in that case, replace drm_detect_hdmi_monitor() with drm_display_info.is_hdmi
Almost all occurrences of drm_detect_hdmi_monitor() could be changed. Some small inconsistencies have been solved.
Stats:
drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 2 +- drivers/gpu/drm/bridge/sii902x.c | 2 +- drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 2 +- drivers/gpu/drm/drm_edid.c | 11 +++++------ drivers/gpu/drm/exynos/exynos_hdmi.c | 6 ++++-- drivers/gpu/drm/gma500/cdv_intel_hdmi.c | 3 ++- drivers/gpu/drm/gma500/psb_intel_sdvo.c | 6 ++++-- drivers/gpu/drm/i915/display/intel_hdmi.c | 2 +- drivers/gpu/drm/i915/display/intel_sdvo.c | 3 ++- drivers/gpu/drm/msm/hdmi/hdmi_connector.c | 2 +- drivers/gpu/drm/nouveau/dispnv50/disp.c | 4 ++-- drivers/gpu/drm/nouveau/dispnv50/head.c | 8 +------- drivers/gpu/drm/radeon/atombios_encoders.c | 6 +++--- drivers/gpu/drm/radeon/radeon_connectors.c | 15 +++++++++------ drivers/gpu/drm/radeon/radeon_display.c | 2 +- drivers/gpu/drm/radeon/radeon_encoders.c | 4 ++-- drivers/gpu/drm/rockchip/inno_hdmi.c | 4 ++-- drivers/gpu/drm/rockchip/rk3066_hdmi.c | 2 +- drivers/gpu/drm/sti/sti_hdmi.c | 10 ++++++---- drivers/gpu/drm/sun4i/sun4i_hdmi_enc.c | 4 ++-- drivers/gpu/drm/tegra/hdmi.c | 6 +----- drivers/gpu/drm/vc4/vc4_hdmi.c | 6 +++--- 22 files changed, 55 insertions(+), 55 deletions(-)
Best regards.
Claudio Suarez