Skip to content

ALSA: hda: New NHLT functions and cleanup

Cezary Rojewski alsa-devel 5 versions – Applied

Status from this message: Applied all three patches now to for-next branch.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest3 patches 2 repliesApplied
  2. v43 patches 1 replySuperseded
  3. v34 patches 4 repliesApplied
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v24 patches2 repliesSuperseded
v15 patches8 repliesSuperseded

Changes in v5 from the cover letter

- no code changes
- actually removed the tags mentioned in v3

Patches in v5 Applied

#Subject and filesSizeRepliesApplied
1/3ALSA: hda: Fill gaps in NHLT endpoint-interfaceinclude/sound/intel-nhlt.h sound/hda/intel-nhlt.c+131 -80 replies
2/3ALSA: hda: Simplify DMIC-in-NHLT checksound/hda/intel-dsp-config.c+1 -10 replies
3/3ASoC: Intel: Skylake: Use NHLT API to search for blobsound/soc/intel/skylake/skl-nhlt.c sound/soc/intel/skylake/skl-pcm.c sound/soc/intel/skylake/skl-topology.c +2 more+21 -1181 reply

Reviews trailers per patch

1 of 3 patches has a Reviewed-by or Acked-by.

PatchMark Brown
1/3
2/3
3/3A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v5 thread

Cover letter [PATCH v5 0/3] ALSA: hda: New NHLT functions and cleanup

Changes add two crucial functions: endpoint presence-check and retrieval of endpoint's BLOB (hardware configuration) to NHLT API.

Outside of that, "is DMIC in NHLT?" check is being re-visited. No need to check for channel count or anything DMIC-configuration related, just straight up verify link_type presence.

Changes in v5:
- no code changes
- actually removed the tags mentioned in v3

Changes in v4:
- patch renaming nhlt_acpi_table struct to acpi_nhlt_table has been dropped due to naming conflicts with other parts of the kernel
- revoked previously appended tags from Mark and Pierre as every patch required an update due to above

Changes in v3:
- no code changes
- appended Mark's Acked-by tag for patch 4/4
- appended Pierre's Reviewed-by tag for all patches

Changes in v2:
- patch "ALSA hda: Drop device-argument in NHLT functions" has been dropped
- updated newly added declarations in intel-nhlt.h so warning:
"no-previous-prototype-for-function" and error:
"use-of-undeclared-identifier" are no longer observed when CONFIG_SND_INTEL_NHLT is not enabled
- added Mark's tag to the last patch of the series

Amadeusz Sławiński (3):
ALSA: hda: Fill gaps in NHLT endpoint-interface
ALSA: hda: Simplify DMIC-in-NHLT check
ASoC: Intel: Skylake: Use NHLT API to search for blob

 include/sound/intel-nhlt.h             |  37 +++++++--
 sound/hda/intel-dsp-config.c           |   2 +-
 sound/hda/intel-nhlt.c                 | 102 +++++++++++++++++++++++++
 sound/soc/intel/skylake/skl-nhlt.c     | 102 -------------------------
 sound/soc/intel/skylake/skl-pcm.c      |   3 +
 sound/soc/intel/skylake/skl-topology.c |  29 ++++---
 sound/soc/intel/skylake/skl-topology.h |   1 +
 sound/soc/intel/skylake/skl.h          |   4 -
 8 files changed, 153 insertions(+), 127 deletions(-)
Signature · 1 line
2.25.1