Skip to content

Fixes for gem_exec_capture

[email protected] igt-dev intel-gfx 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest8 patches 1 replyIn review
  2. v18 patches 19 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8tests/i915/gem_exec_capture: Remove pointless asserttests/i915/gem_exec_capture.c+0 -10 replies
2/8tests/i915/gem_exec_capture: Cope with larger page sizestests/i915/gem_exec_capture.c+6 -00 replies
3/8tests/i915/gem_exec_capture: Make the error decode a common helpertests/i915/gem_exec_capture.c+170 -1740 replies
4/8tests/i915/gem_exec_capture: Use contexts and engines properlytests/i915/gem_exec_capture.c+57 -221 reply
5/8tests/i915/gem_exec_capture: Check for memory allocation failuretests/i915/gem_exec_capture.c+2 -00 replies
6/8lib/igt_sysfs: Support large fileslib/igt_sysfs.c+11 -60 replies
7/8lib/igt_gt: Allow per engine reset testinglib/igt_gt.c lib/igt_gt.h+30 -150 replies
8/8tests/i915/gem_exec_capture: Update to support GuC based resetstests/i915/gem_exec_capture.c+53 -120 replies

Reviews trailers per patch

All 8 patches have a Reviewed-by or Acked-by.

PatchMatthew Brost
1/8R-b
2/8R-b
3/8R-b
4/8R-b
5/8R-b
6/8R-b
7/8R-b
8/8R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [igt-dev] [PATCH v2 i-g-t 0/8] Fixes for gem_exec_capture

From: John Harrison <[email protected]>

Fix a bunch of issues with gem_exec_capture with the ultimate aim of making it pass on GuC enabled platforms.

v2: Abstract the 'find first available engine' block into a helper (review feedback from Matthew B). Note that for unknown reasons, this helper does not work as a function. After wasting far too long trying to debug out why the engine mask in the execbuf was *sometimes* invalid, just making it a macro instead worked fine. Seems like maybe the for_each_ctx_engine macro creates a local stack variable that is silently required to remain in scope for the resulting ctx to be valid?

John Harrison (8):
tests/i915/gem_exec_capture: Remove pointless assert tests/i915/gem_exec_capture: Cope with larger page sizes tests/i915/gem_exec_capture: Make the error decode a common helper tests/i915/gem_exec_capture: Use contexts and engines properly tests/i915/gem_exec_capture: Check for memory allocation failure lib/igt_sysfs: Support large files
lib/igt_gt: Allow per engine reset testing tests/i915/gem_exec_capture: Update to support GuC based resets

 lib/igt_gt.c                  |  44 ++--
 lib/igt_gt.h                  |   1 +
 lib/igt_sysfs.c               |  17 +-
 tests/i915/gem_exec_capture.c | 469 ++++++++++++++++++++--------------
 4 files changed, 315 insertions(+), 216 deletions(-)
Signature · 1 line
2.25.1