Skip to content

drm/vc4: Reset HDMI link at hotplug

Maxime Ripard dri-devel 4 versions – Applied

Status from this message: Applied to drm/drm-misc (drm-misc-next).

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest8 patches 4 repliesApplied
  2. v38 patches 0 repliesSuperseded
  3. v213 patches 7 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v113 patches15 repliesSuperseded

Patches in v4 Applied

#Subject and filesSizeRepliesApplied
1/8drm/vc4: hdmi: Constify drm_display_modedrivers/gpu/drm/vc4/vc4_hdmi.c drivers/gpu/drm/vc4/vc4_hdmi.h+9 -90 replies
2/8drm/vc4: hdmi: Remove unused argument in vc4_hdmi_supports_scramblingdrivers/gpu/drm/vc4/vc4_hdmi.c+2 -30 replies
3/8drm/vc4: hdmi: Remove mutex in detectdrivers/gpu/drm/vc4/vc4_hdmi.c drivers/gpu/drm/vc4/vc4_hdmi.h+34 -640 replies
4/8drm/vc4: hdmi: Simplify the hotplug handlingdrivers/gpu/drm/vc4/vc4_hdmi.c+44 -223 replies
5/8drm/vc4: hdmi: Switch to detect_ctxdrivers/gpu/drm/vc4/vc4_hdmi.c+4 -30 replies
6/8drm/vc4: hdmi: Move vc4_hdmi_supports_scrambling() arounddrivers/gpu/drm/vc4/vc4_hdmi.c+17 -170 replies
7/8drm/vc4: hdmi: Reset link on hotplugdrivers/gpu/drm/vc4/vc4_hdmi.c+101 -30 replies
8/8drm/scdc: Document hotplug gotchasdrivers/gpu/drm/display/drm_scdc_helper.c+13 -00 replies

Reviews trailers per patch

1 of 8 patches has a Reviewed-by or Acked-by.

PatchVille Syrjälä
1/8
2/8
3/8
4/8R-b
5/8
6/8
7/8
8/8

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCH v4 0/8] drm/vc4: Reset HDMI link at hotplug

Hi,

This is a follow-up of the work to support the interactions between the hotplug and the scrambling support for vc4:

https://lore.kernel.org/dri-devel/[email protected]/
https://lore.kernel.org/dri-devel/[email protected]/
https://lore.kernel.org/dri-devel/[email protected]/

Ville feedback was that the same discussion happened some time ago for i915, and resulted in a function to do an full disable/enable cycle on reconnection to avoid breaking the HDMI 2.0 spec.

While the previous versions of this series was moving the current scrambling related functions into generic helpers to consolidate that logic, it proved to be difficult to rework existing drivers to make use of it without hardware to test it on and thus the code is (for now) private to vc4.

I still believe that long term, the code to decide if the scrambler needs to be enabled or not should be moved into a generic helper.

This also means that we would need to move the format output decision to a generic helper, which also makes sense to me but it probably going to be controversial.

Let me know what you think,
Maxime

Changes from v3 (https://lore.kernel.org/dri-devel/[email protected]/):
- Rebased on drm-misc-next-2022-08-20-1

Changes from v2 (https://lore.kernel.org/dri-devel/[email protected]/):
- Rebased on next-20220713
- Dropped the generic helpers and put them into vc4

Changes from v1 (https://lore.kernel.org/dri-devel/[email protected]/):
- Dropped the 340MHz define
- Make drm_mode_hdmi_requires_scrambling use the bpc
- Make more drm_display_mode const in vc4
- Dropped the tegra conversion
- Added more comments

Maxime Ripard (8):
drm/vc4: hdmi: Constify drm_display_mode
drm/vc4: hdmi: Remove unused argument in vc4_hdmi_supports_scrambling drm/vc4: hdmi: Remove mutex in detect
drm/vc4: hdmi: Simplify the hotplug handling
drm/vc4: hdmi: Switch to detect_ctx
drm/vc4: hdmi: Move vc4_hdmi_supports_scrambling() around drm/vc4: hdmi: Reset link on hotplug
drm/scdc: Document hotplug gotchas

 drivers/gpu/drm/display/drm_scdc_helper.c |  13 +
 drivers/gpu/drm/vc4/vc4_hdmi.c            | 308 ++++++++++++++--------
 drivers/gpu/drm/vc4/vc4_hdmi.h            |  12 +-
 3 files changed, 218 insertions(+), 115 deletions(-)
Signature · 1 line
2.37.1