Alloc batch fixes
Status from this message: applied, and the version above, I no longer saw the error, but the
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v3 Latest5 patches 30 repliesApplied
- v25 patches 0 repliesSuperseded
- v14 patches 13 repliesSuperseded
Changes in v3 from the cover letter
- Split both alloc handlers into helpers
- Retained blk_try_enter_queue() the way that it was, don't want to inline all of bio_queue_enter(). Added justification for that in the commit message.
- Add fops based submit_bio helper
Patches in v3 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/5 | block: have plug stored requests hold references to the queueblock/ block/ | +5 | 2 replies | |
| 2/5 | block: split request allocation components into helpersblock/ | +48 | 1 reply | |
| 3/5 | block: make blk_try_enter_queue() available for blk-mqblock/ block/ | +26 | 0 replies | |
| 4/5 | block: move queue enter logic into blk_mq_submit_bio()block/ block/ block/ +1 more | +50 | 26 replies | |
| 5/5 | block: ensure cached plug request matches the current queueblock/ | +1 | 1 reply |
Reviews trailers per patch
4 of 5 patches have a Reviewed-by or Acked-by.
| Patch | Christoph Hellwig | Geert Uytterhoeven |
|---|---|---|
| 1/5 | R-b | |
| 2/5 | R-b | |
| 3/5 | ||
| 4/5 | R-b | T-b |
| 5/5 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCHSET v3 0/5] Alloc batch fixes
Hi,
Since the new feedback on v1 arrived post v2, here's a v3 that takes it all into account.
A few fixes related to the batched allocations:
- Have the requests hold a queue reference, flush them on schedule unplug as well.
- Make sure the queue matches, could be a mismatch if we're driving multiple devices.
Since v2:
- Split both alloc handlers into helpers
- Retained blk_try_enter_queue() the way that it was, don't want to inline all of bio_queue_enter(). Added justification for that in the commit message.
- Add fops based submit_bio helper
Since v1:
- Reshuffle series to do plug rq alloc helper before enter changes
- Protect submit_bio_checks() by queue enter reference as well
Signature · 1 line
Jens Axboe