Skip to content

Alloc batch fixes

Jens Axboe linux-block linux-m68k lkml 3 versions – Applied

Status from this message: applied, and the version above, I no longer saw the error, but the

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest5 patches 30 repliesApplied
  2. v25 patches 0 repliesSuperseded
  3. v14 patches 13 repliesSuperseded

Changes in v3 from the cover letter

- Split both alloc handlers into helpers
- Retained blk_try_enter_queue() the way that it was, don't want to inline all of bio_queue_enter(). Added justification for that in the commit message.
- Add fops based submit_bio helper

Patches in v3 Applied

#Subject and filesSizeRepliesApplied
1/5block: have plug stored requests hold references to the queueblock/blk-core.c block/blk-mq.c+5 -42 replies
2/5block: split request allocation components into helpersblock/blk-mq.c+48 -231 reply
3/5block: make blk_try_enter_queue() available for blk-mqblock/blk-core.c block/blk.h+26 -250 replies
4/5block: move queue enter logic into blk_mq_submit_bio()block/blk-core.c block/blk-mq-sched.c block/blk-mq.c +1 more+50 -2526 replies
5/5block: ensure cached plug request matches the current queueblock/blk-mq.c+1 -11 reply

Reviews trailers per patch

4 of 5 patches have a Reviewed-by or Acked-by.

PatchChristoph HellwigGeert Uytterhoeven
1/5R-b
2/5R-b
3/5
4/5R-b T-b
5/5R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCHSET v3 0/5] Alloc batch fixes

Hi,

Since the new feedback on v1 arrived post v2, here's a v3 that takes it all into account.

A few fixes related to the batched allocations:

- Have the requests hold a queue reference, flush them on schedule unplug as well.

- Make sure the queue matches, could be a mismatch if we're driving multiple devices.

Since v2:
- Split both alloc handlers into helpers
- Retained blk_try_enter_queue() the way that it was, don't want to inline all of bio_queue_enter(). Added justification for that in the commit message.
- Add fops based submit_bio helper
Since v1:
- Reshuffle series to do plug rq alloc helper before enter changes
- Protect submit_bio_checks() by queue enter reference as well

Signature · 1 line
Jens Axboe