Skip to content

New function and literals for metrics

Ian Rogers linux-perf-users lkml 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest8 patches 2 repliesIn review
  2. v17 patches 6 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8perf test: Add expr test for events with hyphenstools/perf/tests/expr.c+10 -00 replies
2/8perf cputopo: Update to use pakage_cpustools/perf/util/cputopo.c tools/perf/util/cputopo.h tools/perf/util/header.c+28 -150 replies
3/8perf cputopo: Match die_siblings to topology ABI nametools/perf/util/cputopo.c tools/perf/util/cputopo.h tools/perf/util/header.c+25 -200 replies
4/8perf cputopo: Match thread_siblings to topology ABI nametools/perf/util/cputopo.c tools/perf/util/cputopo.h tools/perf/util/header.c+25 -180 replies
5/8perf expr: Add literal values starting with #tools/perf/util/expr.c tools/perf/util/expr.h tools/perf/util/expr.l +1 more+30 -60 replies
6/8perf expr: Add metric literals for topology.tools/perf/tests/expr.c tools/perf/util/expr.c+38 -10 replies
7/8perf expr: Move ID handling to its own functiontools/perf/util/expr.y+34 -262 replies
8/8perf expr: Add source_count for aggregating eventstools/perf/tests/expr.c tools/perf/util/evsel.c tools/perf/util/evsel.h +5 more+66 -120 replies

Reviews trailers per patch

1 of 8 patches has a Reviewed-by or Acked-by.

PatchJiri Olsa
1/8
2/8
3/8
4/8
5/8
6/8
7/8A-b
8/8

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/8] New function and literals for metrics

Add a test for hyphenated events that are common with Intel's icelake topdown events.

Try to tidy the existing cputopo code and make it more consistent with the sysfs ABI. Refactor the #smt_on literal parsing into a general literal token that we can use for more literals. This is then used for num_cpus, num_cores, num_dies and num_packages literals that use the existing topology code. Finally, a source_count function is added which is used to determine the number of events contributing to an aggregate event. The intent for these new literals and function is for them to be used in upcoming metrics.

v2. Split the handle_id function refactor out of adding the
source_count function as suggested-by Jiri Olsa <[email protected]>.

Ian Rogers (8):
perf test: Add expr test for events with hyphens perf cputopo: Update to use pakage_cpus
perf cputopo: Match die_siblings to topology ABI name perf cputopo: Match thread_siblings to topology ABI name perf expr: Add literal values starting with # perf expr: Add metric literals for topology. perf expr: Move ID handling to its own function perf expr: Add source_count for aggregating events

 tools/perf/tests/expr.c       | 34 ++++++++++++++-
 tools/perf/util/cputopo.c     | 78 ++++++++++++++++++-----------------
 tools/perf/util/cputopo.h     | 33 ++++++++++++---
 tools/perf/util/evsel.c       | 12 ++++++
 tools/perf/util/evsel.h       |  1 +
 tools/perf/util/expr.c        | 65 ++++++++++++++++++++++++++---
 tools/perf/util/expr.h        |  4 ++
 tools/perf/util/expr.l        | 16 ++++++-
 tools/perf/util/expr.y        | 72 ++++++++++++++++++--------------
 tools/perf/util/header.c      | 20 ++++-----
 tools/perf/util/stat-shadow.c |  7 +++-
 11 files changed, 250 insertions(+), 92 deletions(-)
Signature · 1 line
2.34.0.rc1.387.gb447b232ab-goog