Skip to content

Change bpftool, libbpf, selftests to force GNU89 mode

Kumar Kartikeya Dwivedi bpf 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest6 patches 6 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6bpftool: Compile using -std=gnu89tools/bpf/bpftool/Makefile+1 -10 replies
2/6libbpf: fix non-C89 loop variable declaration in gen_loader.ctools/lib/bpf/gen_loader.c+2 -10 replies
3/6libbpf: Compile using -std=gnu89tools/lib/bpf/Makefile+1 -00 replies
4/6selftests/bpf: Fix non-C89 loop variable declaration instancestools/testing/selftests/bpf/prog_tests/d_path.c tools/testing/selftests/bpf/prog_tests/timer_mim.c tools/testing/selftests/bpf/prog_tests/xdp_bonding.c +1 more+8 -80 replies
5/6selftests/bpf: Switch to non-unicode character in outputtools/testing/selftests/bpf/bench.c+3 -30 replies
6/6selftests/bpf: Compile using -std=gnu89tools/testing/selftests/bpf/Makefile+4 -10 replies

Reviews trailers per patch

1 of 6 patches has a Reviewed-by or Acked-by.

PatchKumar Kartikeya Dwivedi
1/6
2/6A-b
3/6
4/6
5/6
6/6

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH bpf-next v1 0/6] Change bpftool, libbpf, selftests to force GNU89 mode

Fix any remaining instances that fail the build in this mode. For selftests, we also need to separate CXXFLAGS from CFLAGS, since adding it to CFLAGS simply would generate a warning when used with g++.

This also cherry-picks Andrii's patch to fix the instance in libbpf. Also tested introducing new invalid usage of C99 features.

Andrii Nakryiko (1):
libbpf: fix non-C89 loop variable declaration in gen_loader.c

Kumar Kartikeya Dwivedi (5):
bpftool: Compile using -std=gnu89
libbpf: Compile using -std=gnu89
selftests/bpf: Fix non-C89 loop variable declaration instances selftests/bpf: Switch to non-unicode character in output selftests/bpf: Compile using -std=gnu89

 tools/bpf/bpftool/Makefile                           | 2 +-
 tools/lib/bpf/Makefile                               | 1 +
 tools/lib/bpf/gen_loader.c                           | 3 ++-
 tools/testing/selftests/bpf/Makefile                 | 5 ++++-
 tools/testing/selftests/bpf/bench.c                  | 6 +++---
 tools/testing/selftests/bpf/prog_tests/d_path.c      | 4 ++--
 tools/testing/selftests/bpf/prog_tests/timer_mim.c   | 6 +++---
 tools/testing/selftests/bpf/prog_tests/xdp_bonding.c | 4 ++--
 tools/testing/selftests/bpf/test_progs.c             | 2 +-
 9 files changed, 19 insertions(+), 14 deletions(-)
Signature · 1 line
2.33.1