task comm cleanups
Status from this message: [merged] tools-testing-selftests-bpf-replace-open-coded-16-with-task_comm_len.patch removed from -mm tree
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest7 patches 35 repliesApplied 7/7
- v17 patches 17 repliesSuperseded
Changes in v2 from the cover letter
- improve the subject and description
- add comment to explain the hard-coded 16 in patch #4
Patches in v2 All 7 applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/7 | fs/exec: replace strlcpy with strscpy_pad in __set_task_commfs/ | +1 | 0 replies | Applied |
| 2/7 | fs/exec: replace strncpy with strscpy_pad in __get_task_commfs/ | +2 | 0 replies | Applied |
| 3/7 | drivers/infiniband: replace open-coded string copy with get_task_commdrivers/ drivers/ | +2 | 0 replies | Applied |
| 4/7 | fs/binfmt_elf: replace open-coded string copy with get_task_commfs/ include/ include/ | +11 | 4 replies | Applied |
| 5/7 | samples/bpf/test_overhead_kprobe_kern: replace bpf_probe_read_kernel with bpf_probe_read_kernel_str to get task commsamples/ samples/ samples/ | +11 | 0 replies | Applied |
| 6/7 | tools/bpf/bpftool/skeleton: replace bpf_probe_read_kernel with bpf_probe_read_kernel_str to get task commtools/ | +2 | 0 replies | Applied |
| 7/7 | tools/testing/selftests/bpf: replace open-coded 16 with TASK_COMM_LENinclude/ tools/ tools/ | +13 | 31 replies | Applied |
Reviews trailers per patch
All 7 patches have a Reviewed-by or Acked-by.
| Patch | Kees Cook | David Hildenbrand | Dennis Dalessandro | Andrii Nakryiko |
|---|---|---|---|---|
| 1/7 | R-b | R-b | ||
| 2/7 | R-b | R-b | ||
| 3/7 | R-b | A-b | ||
| 4/7 | R-b | |||
| 5/7 | R-b | R-b | A-b | |
| 6/7 | R-b | A-b | ||
| 7/7 | A-b | A-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.
Cover letter [PATCH v2 0/7] task comm cleanups
This patchset is part of the patchset "extend task comm from 16 to 24"[1]. Now we have different opinion that dynamically allocates memory to store kthread's long name into a separate pointer, so I decide to take the useful cleanups apart from the original patchset and send it separately[2].
These useful cleanups can make the usage around task comm less error-prone. Furthermore, it will be useful if we want to extend task comm in the future.
[1]. https://lore.kernel.org/lkml/[email protected]/
[2]. https://lore.kernel.org/lkml/CALOAHbAx55AUo3bm8ZepZSZnw7A08cvKPdPyNTf=E_tPqmw5hw@mail.gmail.com/
Changes since v1:
- improve the subject and description
- add comment to explain the hard-coded 16 in patch #4
Yafang Shao (7):
fs/exec: replace strlcpy with strscpy_pad in __set_task_comm fs/exec: replace strncpy with strscpy_pad in __get_task_comm drivers/infiniband: replace open-coded string copy with get_task_comm fs/binfmt_elf: replace open-coded string copy with get_task_comm samples/bpf/test_overhead_kprobe_kern: replace bpf_probe_read_kernel
with bpf_probe_read_kernel_str to get task comm
tools/bpf/bpftool/skeleton: replace bpf_probe_read_kernel with
bpf_probe_read_kernel_str to get task comm
tools/testing/selftests/bpf: replace open-coded 16 with TASK_COMM_LEN
drivers/infiniband/hw/qib/qib.h | 2 +- drivers/infiniband/hw/qib/qib_file_ops.c | 2 +- fs/binfmt_elf.c | 2 +- fs/exec.c | 5 +++-- include/linux/elfcore-compat.h | 5 +++++ include/linux/elfcore.h | 5 +++++ include/linux/sched.h | 9 +++++++-- samples/bpf/offwaketime_kern.c | 4 ++-- samples/bpf/test_overhead_kprobe_kern.c | 11 ++++++----- samples/bpf/test_overhead_tp_kern.c | 5 +++-- tools/bpf/bpftool/skeleton/pid_iter.bpf.c | 4 ++-- .../testing/selftests/bpf/progs/test_stacktrace_map.c | 6 +++--- tools/testing/selftests/bpf/progs/test_tracepoint.c | 6 +++--- 13 files changed, 42 insertions(+), 24 deletions(-)
Signature · 1 line
2.17.1