x86: Fix ARCH_REQ_XCOMP_PERM and update the test
Status from this message: The following commit has been merged into the x86/urgent branch of tip:
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v4 Latest2 patches 11 repliesApplied
- v32 patches 0 repliesSuperseded
- v22 patches 0 repliesSuperseded
Earlier versions · 1
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v1 | 2 patches | 1 reply | Superseded |
Changes in v4 from the cover letter
* Rebased onto 5.17-rc1.
Patches in v4 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/2 | x86/arch_prctl: Fix the ARCH_REQ_XCOMP_PERM implementationarch/ | +1 | 3 replies | |
| 2/2 | selftests/x86/amx: Update the ARCH_REQ_XCOMP_PERM testtools/ | +14 | 2 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v4 yet.
Cover letter [PATCH v4 0/2] x86: Fix ARCH_REQ_XCOMP_PERM and update the test
Changes from V3:
* Rebased onto 5.17-rc1.
V3: https://lore.kernel.org/lkml/[email protected]/
---
The recent x86 dynamic state support incorporates the arch_prctl option to request permission before using a dynamic state.
It was designed to add the requested feature in the group leader's permission bitmask so that every thread can reference this master bitmask. The group leader is assumed to be unchanged here. The mainline is the case as a group leader is identified at fork() or exec() time only.
This master bitmask should include non-dynamic features always, as they are permitted by default. Users may check them via ARCH_GET_XCOMP_PERM.
But, in hindsight, the implementation does overwrite the bitmask with the requested bit only, instead of adding the bit to the existing one. This overwrite effectively revokes the permission that is granted already.
Fix the code and also update the selftest to disclose the issue if there is.
Chang S. Bae (1):
selftests/x86/amx: Update the ARCH_REQ_XCOMP_PERM test
Yang Zhong (1):
x86/arch_prctl: Fix the ARCH_REQ_XCOMP_PERM implementation
arch/x86/kernel/fpu/xstate.c | 2 +- tools/testing/selftests/x86/amx.c | 16 ++++++++++++++-- 2 files changed, 15 insertions(+), 3 deletions(-)
base-commit: e783362eb54cd99b2cac8b3a9aeac942e6f6ac07
Signature · 1 line
2.17.1