mm: Rework zap ptes on swap entries
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v5 Latest4 patches 0 repliesNew
- v44 patches 10 repliesSuperseded 3 of 4 applied
- v34 patches 5 repliesSuperseded
Earlier versions · 2
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v2 RFC | 2 patches | 24 replies | Superseded | |
| v1 RFC | 2 patches | 2 replies | Superseded |
Changes in v5 from the cover letter
- Patch 1:
- A few comment fixups in patch 1 [John]
- Tweak commit message (s/user/caller/) [Andrew]
- Add r-bs for John
- Reindent commit messages to 75 columns [John]
Patches in v5 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/4 | mm: Don't skip swap entry even if zap_details specifiedmm/ | +31 | 0 replies | |
| 2/4 | mm: Rename zap_skip_check_mapping() to should_zap_page()mm/ | +8 | 0 replies | |
| 3/4 | mm: Change zap_details.zap_mapping into even_cowsmm/ | +7 | 0 replies | |
| 4/4 | mm: Rework swap handling of zap_pte_rangemm/ | +6 | 0 replies |
Reviews trailers per patch
All 4 patches have a Reviewed-by or Acked-by.
| Patch | John Hubbard | David Hildenbrand |
|---|---|---|
| 1/4 | R-b | |
| 2/4 | R-b | R-b |
| 3/4 | R-b | |
| 4/4 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v5 0/4] mm: Rework zap ptes on swap entries
v5:
- Patch 1:
- A few comment fixups in patch 1 [John]
- Tweak commit message (s/user/caller/) [Andrew]
- Add r-bs for John
- Reindent commit messages to 75 columns [John]
RFC V1: https://lore.kernel.org/lkml/[email protected] RFC V2: https://lore.kernel.org/lkml/[email protected] V3: https://lore.kernel.org/lkml/[email protected] V4: https://lore.kernel.org/lkml/[email protected]
Patch 1 should fix a long standing bug for zap_pte_range() on zap_details usage. The risk is we could have some swap entries skipped while we should have zapped them.
Migration entries are not the major concern because file backed memory always zap in the pattern that "first time without page lock, then re-zap with page lock" hence the 2nd zap will always make sure all migration entries are already recovered.
However there can be issues with real swap entries got skipped errornoously. There's a reproducer provided in commit message of patch 1 for that.
Patch 2-4 are cleanups that are based on patch 1. After the whole patchset applied, we should have a very clean view of zap_pte_range().
Only patch 1 needs to be backported to stable if necessary.
Please review, thanks.
Peter Xu (4):
mm: Don't skip swap entry even if zap_details specified
mm: Rename zap_skip_check_mapping() to should_zap_page()
mm: Change zap_details.zap_mapping into even_cows
mm: Rework swap handling of zap_pte_range
mm/memory.c | 80 ++++++++++++++++++++++++++++++----------------------- 1 file changed, 45 insertions(+), 35 deletions(-)
Signature · 1 line
2.32.0