Skip to content

KVM: selftests: Hugepage fixes and cleanups

David Matlack kvm 1 version Applied

Status from this message: Queued, thanks.

Get series with b4
b4 am [email protected]

Versions newest first

  1. v2 Latest12 patches 6 repliesApplied

Changes in v2 from the cover letter

- Add separate align up/down helpers and use the throughout the series rather than openly coding the bitwise math [Ben, Paolo]
- Do no pad HugeTLB mmaps [Yanan]
- Drop "[PATCH 04/15] KVM: selftests: Force stronger HVA alignment (1gb) for hugepages" since HugeTLB does not require manual HVA alignment [David]
- Drop "[PATCH 15/15] KVM: selftests: Get rid of gorilla math in memslots modification test" since the gorilla math no longer exists [David]
- Drop "[PATCH 14/15] KVM: selftests: Track size of per-VM memslot in perf_test_args" since it was just a prep patch for [PATCH 15/15] [David]
- Update the series to kvm/next [David]

Patches in v2 Applied

#Subject and filesSizeRepliesApplied
1/12KVM: selftests: Explicitly state indicies for vm_guest_mode_params arraytools/testing/selftests/kvm/lib/kvm_util.c+9 -90 replies
2/12KVM: selftests: Expose align() helpers to teststools/testing/selftests/kvm/dirty_log_test.c tools/testing/selftests/kvm/include/test_util.h tools/testing/selftests/kvm/kvm_page_table_test.c +3 more+34 -191 reply
3/12KVM: selftests: Assert mmap HVA is aligned when using HugeTLBtools/testing/selftests/kvm/include/test_util.h tools/testing/selftests/kvm/lib/kvm_util.c tools/testing/selftests/kvm/lib/test_util.c+17 -00 replies
4/12KVM: selftests: Require GPA to be aligned when backed by hugepagestools/testing/selftests/kvm/lib/kvm_util.c tools/testing/selftests/kvm/lib/perf_test_util.c+8 -12 replies
5/12KVM: selftests: Use shorthand local var to access struct perf_tests_argstools/testing/selftests/kvm/lib/perf_test_util.c+19 -160 replies
6/12KVM: selftests: Capture per-vCPU GPA in perf_test_vcpu_argstools/testing/selftests/kvm/include/perf_test_util.h tools/testing/selftests/kvm/lib/perf_test_util.c+5 -50 replies
7/12KVM: selftests: Use perf util's per-vCPU GPA/pages in demand paging testtools/testing/selftests/kvm/demand_paging_test.c+5 -160 replies
8/12KVM: selftests: Move per-VM GPA into perf_test_argstools/testing/selftests/kvm/include/perf_test_util.h tools/testing/selftests/kvm/lib/perf_test_util.c tools/testing/selftests/kvm/memslot_modification_stress_test.c+10 -210 replies
9/12KVM: selftests: Remove perf_test_args.host_page_sizetools/testing/selftests/kvm/include/perf_test_util.h tools/testing/selftests/kvm/lib/perf_test_util.c+1 -30 replies
10/12KVM: selftests: Create VM with adjusted number of guest pages for perf teststools/testing/selftests/kvm/lib/perf_test_util.c+6 -20 replies
11/12KVM: selftests: Fill per-vCPU struct during "perf_test" VM creationtools/testing/selftests/kvm/access_tracking_perf_test.c tools/testing/selftests/kvm/demand_paging_test.c tools/testing/selftests/kvm/dirty_log_perf_test.c +3 more+45 -541 reply
12/12KVM: selftests: Sync perf_test_args to guest during VM creationtools/testing/selftests/kvm/access_tracking_perf_test.c tools/testing/selftests/kvm/demand_paging_test.c tools/testing/selftests/kvm/dirty_log_perf_test.c +3 more+16 -151 reply

Reviews trailers per patch

10 of 12 patches have a Reviewed-by or Acked-by.

PatchBen Gardon
1/12R-b
2/12R-b
3/12
4/12
5/12R-b
6/12R-b
7/12R-b
8/12R-b
9/12R-b
10/12R-b
11/12R-b
12/12R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 00/12] KVM: selftests: Hugepage fixes and cleanups

Fix hugepage bugs in the KVM selftests that specifically affect dirty logging and demand paging tests. Found while attempting to verify KVM changes/fixes related to hugepages and dirty logging (patches incoming in a separate series).

Clean up the perf_test_args util on top of the hugepage fixes to clarify what "page size" means, and to improve confidence in the code doing what it thinks it's doing. In a few cases, users of perf_test_args were duplicating (approximating?) calculations made by perf_test_args, and it wasn't obvious that both pieces of code were guaranteed to end up with the same result.

v2:
- Add separate align up/down helpers and use the throughout the series rather than openly coding the bitwise math [Ben, Paolo]
- Do no pad HugeTLB mmaps [Yanan]
- Drop "[PATCH 04/15] KVM: selftests: Force stronger HVA alignment (1gb) for hugepages" since HugeTLB does not require manual HVA alignment [David]
- Drop "[PATCH 15/15] KVM: selftests: Get rid of gorilla math in memslots modification test" since the gorilla math no longer exists [David]
- Drop "[PATCH 14/15] KVM: selftests: Track size of per-VM memslot in perf_test_args" since it was just a prep patch for [PATCH 15/15] [David]
- Update the series to kvm/next [David]

v1: https://lore.kernel.org/kvm/[email protected]/.

Sean Christopherson (12):
KVM: selftests: Explicitly state indicies for vm_guest_mode_params
array
KVM: selftests: Expose align() helpers to tests
KVM: selftests: Assert mmap HVA is aligned when using HugeTLB
KVM: selftests: Require GPA to be aligned when backed by hugepages
KVM: selftests: Use shorthand local var to access struct
perf_tests_args
KVM: selftests: Capture per-vCPU GPA in perf_test_vcpu_args
KVM: selftests: Use perf util's per-vCPU GPA/pages in demand paging
test
KVM: selftests: Move per-VM GPA into perf_test_args
KVM: selftests: Remove perf_test_args.host_page_size
KVM: selftests: Create VM with adjusted number of guest pages for perf
tests
KVM: selftests: Fill per-vCPU struct during "perf_test" VM creation
KVM: selftests: Sync perf_test_args to guest during VM creation

 .../selftests/kvm/access_tracking_perf_test.c |   8 +-
 .../selftests/kvm/demand_paging_test.c        |  31 +----
 .../selftests/kvm/dirty_log_perf_test.c       |  10 +-
 tools/testing/selftests/kvm/dirty_log_test.c  |   6 +-
 .../selftests/kvm/include/perf_test_util.h    |  18 +--
 .../testing/selftests/kvm/include/test_util.h |  26 ++++
 .../selftests/kvm/kvm_page_table_test.c       |   2 +-
 tools/testing/selftests/kvm/lib/elf.c         |   3 +-
 tools/testing/selftests/kvm/lib/kvm_util.c    |  44 +++---
 .../selftests/kvm/lib/perf_test_util.c        | 126 ++++++++++--------
 tools/testing/selftests/kvm/lib/test_util.c   |   5 +
 .../kvm/memslot_modification_stress_test.c    |  13 +-
 12 files changed, 153 insertions(+), 139 deletions(-)
Signature · 1 line
2.34.0.rc1.387.gb447b232ab-goog