Skip to content

More verifications for kwbimage in SPL

Marek Behún u-boot 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest9 patches 2 repliesIn review
  2. v29 patches 15 repliesSuperseded
  3. v15 patches 5 repliesSuperseded

Changes in v3 from the cover letter

- changed the error message in patch 6 according to Pali's suggestion
- added R-B tags

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/9arm: mvebu: Check that kwbimage offset and blocksize are validarch/arm/mach-mvebu/spl.c+12 -00 replies
2/9SPL: Add struct spl_boot_device parameter into spl_parse_board_header()arch/arm/mach-mvebu/spl.c arch/arm/mach-sunxi/spl_spi_sunxi.c common/spl/spl.c +19 more+90 -560 replies
3/9arm: mvebu: Check that kwbimage blockid matches boot modearch/arm/mach-mvebu/spl.c+26 -90 replies
4/9SPL: Add support for checking board / BootROM specific image typescommon/spl/spl.c+9 -00 replies
5/9arm: mvebu: Check for kwbimage data checksumarch/arm/mach-mvebu/spl.c+27 -00 replies
6/9arm: mvebu: spl: Print srcaddr in error messagearch/arm/mach-mvebu/spl.c+2 -10 replies
7/9arm: mvebu: spl: Use preferred types u8/u16/u32 instead of uintN_tarch/arm/mach-mvebu/spl.c+17 -170 replies
8/9arm: mvebu: spl: Use IS_ENABLED() instead of #ifdef where possiblearch/arm/mach-mvebu/spl.c+18 -250 replies
9/9arm: mvebu: spl: Fix 100 column exceedsarch/arm/mach-mvebu/spl.c+4 -20 replies

Reviews trailers per patch

All 9 patches have a Reviewed-by or Acked-by.

PatchStefan Roese
1/9R-b
2/9R-b
3/9R-b
4/9R-b
5/9R-b
6/9R-b
7/9R-b
8/9R-b
9/9R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH u-boot-marvell v3 0/9] More verifications for kwbimage in SPL

From: Marek Behún <[email protected]>

Hello Stefan,

this is v3 of series that adds more checks for kwbimage validity and consistency to SPL, mainly checking image data checksum.

Changes since v2:
- changed the error message in patch 6 according to Pali's suggestion
- added R-B tags

Changes since v1:
- updated error messages as requested by Stefan
- fixed checkpatch warnings for uintN_t types (converted to preferred uN)
- added more checkpatch fixes

Marek

Marek Behún (4):
arm: mvebu: spl: Print srcaddr in error message
arm: mvebu: spl: Use preferred types u8/u16/u32 instead of uintN_t
arm: mvebu: spl: Use IS_ENABLED() instead of #ifdef where possible
arm: mvebu: spl: Fix 100 column exceeds

Pali Rohár (5):
arm: mvebu: Check that kwbimage offset and blocksize are valid
SPL: Add struct spl_boot_device parameter into
spl_parse_board_header()
arm: mvebu: Check that kwbimage blockid matches boot mode
SPL: Add support for checking board / BootROM specific image types
arm: mvebu: Check for kwbimage data checksum

 arch/arm/mach-mvebu/spl.c           | 153 +++++++++++++++++++---------
 arch/arm/mach-sunxi/spl_spi_sunxi.c |   2 +-
 common/spl/spl.c                    |  13 ++-
 common/spl/spl_ext.c                |   9 +-
 common/spl/spl_fat.c                |  11 +-
 common/spl/spl_legacy.c             |   3 +-
 common/spl/spl_mmc.c                |  43 +++++---
 common/spl/spl_nand.c               |   5 +-
 common/spl/spl_net.c                |   2 +-
 common/spl/spl_nor.c                |   4 +-
 common/spl/spl_onenand.c            |   2 +-
 common/spl/spl_ram.c                |   2 +-
 common/spl/spl_sata.c               |   9 +-
 common/spl/spl_sdp.c                |   2 +-
 common/spl/spl_spi.c                |   9 +-
 common/spl/spl_ubi.c                |   4 +-
 common/spl/spl_usb.c                |   4 +-
 common/spl/spl_xip.c                |   4 +-
 common/spl/spl_ymodem.c             |   4 +-
 drivers/usb/gadget/f_sdp.c          |  12 ++-
 include/sdp.h                       |   3 +-
 include/spl.h                       |   7 ++
 22 files changed, 201 insertions(+), 106 deletions(-)
Signature · 1 line
2.32.0