Skip to content

fs/binfmt_elf: Fix AT_PHDR for unusual ELF files

Akira Kawata linux-fsdevel lkml 7 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest2 patches 0 repliesNew 1 of 2 applied
  2. v4 posting 3/32 patches 2 repliesSuperseded
  3. v4 posting 2/30 of 2 patches 1 replySuperseded
Earlier versions · 4
VersionPostedPatchesRepliesStatus
v4 posting 1/32 patches6 repliesApplied 2/4
v31 patch0 repliesSuperseded
v21 patch0 repliesSuperseded
v11 patch0 repliesSuperseded

Changes in v5 from the cover letter

- Reflecting on comments from Kees, add a comment to the first commit.

Patches in v5 1 of 2 applied

#Subject and filesSizeRepliesApplied
1/2fs/binfmt_elf: Fix AT_PHDR for unusual ELF filesfs/binfmt_elf.c+18 -60 repliesApplied
2/2fs/binfmt_elf: Refactor load_elf_binary functionfs/binfmt_elf.c+8 -100 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchKees Cook
1/2A-b
2/2A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v5 thread

Cover letter [PATCH v5 0/2] fs/binfmt_elf: Fix AT_PHDR for unusual ELF files

These patches fix a bug in AT_PHDR calculation.

We cannot calculate AT_PHDR as the sum of load_addr and exec->e_phoff. This is because exec->e_phoff is the offset of PHDRs in the file and the address of PHDRs in the memory may differ from it. These patches fix the bug by calculating the address of program headers from PT_LOADs directly.

Changes in v5
- Reflecting on comments from Kees, add a comment to the first commit.

Changes in v4
- Reflecting on comments from Lukas, add a refactoring commit.

Changes in v3:
- Fix a reported bug from kernel test robot.

Changes in v2:
- Remove unused load_addr from create_elf_tables.
- Improve the commit message.

Akira Kawata (2):
fs/binfmt_elf: Fix AT_PHDR for unusual ELF files fs/binfmt_elf: Refactor load_elf_binary function

 fs/binfmt_elf.c | 40 +++++++++++++++++++++++++---------------
 1 file changed, 25 insertions(+), 15 deletions(-)

base-commit: 0eb96e2c58c03e79fc2ee833ba88bf9226986564

Signature · 1 line
2.25.1