Skip to content

Fix BUG_ON in vfio_iommu_group_notifier()

Lu Baolu linux-iommu lkml 9 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v8 Latest posting 2/211 patches 23 repliesIn review
  2. v8 posting 1/211 patches 13 repliesSuperseded
  3. v711 patches 15 repliesSuperseded
Earlier versions · 6
VersionPostedPatchesRepliesStatus
v611 patches33 repliesSuperseded
v514 patches41 repliesSuperseded
v413 patches33 repliesSuperseded
v318 patches32 repliesSuperseded
v217 patches9 repliesSuperseded
v111 patches48 repliesSuperseded

Change log from the cover letter

- v8 and before:
- Please refer to v8 post for all the change history.

- v8-resend
- Rebase the series on top of v5.18-rc3.
- Add Reviewed-by's granted by Robin.
- Add a Tested-by granted by Eric.

Patches in v8 posting 2/2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/11iommu: Add DMA ownership management interfacesdrivers/iommu/iommu.c include/linux/iommu.h+181 -33 replies
2/11driver core: Add dma_cleanup callback in bus_typedrivers/base/dd.c include/linux/device/bus.h+8 -00 replies
3/11amba: Stop sharing platform_dma_configure()drivers/amba/bus.c drivers/base/platform.c include/linux/platform_device.h+19 -50 replies
4/11bus: platform,amba,fsl-mc,PCI: Add device DMA ownership managementdrivers/amba/bus.c drivers/base/platform.c drivers/bus/fsl-mc/fsl-mc-bus.c +5 more+108 -23 replies
5/11PCI: pci_stub: Set driver_managed_dmadrivers/pci/pci-stub.c+1 -00 replies
6/11PCI: portdrv: Set driver_managed_dmadrivers/pci/pcie/portdrv_pci.c+2 -00 replies
7/11vfio: Set DMA ownership for VFIO devicesdrivers/vfio/fsl-mc/vfio_fsl_mc.c drivers/vfio/pci/vfio_pci.c drivers/vfio/platform/vfio_amba.c +2 more+13 -10 replies
8/11vfio: Remove use of vfio_group_viable()drivers/vfio/vfio.c+6 -120 replies
9/11vfio: Delete the unbound_listdrivers/vfio/vfio.c+2 -720 replies
10/11vfio: Remove iommu group notifierdrivers/vfio/vfio.c+0 -1470 replies
11/11iommu: Remove iommu group changes notifierdrivers/iommu/iommu.c include/linux/iommu.h+0 -980 replies

Reviews trailers per patch

All 11 patches have a Reviewed-by or Acked-by.

PatchRobin MurphyGreg Kroah-HartmanJason GunthorpeEric AugerBjorn HelgaasAlex WilliamsonChaitanya Kulkarni
1/11R-b
2/11R-b R-b
3/11R-b
4/11R-b R-b R-b T-b
5/11R-b A-b
6/11R-b A-b
7/11R-b A-b
8/11R-b A-b
9/11A-b R-b
10/11R-b A-b
11/11R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 7 reviewers.

Read the v8 thread

Cover letter [RESEND PATCH v8 00/11] Fix BUG_ON in vfio_iommu_group_notifier()

Hi Joerg,

This is a resend version of v8 posted here:
https://lore.kernel.org/linux-iommu/[email protected]/
as we discussed in this thread:
https://lore.kernel.org/linux-iommu/Yk%[email protected]/

All patches can be applied perfectly except this one:
- [PATCH v8 02/11] driver core: Add dma_cleanup callback in bus_type
It conflicts with below refactoring commit:
- 4b775aaf1ea99 "driver core: Refactor sysfs and drv/bus remove hooks"
The conflict has been fixed in this post.

No functional changes in this series. I suppress cc-ing this series to all v8 reviewers in order to avoid spam.

Please consider it for your iommu tree.

Best regards,
baolu

Change log:
- v8 and before:
- Please refer to v8 post for all the change history.

- v8-resend
- Rebase the series on top of v5.18-rc3.
- Add Reviewed-by's granted by Robin.
- Add a Tested-by granted by Eric.

Jason Gunthorpe (1):
vfio: Delete the unbound_list

Lu Baolu (10):
iommu: Add DMA ownership management interfaces
driver core: Add dma_cleanup callback in bus_type
amba: Stop sharing platform_dma_configure()
bus: platform,amba,fsl-mc,PCI: Add device DMA ownership management
PCI: pci_stub: Set driver_managed_dma
PCI: portdrv: Set driver_managed_dma
vfio: Set DMA ownership for VFIO devices
vfio: Remove use of vfio_group_viable()
vfio: Remove iommu group notifier
iommu: Remove iommu group changes notifier

 include/linux/amba/bus.h              |   8 +
 include/linux/device/bus.h            |   3 +
 include/linux/fsl/mc.h                |   8 +
 include/linux/iommu.h                 |  54 +++---
 include/linux/pci.h                   |   8 +
 include/linux/platform_device.h       |  10 +-
 drivers/amba/bus.c                    |  37 +++-
 drivers/base/dd.c                     |   5 +
 drivers/base/platform.c               |  21 ++-
 drivers/bus/fsl-mc/fsl-mc-bus.c       |  24 ++-
 drivers/iommu/iommu.c                 | 228 ++++++++++++++++--------
 drivers/pci/pci-driver.c              |  18 ++
 drivers/pci/pci-stub.c                |   1 +
 drivers/pci/pcie/portdrv_pci.c        |   2 +
 drivers/vfio/fsl-mc/vfio_fsl_mc.c     |   1 +
 drivers/vfio/pci/vfio_pci.c           |   1 +
 drivers/vfio/platform/vfio_amba.c     |   1 +
 drivers/vfio/platform/vfio_platform.c |   1 +
 drivers/vfio/vfio.c                   | 245 ++------------------------
 19 files changed, 338 insertions(+), 338 deletions(-)
Signature · 6 lines
2.25.1

_______________________________________________
iommu mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/iommu