Skip to content

dmaengine: kill off dma_slave_config->slave_id

Arnd Bergmann alsa-devel dmaengine dri-devel linux-arm-kernel linux-arm-msm linux-mmc linux-mtd linux-serial linux-spi linux-staging linux-tegra lkml 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest11 patches 7 repliesIn review
  2. v111 patches 22 repliesSuperseded

Changes in v2 from the cover letter

- drop obsolete drivers/staging/patch
- split tegra change into a separate patch
- improve some patch descriptions.

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/11ASoC: tegra20-spdif: stop setting slave_idsound/soc/tegra/tegra20_spdif.c+0 -14 replies
2/11ASoC: dai_dma: remove slave_id fieldinclude/sound/dmaengine_pcm.h sound/core/pcm_dmaengine.c+2 -50 replies
3/11spi: pic32: stop setting dma_config->slave_iddrivers/spi/spi-pic32.c+0 -20 replies
4/11mmc: bcm2835: stop setting chan_config->slave_iddrivers/mmc/host/bcm2835.c+0 -21 reply
5/11dmaengine: shdma: remove legacy slave_id parsingdrivers/dma/sh/shdma-base.c+0 -80 replies
6/11dmaengine: pxa/mmp: stop referencing config->slave_iddrivers/dma/mmp_pdma.c drivers/dma/pxa_dma.c+0 -130 replies
7/11dmaengine: sprd: stop referencing config->slave_iddrivers/dma/sprd-dma.c+0 -30 replies
8/11dmaengine: qcom-adm: stop abusing slave_id configdrivers/dma/qcom/qcom_adm.c drivers/mtd/nand/raw/qcom_nandc.c drivers/tty/serial/msm_serial.c +1 more+86 -110 replies
9/11dmaengine: xilinx_dpdma: stop using slave_id fielddrivers/dma/xilinx/xilinx_dpdma.c drivers/gpu/drm/xlnx/zynqmp_disp.c include/linux/dma/xilinx_dpdma.h+29 -80 replies
10/11dmaengine: tegra20-apb: stop checking config->slave_iddrivers/dma/tegra20-apb-dma.c+0 -60 replies
11/11dmaengine: remove slave_id config fieldinclude/linux/dmaengine.h+0 -40 replies

Reviews trailers per patch

7 of 11 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchMark BrownNicolas Saenz JulienneLaurent PinchartBaolin WangUlf HanssonDmitry Osipenko
SeriesA-b
1/11R-b
2/11
3/11A-b
4/11R-b A-b
5/11R-b
6/11
7/11R-b
8/11
9/11R-b
10/11
11/11R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 6 reviewers.

Read the v2 thread

Cover letter [PATCH v2 00/11] dmaengine: kill off dma_slave_config->slave_id

From: Arnd Bergmann <[email protected]>

I recently came across some new uses of the 'slave_id' field that I had (almost) removed a few years ago. There are no legitimate uses of this field in the kernel, only a few stale references and two drivers that abuse the field as a side-channel between the dmaengine driver and its client.

Let's change the xilinx and qualcomm drivers to use the documented side-channel (peripheral_data) instead, and remove the remnants of it to prevent new users from coming in.

I think I got all the necessary Acks on v1 already, so if there are no further concerns, please merge this through the dmaengine tree for v5.17, or pull from

git://git.kernel.org/pub/scm/linux/kernel/git/arnd/asm-generic.git tags/dma-slave-id-removal

Arnd

Arnd Bergmann (13):
ASoC: tegra20-spdif: stop setting slave_id
ASoC: dai_dma: remove slave_id field
spi: pic32: stop setting dma_config->slave_id
mmc: bcm2835: stop setting chan_config->slave_id
dmaengine: shdma: remove legacy slave_id parsing
dmaengine: pxa/mmp: stop referencing config->slave_id
dmaengine: sprd: stop referencing config->slave_id
dmaengine: qcom-adm: stop abusing slave_id config
dmaengine: xilinx_dpdma: stop using slave_id field
dmaengine: tegra20-apb: stop checking config->slave_id
dmaengine: remove slave_id config field

---
Changes in v2:

- drop obsolete drivers/staging/patch
- split tegra change into a separate patch
- improve some patch descriptions.

 drivers/dma/mmp_pdma.c                 |  6 ---
 drivers/dma/pxa_dma.c                  |  7 ----
 drivers/dma/qcom/qcom_adm.c            | 56 ++++++++++++++++++++++----
 drivers/dma/sh/shdma-base.c            |  8 ----
 drivers/dma/sprd-dma.c                 |  3 --
 drivers/dma/tegra20-apb-dma.c          |  6 ---
 drivers/dma/xilinx/xilinx_dpdma.c      | 17 +++++---
 drivers/gpu/drm/xlnx/zynqmp_disp.c     |  9 ++++-
 drivers/mmc/host/bcm2835.c             |  2 -
 drivers/mtd/nand/raw/qcom_nandc.c      | 14 ++++++-
 drivers/spi/spi-pic32.c                |  2 -
 drivers/tty/serial/msm_serial.c        | 15 ++++++-
 include/linux/dma/qcom_adm.h           | 12 ++++++
 include/linux/dma/xilinx_dpdma.h       | 11 +++++
 include/linux/dmaengine.h              |  4 --
 include/linux/platform_data/asoc-s3c.h |  6 ---
 include/sound/dmaengine_pcm.h          |  4 --
 sound/core/pcm_dmaengine.c             | 26 +-----------
 sound/soc/tegra/tegra20_spdif.c        |  1 -
 27 files changed, 134 insertions(+), 146 deletions(-)
 create mode 100644 include/linux/dma/qcom_adm.h
 create mode 100644 include/linux/dma/xilinx_dpdma.h
Signature · 39 lines
2.29.2

Cc: Andy Gross <[email protected]>
Cc: Andy Shevchenko <[email protected]>
Cc: Arnd Bergmann <[email protected]>
Cc: Baolin Wang <[email protected]>
Cc: Bjorn Andersson <[email protected]>
Cc: Chunyan Zhang <[email protected]>
Cc: Greg Kroah-Hartman <[email protected]>
Cc: Hyun Kwon <[email protected]>
Cc: Jaroslav Kysela <[email protected]>
Cc: Jon Hunter <[email protected]>
Cc: Lars-Peter Clausen <[email protected]>
Cc: Laurent Pinchart <[email protected]>
Cc: Laxman Dewangan <[email protected]>
Cc: Manivannan Sadhasivam <[email protected]>
Cc: Mark Brown <[email protected]>
Cc: Michal Simek <[email protected]>
Cc: Nicolas Saenz Julienne <[email protected]>
Cc: Orson Zhai <[email protected]>
Cc: Robert Jarzmik <[email protected]>
Cc: Scott Branden <[email protected]>
Cc: Takashi Iwai <[email protected]>
Cc: Thierry Reding <[email protected]>
Cc: Vinod Koul <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]