serial: liteuart: fix driver unbind
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest3 patches 1 replyIn review
- v13 patches 6 repliesSuperseded
Changes in v2 from the cover letter
- allow compile testing without CONFIG_OF (Andy)
- reword commit message to clarify that LITEX is neither a build or runtime dependency and that the change only makes it easier to compile test the driver
- move the Kconfig patch last in the series
- add Stafford's reviewed by tags to the two unmodified patches
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | serial: liteuart: fix use-after-free and memleak on unbinddrivers/ | +1 | 0 replies | |
| 2/3 | serial: liteuart: fix minor-number leak on probe errorsdrivers/ | +14 | 0 replies | |
| 3/3 | serial: liteuart: relax compile-test dependenciesdrivers/ | +1 | 0 replies |
Reviews trailers per patch
2 of 3 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Stafford Horne | Andy Shevchenko |
|---|---|---|
| Series | R-b | |
| 1/3 | R-b | |
| 2/3 | R-b | |
| 3/3 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v2 0/3] serial: liteuart: fix driver unbind
Ilia Sergachev noted that the liteuart remove() function would trigger a NULL-pointer dereference if it was ever called since the driver data pointer was never initialised.
Turns out there are more bugs in this part of the driver which clearly has never been tested.
Also relax the Kconfig dependencies so that the driver can be compile-tested without first enabling a seemingly unrelated SoC controller driver.
Note that this series depends on the fix by Ilia:
https://lore.kernel.org/r/20211115031808.7ab632ef@dtkw
Johan
Changes in v2
- allow compile testing without CONFIG_OF (Andy)
- reword commit message to clarify that LITEX is neither a build or runtime dependency and that the change only makes it easier to compile test the driver
- move the Kconfig patch last in the series
- add Stafford's reviewed by tags to the two unmodified patches
Johan Hovold (3):
serial: liteuart: fix use-after-free and memleak on unbind
serial: liteuart: fix minor-number leak on probe errors
serial: liteuart: relax compile-test dependencies
drivers/tty/serial/Kconfig | 2 +- drivers/tty/serial/liteuart.c | 18 +++++++++++++++--- 2 files changed, 16 insertions(+), 4 deletions(-)
Signature · 1 line
2.32.0