Skip to content

Add support for list issue

Jens Axboe io-uring linux-block linux-nvme 5 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest4 patches 2 repliesIn review
  2. v44 patches 0 repliesSuperseded
  3. v34 patches 42 repliesSuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v24 patches11 repliesSuperseded
v14 patches20 repliesSuperseded

Changes in v5 from the cover letter

- Get rid of nvme_submit_cmd()
- Check for prev == NULL for batched issue

Patches in v5 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4block: add mq_ops->queue_rqs hookblock/blk-mq.c include/linux/blk-mq.h+31 -30 replies
2/4nvme: split command copy into a helperdrivers/nvme/host/pci.c+13 -151 reply
3/4nvme: separate command prep and issuedrivers/nvme/host/pci.c+36 -270 replies
4/4nvme: add support for mq_ops->queue_rqs()drivers/nvme/host/pci.c+59 -01 reply

Reviews trailers per patch

All 4 patches have a Reviewed-by or Acked-by.

PatchChristoph HellwigChaitanya KulkarniHannes ReineckeMax GurtovoyKeith Busch
1/4R-b
2/4R-b R-b R-b R-b
3/4R-b R-b
4/4R-b R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 5 reviewers.

Read the v5 thread

Cover letter [PATCHSET v5 0/4] Add support for list issue

Hi,

With the support in 5.16-rc1 for allocating and completing batches of IO, the one missing piece is passing down a list of requests for issue. Drivers can take advantage of this by defining an mq_ops->queue_rqs() hook.

This implements it for NVMe, allowing copy of multiple commands in one swoop.

This is good for around a 500K IOPS/core improvement in my testing, which is around a 5-6% improvement in efficiency.

Note to Christoph - I kept the copy helper, since it's used in 3 spots and I _think_ you ended up being fine with that...

Changes since v4:
- Get rid of nvme_submit_cmd()
- Check for prev == NULL for batched issue