tools/sparse: Add static check
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest3 patches 15 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | tools/sparse: Add static checktools/ | +53 | 9 replies | |
| 2/3 | doc: Add LTP-003 and LTP-004 static and tst API prefix rulesdoc/ doc/ doc/ | +20 | 4 replies | |
| 3/3 | statx: Add missing static keyword to tcase variabletestcases/ testcases/ testcases/ +2 more | +5 | 2 replies |
Reviews trailers per patch
All 3 patches have a Reviewed-by or Acked-by.
| Patch | Petr Vorel | Cyril Hrubis | Richard Palethorpe |
|---|---|---|---|
| 1/3 | A-b | R-b | |
| 2/3 | R-b | R-b | |
| 3/3 | R-b | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.
Cover letter [LTP] [PATCH 0/3] tools/sparse: Add static check
Hello,
This teaches 'make check' to flag missing static keywords. Note that I am not sure how this avoids flagging symbols only declared in header files. However I haven't noticed any false positives and I think false negatives will only occur when the author uses function prototypes to reference private symbols before their definition.
The statx patch is just included to show one issue it caught.
Richard Palethorpe (3):
tools/sparse: Add static check
doc: Add LTP-003 and LTP-004 static and tst API prefix rules
statx: Add missing static keyword to tcase variable
doc/library-api-writing-guidelines.txt | 10 +++++ doc/rules.tsv | 2 + doc/test-writing-guidelines.txt | 8 ++++ testcases/kernel/syscalls/statx/statx01.c | 2 +- testcases/kernel/syscalls/statx/statx02.c | 2 +- testcases/kernel/syscalls/statx/statx04.c | 2 +- testcases/kernel/syscalls/statx/statx05.c | 2 +- testcases/kernel/syscalls/statx/statx07.c | 2 +- tools/sparse/sparse-ltp.c | 53 +++++++++++++++++++++++ 9 files changed, 78 insertions(+), 5 deletions(-)
Signature · 5 lines
2.33.1 -- Mailing list info: https://lists.linux.it/listinfo/ltp