Skip to content

PCI: apple: Assorted #PERST fixes

Marc Zyngier linux-arm-kernel linux-pci lkml 2 versions In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest posting 2/23 patches 16 repliesIn review
  2. v3 posting 1/20 of 3 patches 0 repliesSuperseded

Patches in v3 posting 2/2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3PCI: apple: Follow the PCIe specifications when resetting the portdrivers/pci/controller/pcie-apple.c+10 -03 replies
2/3arm64: dts: apple: t8103: Fix PCIe #PERST polarityarch/arm64/boot/dts/apple/t8103.dtsi+4 -33 replies
3/3PCI: apple: Fix #PERST polaritydrivers/pci/controller/pcie-apple.c+2 -23 replies

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchPali RohárMark KettenisLuca CeresoliArnd Bergmann
1/3A-b R-b
2/3R-b R-b A-b
3/3R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v3 thread

Cover letter [PATCH v3 0/3] PCI: apple: Assorted #PERST fixes

Apologies for the rapid fire (I tend to be much more conservative when resending series), but given that this series has a direct impact on other projects (such as u-boot), I'm trying to converge as quickly as possible.

This series aims at fixing a number of issues for the recently merged Apple PCIe driver, all revolving around the mishandling of #PERST:

- we didn't properly drive #PERST, and we didn't follow the specified timings

- the DT had the wrong polarity, which has impacts on the driver itself

Hopefully, this should address all the issues reported so far.

* From v2:
- Fixed DT
- Fixed #PERST polarity in the driver
- Collected Pali's ack on patch #1

[1] https://lore.kernel.org/r/[email protected]

Marc Zyngier (3):
PCI: apple: Follow the PCIe specifications when resetting the port
arm64: dts: apple: t8103: Fix PCIe #PERST polarity
PCI: apple: Fix #PERST polarity

 arch/arm64/boot/dts/apple/t8103.dtsi |  7 ++++---
 drivers/pci/controller/pcie-apple.c  | 12 +++++++++++-
 2 files changed, 15 insertions(+), 4 deletions(-)
Signature · 1 line
2.30.2