Skip to content

sysctl: second set of kernel/sysctl cleanups

Luis Chamberlain dri-devel intel-gfx linux-block linux-fsdevel linuxppc-dev lkml ocfs2-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v2 Latest8 patches 5 repliesIn review 7 of 8 applied

Changes in v2 from the cover letter

* As suggested by Eric W. Biederman I dropped the subdir new call and just used the register_sysctl() by specifying the parent directory.
* 0-day cleanups, commit log enhancements
* Updated the coccinelle patch with register_sysctl()

Patches in v2 7 of 8 applied

#Subject and filesSizeRepliesApplied
1/8hpet: simplify subdirectory registration with register_sysctl()drivers/char/hpet.c+1 -210 repliesApplied
2/8i915: simplify subdirectory registration with register_sysctl()drivers/gpu/drm/i915/i915_perf.c+1 -211 replyApplied
3/8macintosh/mac_hid.c: simplify subdirectory registration with register_sysctl()drivers/macintosh/mac_hid.c+1 -230 repliesApplied
4/8ocfs2: simplify subdirectory registration with register_sysctl()fs/ocfs2/stackglue.c+1 -241 replyApplied
5/8test_sysctl: simplify subdirectory registration with register_sysctl()lib/test_sysctl.c+1 -210 repliesApplied
6/8inotify: simplify subdirectory registration with register_sysctl()fs/notify/inotify/inotify_user.c include/linux/inotify.h kernel/sysctl.c+10 -252 replies
7/8cdrom: simplify subdirectory registration with register_sysctl()drivers/cdrom/cdrom.c+1 -221 replyApplied
8/8eventpoll: simplify sysctl declaration with register_sysctl()fs/eventpoll.c include/linux/poll.h include/linux/sysctl.h +1 more+9 -110 repliesApplied

Reviews trailers per patch

3 of 8 patches have a Reviewed-by or Acked-by.

PatchJan KaraPhillip PotterJani Nikula
1/8
2/8A-b
3/8
4/8R-b
5/8
6/8
7/8R-b
8/8

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v2 thread

Cover letter [PATCH v2 0/8] sysctl: second set of kernel/sysctl cleanups

This is the 2nd set of kernel/sysctl.c cleanups. The diff stat should reflect how this is a much better way to deal with theses. Fortunately coccinelle can be used to ensure correctness for most of these and/or future merge conflicts.

Note that since this is part of a larger effort to cleanup kernel/sysctl.c I think we have no other option but to go with merging these patches in either Andrew's tree or keep them staged in a separate tree and send a merge request later. Otherwise kernel/sysctl.c will end up becoming a sore spot for the next merge window.

Changes in this v2:

* As suggested by Eric W. Biederman I dropped the subdir new call and just used the register_sysctl() by specifying the parent directory.
* 0-day cleanups, commit log enhancements
* Updated the coccinelle patch with register_sysctl()

Luis Chamberlain (6):
hpet: simplify subdirectory registration with register_sysctl()
i915: simplify subdirectory registration with register_sysctl() macintosh/mac_hid.c: simplify subdirectory registration with
register_sysctl()
ocfs2: simplify subdirectory registration with register_sysctl()
test_sysctl: simplify subdirectory registration with register_sysctl()
cdrom: simplify subdirectory registration with register_sysctl()

Xiaoming Ni (2):
inotify: simplify subdirectory registration with register_sysctl()
eventpoll: simplify sysctl declaration with register_sysctl()

 drivers/cdrom/cdrom.c            | 23 +----------------------
 drivers/char/hpet.c              | 22 +---------------------
 drivers/gpu/drm/i915/i915_perf.c | 22 +---------------------
 drivers/macintosh/mac_hid.c      | 24 +-----------------------
 fs/eventpoll.c                   | 10 +++++++++-
 fs/notify/inotify/inotify_user.c | 11 ++++++++++-
 fs/ocfs2/stackglue.c             | 25 +------------------------
 include/linux/inotify.h          |  3 ---
 include/linux/poll.h             |  2 --
 include/linux/sysctl.h           |  1 -
 kernel/sysctl.c                  | 28 ----------------------------
 lib/test_sysctl.c                | 22 +---------------------
 12 files changed, 25 insertions(+), 168 deletions(-)
Signature · 1 line
2.33.0