Skip to content

Armada 3720 PCIe fixes for 4.14

Marek Behún linux-arm-kernel linux-pci lkml stable 1 version Applied

Status from this message: This is a note to let you know that I've just added the patch titled

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest24 patches 1 replyApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/24PCI: aardvark: Fix I/O space page leakdrivers/pci/host/pci-aardvark.c+1 -10 replies
2/24PCI: aardvark: Fix a leaked reference by adding missing of_node_put()drivers/pci/host/pci-aardvark.c+8 -51 reply
3/24PCI: aardvark: Wait for endpoint to be ready before training linkdrivers/pci/host/pci-aardvark.c+8 -00 replies
4/24PCI: aardvark: Train link immediately after enabling trainingdrivers/pci/host/pci-aardvark.c+9 -60 replies
5/24PCI: aardvark: Improve link trainingdrivers/pci/host/pci-aardvark.c+89 -250 replies
6/24PCI: aardvark: Issue PERST via GPIOdrivers/pci/host/pci-aardvark.c+43 -10 replies
7/24PCI: aardvark: Replace custom macros by standard linux/pci_regs.h macrosdrivers/pci/host/pci-aardvark.c+19 -230 replies
8/24PCI: aardvark: Indicate error in 'val' when config read failsdrivers/pci/host/pci-aardvark.c+3 -10 replies
9/24PCI: aardvark: Introduce an advk_pcie_valid_device() helperdrivers/pci/host/pci-aardvark.c+11 -20 replies
10/24PCI: aardvark: Don't touch PCIe registers if no card connecteddrivers/pci/host/pci-aardvark.c+7 -00 replies
11/24PCI: aardvark: Fix compilation on s390drivers/pci/host/pci-aardvark.c+1 -10 replies
12/24PCI: aardvark: Move PCIe reset card code to advk_pcie_train_link()drivers/pci/host/pci-aardvark.c+34 -300 replies
13/24PCI: aardvark: Update comment about disabling link trainingdrivers/pci/host/pci-aardvark.c+8 -10 replies
14/24PCI: aardvark: Remove PCIe outbound window configurationdrivers/pci/host/pci-aardvark.c+0 -550 replies
15/24PCI: aardvark: Configure PCIe resources from 'ranges' DT propertydrivers/pci/host/pci-aardvark.c+189 -10 replies
16/24PCI: aardvark: Fix PCIe Max Payload Size settingdrivers/pci/host/pci-aardvark.c+2 -10 replies
17/24PCI: Add PCI_EXP_LNKCTL2_TLS* macrosinclude/uapi/linux/pci_regs.h+5 -00 replies
18/24PCI: aardvark: Fix link trainingdrivers/pci/host/pci-aardvark.c+34 -830 replies
19/24PCI: aardvark: Fix checking for link up via LTSSM statedrivers/pci/host/pci-aardvark.c+67 -40 replies
20/24pinctrl: armada-37xx: Correct mpp definitionsDocumentation/devicetree/bindings/pinctrl/marvell,armada-37xx-pinctrl.txt drivers/pinctrl/mvebu/pinctrl-armada-37xx.c+19 -90 replies
21/24pinctrl: armada-37xx: add missing pin: PCIe1 Wakeupdrivers/pinctrl/mvebu/pinctrl-armada-37xx.c+1 -00 replies
22/24pinctrl: armada-37xx: Correct PWM pins definitionsDocumentation/devicetree/bindings/pinctrl/marvell,armada-37xx-pinctrl.txt drivers/pinctrl/mvebu/pinctrl-armada-37xx.c+12 -130 replies
23/24arm64: dts: marvell: armada-37xx: declare PCIe reset pinarch/arm64/boot/dts/marvell/armada-37xx.dtsi+9 -00 replies
24/24arm64: dts: marvell: armada-37xx: Set pcie_reset_pin to gpio functionarch/arm64/boot/dts/marvell/armada-3720-db.dts arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts arch/arm64/boot/dts/marvell/armada-37xx.dtsi+7 -10 replies

Reviews trailers per patch

13 of 24 patches have a Reviewed-by or Acked-by.

PatchThomas PetazzoniLinus WalleijTomasz Maciej NowakRob HerringMarek BehúnVictor GuNadav HaklaiMiquel Raynal
1/24R-b R-b
2/24
3/24A-b
4/24A-b T-b A-b
5/24A-b T-b R-b
6/24A-b T-b
7/24A-b T-b R-b
8/24
9/24
10/24
11/24R-b
12/24T-b
13/24
14/24R-b R-b
15/24
16/24R-b
17/24
18/24R-b
19/24R-b
20/24T-b
21/24T-b
22/24A-b
23/24
24/24A-b T-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 8 reviewers.

Read the v1 thread

Cover letter [PATCH 4.14 00/24] Armada 3720 PCIe fixes for 4.14

Hello Greg, Sasha,

this series for 4.14-stable backports all the fixes (and their dependencies) for Armada 3720 PCIe driver.
These include:
- fixes (and their dependencies) for pci-aardvark controller
- fixes (and their dependencies) for pinctrl-armada-37xx driver
- device-tree fixes

Basically all fixes from upstream are taken, excluding those that need fix the emulated bridge, since that was introduced after 4.19. (Should we backport it? It concerns only mvebu and aardvark controllers...)

Marek

Evan Wang (1):
PCI: aardvark: Remove PCIe outbound window configuration

Frederick Lawler (1):
PCI: Add PCI_EXP_LNKCTL2_TLS* macros

Gregory CLEMENT (1):
pinctrl: armada-37xx: add missing pin: PCIe1 Wakeup

Marek Behún (4):
PCI: aardvark: Improve link training
pinctrl: armada-37xx: Correct mpp definitions
pinctrl: armada-37xx: Correct PWM pins definitions
arm64: dts: marvell: armada-37xx: Set pcie_reset_pin to gpio function

Miquel Raynal (1):
arm64: dts: marvell: armada-37xx: declare PCIe reset pin

Pali Rohár (12):
PCI: aardvark: Train link immediately after enabling training
PCI: aardvark: Issue PERST via GPIO
PCI: aardvark: Replace custom macros by standard linux/pci_regs.h
macros
PCI: aardvark: Indicate error in 'val' when config read fails
PCI: aardvark: Don't touch PCIe registers if no card connected
PCI: aardvark: Fix compilation on s390
PCI: aardvark: Move PCIe reset card code to advk_pcie_train_link()
PCI: aardvark: Update comment about disabling link training
PCI: aardvark: Configure PCIe resources from 'ranges' DT property
PCI: aardvark: Fix PCIe Max Payload Size setting
PCI: aardvark: Fix link training
PCI: aardvark: Fix checking for link up via LTSSM state

Remi Pommarel (1):
PCI: aardvark: Wait for endpoint to be ready before training link

Sergei Shtylyov (1):
PCI: aardvark: Fix I/O space page leak

Thomas Petazzoni (1):
PCI: aardvark: Introduce an advk_pcie_valid_device() helper

Wen Yang (1):
PCI: aardvark: Fix a leaked reference by adding missing of_node_put()

 .../pinctrl/marvell,armada-37xx-pinctrl.txt   |  26 +-
 .../arm64/boot/dts/marvell/armada-3720-db.dts |   3 +
 .../dts/marvell/armada-3720-espressobin.dts   |   3 +
 arch/arm64/boot/dts/marvell/armada-37xx.dtsi  |   9 +
 drivers/pci/host/pci-aardvark.c               | 463 ++++++++++++++----
 drivers/pinctrl/mvebu/pinctrl-armada-37xx.c   |  28 +-
 include/uapi/linux/pci_regs.h                 |   5 +
 7 files changed, 430 insertions(+), 107 deletions(-)
Signature · 1 line
2.32.0