Skip to content

Armada 3720 PCIe fixes for 4.19

Marek Behún linux-arm-kernel linux-pci lkml stable 1 version Applied

Status from this message: This is a note to let you know that I've just added the patch titled

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest20 patches 6 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/20PCI: aardvark: Fix a leaked reference by adding missing of_node_put()drivers/pci/controller/pci-aardvark.c+8 -51 reply
2/20PCI: aardvark: Wait for endpoint to be ready before training linkdrivers/pci/controller/pci-aardvark.c+8 -00 replies
3/20PCI: aardvark: Train link immediately after enabling trainingdrivers/pci/controller/pci-aardvark.c+9 -60 replies
4/20PCI: aardvark: Improve link trainingdrivers/pci/controller/pci-aardvark.c+89 -250 replies
5/20PCI: aardvark: Issue PERST via GPIOdrivers/pci/controller/pci-aardvark.c+42 -10 replies
6/20PCI: aardvark: Replace custom macros by standard linux/pci_regs.h macrosdrivers/pci/controller/pci-aardvark.c+19 -230 replies
7/20PCI: aardvark: Indicate error in 'val' when config read failsdrivers/pci/controller/pci-aardvark.c+3 -10 replies
8/20PCI: aardvark: Don't touch PCIe registers if no card connecteddrivers/pci/controller/pci-aardvark.c+7 -00 replies
9/20PCI: aardvark: Fix compilation on s390drivers/pci/controller/pci-aardvark.c+1 -10 replies
10/20PCI: aardvark: Move PCIe reset card code to advk_pcie_train_link()drivers/pci/controller/pci-aardvark.c+34 -300 replies
11/20PCI: aardvark: Update comment about disabling link trainingdrivers/pci/controller/pci-aardvark.c+8 -10 replies
12/20PCI: aardvark: Configure PCIe resources from 'ranges' DT propertydrivers/pci/controller/pci-aardvark.c+189 -10 replies
13/20PCI: aardvark: Fix PCIe Max Payload Size settingdrivers/pci/controller/pci-aardvark.c+2 -10 replies
14/20PCI: aardvark: Fix link trainingdrivers/pci/controller/pci-aardvark.c+34 -830 replies
15/20PCI: aardvark: Fix checking for link up via LTSSM statedrivers/pci/controller/pci-aardvark.c+67 -40 replies
16/20pinctrl: armada-37xx: Correct mpp definitionsDocumentation/devicetree/bindings/pinctrl/marvell,armada-37xx-pinctrl.txt drivers/pinctrl/mvebu/pinctrl-armada-37xx.c+19 -90 replies
17/20pinctrl: armada-37xx: add missing pin: PCIe1 Wakeupdrivers/pinctrl/mvebu/pinctrl-armada-37xx.c+1 -00 replies
18/20pinctrl: armada-37xx: Correct PWM pins definitionsDocumentation/devicetree/bindings/pinctrl/marvell,armada-37xx-pinctrl.txt drivers/pinctrl/mvebu/pinctrl-armada-37xx.c+12 -130 replies
19/20arm64: dts: marvell: armada-37xx: declare PCIe reset pinarch/arm64/boot/dts/marvell/armada-37xx.dtsi+9 -00 replies
20/20arm64: dts: marvell: armada-37xx: Set pcie_reset_pin to gpio functionarch/arm64/boot/dts/marvell/armada-3720-db.dts arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts arch/arm64/boot/dts/marvell/armada-37xx.dtsi+7 -10 replies

Reviews trailers per patch

11 of 20 patches have a Reviewed-by or Acked-by.

PatchThomas PetazzoniTomasz Maciej NowakRob HerringMarek BehúnMiquel Raynal
1/20
2/20A-b
3/20A-b T-b A-b
4/20A-b T-b R-b
5/20A-b T-b
6/20A-b T-b R-b
7/20
8/20
9/20R-b
10/20T-b
11/20
12/20
13/20R-b
14/20R-b
15/20R-b
16/20T-b
17/20T-b
18/20A-b
19/20
20/20A-b T-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 5 reviewers.

Read the v1 thread

Cover letter [PATCH 4.19 00/20] Armada 3720 PCIe fixes for 4.19

Hello Greg, Sasha,

this series for 4.19-stable backports all the fixes (and their dependencies) for Armada 3720 PCIe driver.
These include:
- fixes (and their dependencies) for pci-aardvark controller
- fixes (and their dependencies) for pinctrl-armada-37xx driver
- device-tree fixes

Basically all fixes from upstream are taken, excluding those that need fix the emulated bridge, since that was introduced after 4.19. (Should we backport it? It concerns only mvebu and aardvark controllers...)

Marek

Gregory CLEMENT (1):
pinctrl: armada-37xx: add missing pin: PCIe1 Wakeup

Marek Behún (4):
PCI: aardvark: Improve link training
pinctrl: armada-37xx: Correct mpp definitions
pinctrl: armada-37xx: Correct PWM pins definitions
arm64: dts: marvell: armada-37xx: Set pcie_reset_pin to gpio function

Miquel Raynal (1):
arm64: dts: marvell: armada-37xx: declare PCIe reset pin

Pali Rohár (12):
PCI: aardvark: Train link immediately after enabling training
PCI: aardvark: Issue PERST via GPIO
PCI: aardvark: Replace custom macros by standard linux/pci_regs.h
macros
PCI: aardvark: Indicate error in 'val' when config read fails
PCI: aardvark: Don't touch PCIe registers if no card connected
PCI: aardvark: Fix compilation on s390
PCI: aardvark: Move PCIe reset card code to advk_pcie_train_link()
PCI: aardvark: Update comment about disabling link training
PCI: aardvark: Configure PCIe resources from 'ranges' DT property
PCI: aardvark: Fix PCIe Max Payload Size setting
PCI: aardvark: Fix link training
PCI: aardvark: Fix checking for link up via LTSSM state

Remi Pommarel (1):
PCI: aardvark: Wait for endpoint to be ready before training link

Wen Yang (1):
PCI: aardvark: Fix a leaked reference by adding missing of_node_put()

 .../pinctrl/marvell,armada-37xx-pinctrl.txt   |  26 +-
 .../arm64/boot/dts/marvell/armada-3720-db.dts |   3 +
 .../dts/marvell/armada-3720-espressobin.dts   |   3 +
 arch/arm64/boot/dts/marvell/armada-37xx.dtsi  |   9 +
 drivers/pci/controller/pci-aardvark.c         | 436 ++++++++++++++++--
 drivers/pinctrl/mvebu/pinctrl-armada-37xx.c   |  28 +-
 6 files changed, 434 insertions(+), 71 deletions(-)
Signature · 1 line
2.32.0