Skip to content

sysctl: 3rd set of kernel/sysctl cleanups

Luis Chamberlain linux-fsdevel linux-scsi lkml 1 version Applied

Status from this message: [merged] sysctl-share-unsigned-long-const-values.patch removed from -mm tree

Get series with b4
b4 am [email protected]

Versions newest first

  1. v2 Latest8 patches 2 repliesApplied 8/8

Patches in v2 All 8 applied

#Subject and filesSizeRepliesApplied
1/8firmware_loader: move firmware sysctl to its own filesdrivers/base/firmware_loader/fallback.c drivers/base/firmware_loader/fallback.h drivers/base/firmware_loader/fallback_table.c +2 more+36 -110 repliesApplied
2/8random: move the random sysctl declarations to its own filedrivers/char/random.c include/linux/sysctl.h kernel/sysctl.c+12 -80 repliesApplied
3/8sysctl: add helper to register a sysctl mount pointfs/proc/proc_sysctl.c include/linux/sysctl.h+20 -00 repliesApplied
4/8fs: move binfmt_misc sysctl to its own filefs/binfmt_misc.c kernel/sysctl.c+5 -80 repliesApplied
5/8printk: move printk sysctl to printk/sysctl.ckernel/printk/Makefile kernel/printk/internal.h kernel/printk/printk.c +2 more+96 -692 repliesApplied
6/8scsi/sg: move sg-big-buff sysctl to scsi/sg.cdrivers/scsi/sg.c include/scsi/sg.h kernel/sysctl.c+34 -170 repliesApplied
7/8stackleak: move stack_erasing sysctl to stackleak.cinclude/linux/stackleak.h kernel/stackleak.c kernel/sysctl.c+24 -210 repliesApplied
8/8sysctl: share unsigned long const valuesfs/proc/proc_sysctl.c include/linux/sysctl.h kernel/sysctl.c+12 -60 repliesApplied

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 0/8] sysctl: 3rd set of kernel/sysctl cleanups

This is the third set of patches to help address cleaning the kitchen seink in kernel/sysctl.c and to move sysctls away to where they are actually implemented / used.

Note that Andrew Morton is staging these to get visibility into changes in the various trees which might conflict. He already grabbed the first two sets of patch sets, and so I think these changes are probably best to be eventually considered to be merged through his tree, to avoid conflicts.

On this v2 series since last year's v1 series has these changes:

* extended commit log to clarify that in these cases, while we are not producing less lines of code we justify the move because otherwise the file kernel/sysctl.c gets way out of hand to maintain.

* addressed 0-day complaints

* the firmware loader changes requested by Greg KH were adopted

* added the new sysctl mount point helper as suggested by Eric W. Biederman

Luis Chamberlain (3):
sysctl: add helper to register a sysctl mount point
fs: move binfmt_misc sysctl to its own file
sysctl: share unsigned long const values

Xiaoming Ni (5):
firmware_loader: move firmware sysctl to its own files
random: move the random sysctl declarations to its own file
printk: move printk sysctl to printk/sysctl.c scsi/sg: move sg-big-buff sysctl to scsi/sg.c
stackleak: move stack_erasing sysctl to stackleak.c

 drivers/base/firmware_loader/fallback.c       |   7 +-
 drivers/base/firmware_loader/fallback.h       |  11 ++
 drivers/base/firmware_loader/fallback_table.c |  21 ++-
 drivers/char/random.c                         |  14 +-
 drivers/scsi/sg.c                             |  35 ++++-
 fs/binfmt_misc.c                              |   6 +-
 fs/proc/proc_sysctl.c                         |  16 +++
 include/linux/stackleak.h                     |   5 -
 include/linux/sysctl.h                        |  15 ++-
 include/scsi/sg.h                             |   4 -
 kernel/printk/Makefile                        |   5 +-
 kernel/printk/internal.h                      |   6 +
 kernel/printk/printk.c                        |   1 +
 kernel/printk/sysctl.c                        |  85 ++++++++++++
 kernel/stackleak.c                            |  26 +++-
 kernel/sysctl.c                               | 122 +-----------------
 16 files changed, 239 insertions(+), 140 deletions(-)
 create mode 100644 kernel/printk/sysctl.c
Signature · 1 line
2.33.0