Skip to content

Armada 3720 PCIe fixes for 5.4

Marek Behún stable 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest22 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/22PCI: aardvark: Wait for endpoint to be ready before training linkdrivers/pci/controller/pci-aardvark.c+8 -00 replies
2/22PCI: aardvark: Fix big endian supportdrivers/pci/controller/pci-aardvark.c+7 -50 replies
3/22PCI: aardvark: Train link immediately after enabling trainingdrivers/pci/controller/pci-aardvark.c+9 -60 replies
4/22PCI: aardvark: Improve link trainingdrivers/pci/controller/pci-aardvark.c+89 -250 replies
5/22PCI: aardvark: Issue PERST via GPIOdrivers/pci/controller/pci-aardvark.c+42 -10 replies
6/22PCI: aardvark: Replace custom macros by standard linux/pci_regs.h macrosdrivers/pci/controller/pci-aardvark.c+18 -230 replies
7/22PCI: aardvark: Don't touch PCIe registers if no card connecteddrivers/pci/controller/pci-aardvark.c+7 -00 replies
8/22PCI: aardvark: Fix compilation on s390drivers/pci/controller/pci-aardvark.c+1 -10 replies
9/22PCI: aardvark: Move PCIe reset card code to advk_pcie_train_link()drivers/pci/controller/pci-aardvark.c+34 -300 replies
10/22PCI: aardvark: Update comment about disabling link trainingdrivers/pci/controller/pci-aardvark.c+8 -10 replies
11/22PCI: pci-bridge-emul: Fix array overruns, improve safetydrivers/pci/pci-bridge-emul.c+8 -30 replies
12/22PCI: aardvark: Configure PCIe resources from 'ranges' DT propertydrivers/pci/controller/pci-aardvark.c+189 -10 replies
13/22PCI: aardvark: Fix PCIe Max Payload Size settingdrivers/pci/controller/pci-aardvark.c+2 -10 replies
14/22PCI: aardvark: Deduplicate code in advk_pcie_rd_conf()drivers/pci/controller/pci-aardvark.c+20 -280 replies
15/22PCI: aardvark: Implement re-issuing config requests on CRS responsedrivers/pci/controller/pci-aardvark.c+43 -240 replies
16/22PCI: aardvark: Simplify initialization of rootcap on virtual bridgedrivers/pci/controller/pci-aardvark.c+4 -100 replies
17/22PCI: aardvark: Fix link trainingdrivers/pci/controller/pci-aardvark.c+34 -830 replies
18/22PCI: aardvark: Fix support for bus mastering and PCI_COMMAND on emulated bridgedrivers/pci/controller/pci-aardvark.c+38 -90 replies
19/22PCI: aardvark: Set PCI Bridge Class Code to PCI Bridgedrivers/pci/controller/pci-aardvark.c+20 -00 replies
20/22PCI: aardvark: Fix support for PCI_BRIDGE_CTL_BUS_RESET on emulated bridgedrivers/pci/controller/pci-aardvark.c+27 -00 replies
21/22pinctrl: armada-37xx: Correct PWM pins definitionsDocumentation/devicetree/bindings/pinctrl/marvell,armada-37xx-pinctrl.txt drivers/pinctrl/mvebu/pinctrl-armada-37xx.c+12 -130 replies
22/22arm64: dts: marvell: armada-37xx: Set pcie_reset_pin to gpio functionarch/arm64/boot/dts/marvell/armada-3720-db.dts arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts +1 more+5 -50 replies

Reviews trailers per patch

13 of 22 patches have a Reviewed-by or Acked-by.

PatchThomas PetazzoniTomasz Maciej NowakRob HerringMarek BehúnPali Rohár
1/22A-b
2/22
3/22A-b T-b A-b
4/22A-b T-b R-b
5/22A-b T-b
6/22A-b T-b R-b
7/22
8/22R-b
9/22T-b
10/22
11/22R-b
12/22
13/22R-b
14/22
15/22R-b
16/22R-b
17/22R-b
18/22
19/22
20/22
21/22A-b
22/22A-b T-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 5 reviewers.

Read the v1 thread

Cover letter [PATCH 5.4 00/22] Armada 3720 PCIe fixes for 5.4

Hello Greg, Sasha,

this series for 5.4-stable backports all the fixes (and their dependencies) for Armada 3720 PCIe driver.
These include:
- fixes (and their dependencies) for pci-aardvark controller
- fixes for pci-bridge-emul
- fixes (and their dependencies) for pinctrl-armada-37xx driver
- device-tree fixes

Marek

Grzegorz Jaszczyk (1):
PCI: aardvark: Fix big endian support

Marek Behún (4):
PCI: aardvark: Improve link training
PCI: aardvark: Deduplicate code in advk_pcie_rd_conf()
pinctrl: armada-37xx: Correct PWM pins definitions
arm64: dts: marvell: armada-37xx: Set pcie_reset_pin to gpio function

Pali Rohár (15):
PCI: aardvark: Train link immediately after enabling training
PCI: aardvark: Issue PERST via GPIO
PCI: aardvark: Replace custom macros by standard linux/pci_regs.h
macros
PCI: aardvark: Don't touch PCIe registers if no card connected
PCI: aardvark: Fix compilation on s390
PCI: aardvark: Move PCIe reset card code to advk_pcie_train_link()
PCI: aardvark: Update comment about disabling link training
PCI: aardvark: Configure PCIe resources from 'ranges' DT property
PCI: aardvark: Fix PCIe Max Payload Size setting
PCI: aardvark: Implement re-issuing config requests on CRS response
PCI: aardvark: Simplify initialization of rootcap on virtual bridge
PCI: aardvark: Fix link training
PCI: aardvark: Fix support for bus mastering and PCI_COMMAND on
emulated bridge
PCI: aardvark: Set PCI Bridge Class Code to PCI Bridge
PCI: aardvark: Fix support for PCI_BRIDGE_CTL_BUS_RESET on emulated
bridge

Remi Pommarel (1):
PCI: aardvark: Wait for endpoint to be ready before training link

Russell King (1):
PCI: pci-bridge-emul: Fix array overruns, improve safety

 .../pinctrl/marvell,armada-37xx-pinctrl.txt   |   8 +-
 .../arm64/boot/dts/marvell/armada-3720-db.dts |   3 +
 .../dts/marvell/armada-3720-espressobin.dts   |   1 +
 .../dts/marvell/armada-3720-turris-mox.dts    |   4 -
 arch/arm64/boot/dts/marvell/armada-37xx.dtsi  |   2 +-
 drivers/pci/controller/pci-aardvark.c         | 576 ++++++++++++++----
 drivers/pci/pci-bridge-emul.c                 |  11 +-
 drivers/pinctrl/mvebu/pinctrl-armada-37xx.c   |  17 +-
 8 files changed, 489 insertions(+), 133 deletions(-)
Signature · 1 line
2.32.0

Read the cover letter in its thread