Skip to content

scsi: qedi: Couple of warning fixes

Florian Fainelli linux-scsi lkml 2 versions – Applied

Status from this message: Applied to 5.17/scsi-staging, thanks!

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest2 patches 6 repliesApplied
  2. v12 patches 5 repliesSuperseded

Changes in v2 from the cover letter

- added Acked-by to patch #1
- changed SYSFS_FLAG_FW_SEL_BOOT to contain the typecasting and not change the way it is formatted before sysfs printing

Patches in v2 Applied

#Subject and filesSizeRepliesApplied
1/2scsi: qedi: Remove set but unused 'page' variabledrivers/scsi/qedi/qedi_main.c+0 -31 reply
2/2scsi: qedi: Fix SYSFS_FLAG_FW_SEL_BOOT formattingdrivers/scsi/qedi/qedi.h+1 -14 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchManish Rangankar
1/2A-b
2/2A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/2] scsi: qedi: Couple of warning fixes

These warnings started to show up after enabling PCI on BMIPS (32-bit MIPS architecture) and were reported by the kbuild robot.

I don't know whether they are technically correct, in particular the unused 'page' variable might be unveiling a genuine bug whereby it should have been used. Please review.

Changes in v2:

- added Acked-by to patch #1
- changed SYSFS_FLAG_FW_SEL_BOOT to contain the typecasting and not change the way it is formatted before sysfs printing

Florian Fainelli (2):
scsi: qedi: Remove set but unused 'page' variable
scsi: qedi: Fix SYSFS_FLAG_FW_SEL_BOOT formatting

 drivers/scsi/qedi/qedi.h      | 2 +-
 drivers/scsi/qedi/qedi_main.c | 3 ---
 2 files changed, 1 insertion(+), 4 deletions(-)
Signature · 1 line
2.25.1