Skip to content

genirq/msi, PCI/MSI: Spring cleaning - Part 2

Thomas Gleixner dmaengine linux-arm-kernel linux-iommu linux-pci linux-wireless linuxppc-dev lkml xen-devel 5 versions – Applied

Status from this message: The following commit has been merged into the irq/msi branch of tip:

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest35 patches 44 repliesApplied
  2. v2 posting 3/331 patches 11 repliesApplied
  3. v2 posting 2/336 patches 25 repliesSuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v2 posting 1/323 patches35 repliesApplied
v132 patches116 repliesApplied

Changes in v3 from the cover letter

- Use PCI device properties instead of creating a new set - Jason

- Picked up Reviewed/Tested/Acked-by tags as appropriate

Patches in v3 Applied

#Subject and filesSizeRepliesApplied
1/35PCI/MSI: Set pci_dev::msi[x]_enabled earlydrivers/pci/msi/msi.c+17 -61 reply
2/35x86/pci/XEN: Use PCI device propertyarch/x86/pci/xen.c+2 -71 reply
3/35x86/apic/msi: Use PCI device MSI propertyarch/x86/kernel/apic/msi.c+1 -42 replies
4/35genirq/msi: Use PCI device propertykernel/irq/msi.c+2 -151 reply
5/35powerpc/cell/axon_msi: Use PCI device propertyarch/powerpc/platforms/cell/axon_msi.c+1 -42 replies
6/35powerpc/pseries/msi: Use PCI device propertiesarch/powerpc/platforms/pseries/msi.c+1 -21 reply
7/35device: Move MSI related data into a structdrivers/base/platform-msi.c drivers/dma/ti/k3-udma.c drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c +4 more+29 -211 reply
8/35device: Add device:: Msi_data pointer and struct msi_device_datainclude/linux/device.h include/linux/msi.h kernel/irq/msi.c+55 -00 replies
9/35PCI/MSI: Allocate MSI device data on first usedrivers/pci/msi/msi.c+15 -54 replies
10/35platform-msi: Allocate MSI device data on first usedrivers/base/platform-msi.c+7 -10 replies
11/35bus: fsl-mc-msi: Allocate MSI device data on first usedrivers/bus/fsl-mc/fsl-mc-msi.c+8 -60 replies
12/35soc: ti: ti_sci_inta_msi: Allocate MSI device data on first usedrivers/soc/ti/ti_sci_inta_msi.c+4 -02 replies
13/35genirq/msi: Provide msi_device_populate/destroy_sysfs()include/linux/msi.h kernel/irq/msi.c+44 -20 replies
14/35PCI/MSI: Let the irq code handle sysfs groupsdrivers/pci/msi/irqdomain.c drivers/pci/msi/legacy.c drivers/pci/msi/msi.c +1 more+6 -260 replies
15/35platform-msi: Let the core code handle sysfs groupsdrivers/base/platform-msi.c+1 -100 replies
16/35genirq/msi: Remove the original sysfs interfacesinclude/linux/msi.h kernel/irq/msi.c+28 -540 replies
17/35platform-msi: Rename functions and clarify commentsdrivers/base/platform-msi.c drivers/irqchip/irq-mbigen.c drivers/irqchip/irq-mvebu-icu.c +1 more+30 -240 replies
18/35platform-msi: Store platform private data pointer in msi_device_datadrivers/base/platform-msi.c include/linux/msi.h+34 -490 replies
19/35genirq/msi: Consolidate MSI descriptor datainclude/linux/msi.h+2 -00 replies
20/35platform-msi: Use msi_desc::msi_indexdrivers/base/platform-msi.c drivers/dma/qcom/hidma.c drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c +2 more+11 -210 replies
21/35bus: fsl-mc-msi: Use msi_desc::msi_indexdrivers/bus/fsl-mc/fsl-mc-allocator.c drivers/bus/fsl-mc/fsl-mc-msi.c include/linux/msi.h+4 -140 replies
22/35soc: ti: ti_sci_inta_msi: Use msi_desc::msi_indexdrivers/irqchip/irq-ti-sci-inta.c drivers/soc/ti/ti_sci_inta_msi.c include/linux/msi.h+6 -181 reply
23/35PCI/MSI: Use msi_desc::msi_indexarch/powerpc/platforms/pseries/msi.c arch/x86/pci/xen.c drivers/pci/msi/irqdomain.c +3 more+13 -190 replies
24/35PCI/MSI: Provide MSI_FLAG_MSIX_CONTIGUOUSdrivers/pci/msi/irqdomain.c include/linux/msi.h+16 -20 replies
25/35powerpc/pseries/msi: Let core code check for contiguous entriesarch/powerpc/platforms/pseries/msi.c+8 -251 reply
26/35genirq/msi: Provide interface to retrieve Linux interrupt numberinclude/linux/msi.h kernel/irq/msi.c+38 -01 reply
27/35PCI/MSI: Use __msi_get_virq() in pci_get_vector()drivers/pci/msi/msi.c+5 -201 reply
28/35PCI/MSI: Simplify pci_irq_get_affinity()drivers/pci/msi/msi.c+10 -1610 replies
29/35dmaengine: mv_xor_v2: Get rid of msi_desc abusedrivers/dma/mv_xor_v2.c+5 -111 reply
30/35perf/smmuv3: Use msi_get_virq()drivers/perf/arm_smmuv3_pmu.c+1 -40 replies
31/35iommu/arm-smmu-v3: Use msi_get_virq()drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c+3 -160 replies
32/35mailbox: bcm-flexrm-mailbox: Rework MSI interrupt handlingdrivers/mailbox/bcm-flexrm-mailbox.c+2 -50 replies
33/35bus: fsl-mc: fsl-mc-allocator: Rework MSI handlingdrivers/bus/fsl-mc/dprc-driver.c drivers/bus/fsl-mc/fsl-mc-allocator.c drivers/bus/fsl-mc/fsl-mc-msi.c +6 more+22 -300 replies
34/35soc: ti: ti_sci_inta_msi: Get rid of ti_sci_inta_msi_get_virq()drivers/dma/ti/k3-udma-private.c drivers/dma/ti/k3-udma.c drivers/soc/ti/k3-ringacc.c +2 more+7 -243 replies
35/35dmaengine: qcom_hidma: Cleanup MSI handlingdrivers/dma/qcom/hidma.c+18 -241 reply

Reviews trailers per patch

All 35 patches have a Reviewed-by or Acked-by.

PatchGreg Kroah-HartmanJason GunthorpeBjorn HelgaasRobin MurphySinan KayaArnd BergmannVinod KoulNishanth MenonMichael KelleyNathan ChancellorCédric Le Goater
SeriesT-b T-b T-b
1/35R-b
2/35R-b
3/35R-b R-b
4/35R-b
5/35R-b A-b
6/35R-b
7/35R-b R-b A-b
8/35R-b R-b
9/35R-b R-b R-b R-b A-b
10/35R-b R-b
11/35R-b R-b
12/35R-b R-b A-b A-b
13/35R-b R-b
14/35R-b R-b A-b
15/35R-b R-b
16/35R-b R-b
17/35R-b R-b
18/35R-b R-b
19/35R-b R-b
20/35R-b R-b
21/35R-b R-b
22/35R-b R-b A-b
23/35R-b R-b A-b
24/35R-b R-b A-b
25/35R-b R-b
26/35R-b R-b
27/35R-b R-b
28/35R-b R-b T-b T-b
29/35R-b R-b A-b
30/35R-b R-b
31/35R-b R-b T-b
32/35R-b R-b
33/35R-b R-b
34/35R-b R-b A-b A-b A-b
35/35R-b R-b A-b A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 11 reviewers.

Read the v3 thread

Cover letter [patch V3 00/35] genirq/msi, PCI/MSI: Spring cleaning - Part 2

This is the second part of [PCI]MSI refactoring which aims to provide the ability of expanding MSI-X vectors after enabling MSI-X.

This is based on the first part of this work which can be found here:

    https://lore.kernel.org/r/[email protected]

and has been applied to:

git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git irq/msi

This second part has the following important changes:

1) Cleanup of the MSI related data in struct device

struct device contains at the moment various MSI related parts. Some of them (the irq domain pointer) cannot be moved out, but the rest can be allocated on first use. This is in preparation of adding more per device MSI data later on.

2) Consolidation of sysfs handling

As a first step this moves the sysfs pointer from struct msi_desc into the new per device MSI data structure where it belongs.

Later changes will cleanup this code further, but that's not possible at this point.

3) Use PCI device properties instead of looking up MSI descriptors and analysing their data.

4) Provide a function to retrieve the Linux interrupt number for a given MSI index similar to pci_irq_vector() and cleanup all open coded variants.

It's also available from git:

git://git.kernel.org/pub/scm/linux/kernel/git/tglx/devel.git msi-v3-part-2

Part 3 of this effort is available on top

git://git.kernel.org/pub/scm/linux/kernel/git/tglx/devel.git msi-v3-part-3

Part 3 is not going to be reposted as there is no change vs. V2.

V2 of part 2 can be found here:

    https://lore.kernel.org/r/[email protected]

Changes versus V2:

- Use PCI device properties instead of creating a new set - Jason

- Picked up Reviewed/Tested/Acked-by tags as appropriate

Thanks,

tglx

---
 arch/powerpc/platforms/cell/axon_msi.c              |    5 
 arch/powerpc/platforms/pseries/msi.c                |   38 +---
 arch/x86/kernel/apic/msi.c                          |    5 
 arch/x86/pci/xen.c                                  |   11 -
 drivers/base/platform-msi.c                         |  152 ++++++++-----------
 drivers/bus/fsl-mc/dprc-driver.c                    |    8 -
 drivers/bus/fsl-mc/fsl-mc-allocator.c               |    9 -
 drivers/bus/fsl-mc/fsl-mc-msi.c                     |   26 +--
 drivers/dma/mv_xor_v2.c                             |   16 --
 drivers/dma/qcom/hidma.c                            |   44 ++---
 drivers/dma/ti/k3-udma-private.c                    |    6 
 drivers/dma/ti/k3-udma.c                            |   14 -
 drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c         |   23 --
 drivers/irqchip/irq-mbigen.c                        |    4 
 drivers/irqchip/irq-mvebu-icu.c                     |   12 -
 drivers/irqchip/irq-ti-sci-inta.c                   |    2 
 drivers/mailbox/bcm-flexrm-mailbox.c                |    9 -
 drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c    |    4 
 drivers/net/ethernet/freescale/dpaa2/dpaa2-ptp.c    |    4 
 drivers/net/ethernet/freescale/dpaa2/dpaa2-switch.c |    5 
 drivers/pci/msi/irqdomain.c                         |   20 ++
 drivers/pci/msi/legacy.c                            |    6 
 drivers/pci/msi/msi.c                               |  133 ++++++----------
 drivers/pci/xen-pcifront.c                          |    2 
 drivers/perf/arm_smmuv3_pmu.c                       |    5 
 drivers/soc/fsl/dpio/dpio-driver.c                  |    8 -
 drivers/soc/ti/k3-ringacc.c                         |    6 
 drivers/soc/ti/ti_sci_inta_msi.c                    |   22 --
 drivers/vfio/fsl-mc/vfio_fsl_mc_intr.c              |    4 
 include/linux/device.h                              |   25 ++-
 include/linux/fsl/mc.h                              |    4 
 include/linux/msi.h                                 |   95 ++++--------
 include/linux/pci.h                                 |    1 
 include/linux/soc/ti/ti_sci_inta_msi.h              |    1 
 kernel/irq/msi.c                                    |  158 +++++++++++++++-----
 35 files changed, 429 insertions(+), 458 deletions(-)

_______________________________________________
iommu mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/iommu