Skip to content

pinctrl: bcm2835: Fix gpio hogs and pin reinitialisation

Phil Elwell linux-devicetree linux-gpio 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest2 patches 24 repliesIn review
  2. v12 patches 6 repliesSuperseded

Changes in v2 from the cover letter

* Removed wrapping of Fixes: tags.
* Added Reviewed-by from Linus, who asks that Patch 2 be merged through the Broadcom/SoC tree.
* Corrected Nicolas's email address.

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2pinctrl: bcm2835: Change init order for gpio hogsdrivers/pinctrl/bcm/pinctrl-bcm2835.c+16 -1310 replies
2/2ARM: dts: gpio-ranges property is now requiredarch/arm/boot/dts/bcm2711.dtsi arch/arm/boot/dts/bcm283x.dtsi+4 -014 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchLinus WalleijFlorian Fainelli
1/2R-b
2/2R-b A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/2] pinctrl: bcm2835: Fix gpio hogs and pin reinitialisation

Tackle two problems with the pinctrl-bcm2835 driver and its Device Tree configuration:

1. The pinctrl-bcm2835 driver is a combined pinctrl/gpio driver. Currently the gpio side is registered first, but this breaks gpio hogs (which are configured during gpiochip_add_data).

2. Since [1], a "gpio-ranges" property is required in order for pins to be returned to inputs when freed. Note that without patch 1, the device never gets out of EPROBE_DEFER.

Note that the Fixes: tags are little more than hooks to hang the back-ports on - no blame is intended.

[1] commit 2ab73c6d8323 ("gpio: Support GPIO controllers without pin-ranges")

Changes in v2:
* Removed wrapping of Fixes: tags.
* Added Reviewed-by from Linus, who asks that Patch 2 be merged through the Broadcom/SoC tree.
* Corrected Nicolas's email address.

Phil Elwell (2):
pinctrl: bcm2835: Change init order for gpio hogs
ARM: dts: gpio-ranges property is now required

 arch/arm/boot/dts/bcm2711.dtsi        |  2 ++
 arch/arm/boot/dts/bcm283x.dtsi        |  2 ++
 drivers/pinctrl/bcm/pinctrl-bcm2835.c | 29 +++++++++++++++------------
 3 files changed, 20 insertions(+), 13 deletions(-)
Signature · 1 line
2.25.1