Skip to content

crypto: jitterentropy - bound collection loop

Nicolai Stange linux-crypto lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 4 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3crypto: drbg - ignore jitterentropy errors if not in FIPS modecrypto/drbg.c+5 -21 reply
2/3crypto: jitter - don't limit ->health_failure check to FIPS modecrypto/jitterentropy-kcapi.c crypto/jitterentropy.c crypto/jitterentropy.h+0 -111 reply
3/3crypto: jitter - quit sample collection loop upon RCT failurecrypto/jitterentropy.c+1 -11 reply

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchStephan Mueller
1/3R-b
2/3R-b
3/3R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/3] crypto: jitterentropy - bound collection loop

Hi,

the sampling loop in jent_gen_entropy() can potentially run indefinitely w/o making any forward progress, namely if only stuck samples are taken for whatever reason.

There's a straight-forward way to make the entropy collection more robust, namely to terminate the loop and report an error if this happens. This patchset here implements that.

Applies to herbert/cryptodev-2.6.git master.

Thanks!

Nicolai

Nicolai Stange (3):
crypto: drbg - ignore jitterentropy errors if not in FIPS mode
crypto: jitter - don't limit ->health_failure check to FIPS mode
crypto: jitter - quit sample collection loop upon RCT failure

 crypto/drbg.c                | 7 +++++--
 crypto/jitterentropy-kcapi.c | 6 ------
 crypto/jitterentropy.c       | 6 +-----
 crypto/jitterentropy.h       | 1 -
 4 files changed, 6 insertions(+), 14 deletions(-)
Signature · 1 line
2.26.2