Skip to content

ACPI: Arm Generic Diagnostic Dump and Reset device

Ilkka Koskinen linux-acpi linux-arm-kernel lkml 8 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v6 Latest2 patches 5 repliesIn review
  2. v5 posting 3/32 patches 3 repliesSuperseded
  3. v5 posting 2/32 patches 0 repliesSuperseded
Earlier versions · 5
VersionPostedPatchesRepliesStatus
v5 posting 1/32 patches2 repliesSuperseded
v42 patches0 repliesSuperseded
v32 patches10 repliesSuperseded
v22 patches2 repliesSuperseded
v12 patches2 repliesSuperseded

Changes in v6 from the cover letter

* Brought back platform device/driver
* Fixed remove() function

Patches in v6 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2ACPI: tables: Add AGDI to the list of known table signaturesdrivers/acpi/tables.c+1 -13 replies
2/2ACPI: AGDI: Add driver for Arm Generic Diagnostic Dump and Reset devicedrivers/acpi/arm64/Kconfig drivers/acpi/arm64/Makefile drivers/acpi/arm64/agdi.c +2 more+142 -02 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchRussell King (Oracle)Lorenzo Pieralisi
1/2R-b
2/2R-b A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v6 thread

Cover letter [PATCH v6 0/2] ACPI: Arm Generic Diagnostic Dump and Reset device

Arm Generic Diagnostic Dump and Reset device enables a maintainer to request OS to perform a diagnostic dump and reset a system via SDEI event or an interrupt. This patchset adds support for the SDEI path.

I do have a patch to enable the interrupt path as well but I'm holding it back since AGDI table is missing interrupt configuration fields (trigger type etc.).

The recently published specification is available at
https://developer.arm.com/documentation/den0093/latest

The patchset was tested on Ampere Altra/Mt. Jade.

The patchset applies on top of
git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm bleeding-edge (dd54258fbf6c)

Requires commit 27e932a31496 ("ACPI: APEI: rename ghes_init() with an "acpi_" prefix")

From v1:
* Moved pdata to the stack and dropped unnecessary kzalloc() in agdi_init()
* Changed the ACPICA patch upstreaming order comment in the paragraph above

From v2:
* The first patch was split. The most of it was merged to ACPICA project at first and later ported to linux-acpi (fd919e37cb15914c6fe13e13d530a4f732407c6d). The rest are in the first patch.

From v3:
Fixed:
* Moved header files in alphabetical order and removed unnecessary ones

From v4:
* Platform device/driver stuff removed
* acpi_agdi_init() call moved from device_initcall to acpi_init()
* Slightly modified Kconfig text to keep checkpatch happy

From v5:
* Brought back platform device/driver
* Fixed remove() function

Ilkka Koskinen (2):
ACPI: tables: Add AGDI to the list of known table signatures
ACPI: AGDI: Add driver for Arm Generic Diagnostic Dump and Reset
device

 drivers/acpi/arm64/Kconfig  |  10 ++++
 drivers/acpi/arm64/Makefile |   1 +
 drivers/acpi/arm64/agdi.c   | 116 ++++++++++++++++++++++++++++++++++++
 drivers/acpi/bus.c          |   2 +
 drivers/acpi/tables.c       |   2 +-
 include/linux/acpi_agdi.h   |  13 ++++
 6 files changed, 143 insertions(+), 1 deletion(-)
 create mode 100644 drivers/acpi/arm64/agdi.c
 create mode 100644 include/linux/acpi_agdi.h
Signature · 1 line
2.17.1