Skip to content

riscv: mm: init clean up #ifdefs

Jisheng Zhang linux-riscv lkml 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest5 patches 3 repliesIn review
  2. v15 patches 8 repliesSuperseded

Changes in v2 from the cover letter

- collect Reviewed-by tag.
- remove the __maybe_unused used in max_mapped_addr declaration.
- remove the BUG_ON check of mapping the last 4K bytes of the addressable memory since "this is true for every kernel actually" as pointed out by Alexandre.

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5riscv: mm: init: remove unnecessary "#ifdef CONFIG_CRASH_DUMP"arch/riscv/mm/init.c+0 -20 replies
2/5riscv: mm: init: try best to use IS_ENABLED(CONFIG_64BIT) instead of #ifdefarch/riscv/mm/init.c+16 -271 reply
3/5riscv: mm: init: remove _pt_ops and use pt_ops directlyarch/riscv/mm/init.c+2 -41 reply
4/5riscv: mm: init: try IS_ENABLED(CONFIG_XIP_KERNEL) instead of #ifdefarch/riscv/mm/init.c+7 -90 replies
5/5riscv: mm: init: try best to remove #ifdef CONFIG_XIP_KERNEL usagearch/riscv/mm/init.c+3 -80 replies

Reviews trailers per patch

All 5 patches have a Reviewed-by or Acked-by.

PatchAlexandre Ghiti
1/5R-b
2/5R-b
3/5R-b
4/5R-b
5/5R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/5] riscv: mm: init clean up #ifdefs

To support NOMMU, XIP, the arch/riscv/mm/init.c becomes much complex due to lots of #ifdefs, this not only impacts the code readability, compile coverage, but may also bring bugs. For example, I believe one recently fixed bug[1] is caused by this issue when merging.

This series tries to clean up unnecessary #ifdefs as much as possible.

Further cleanups may need to refactor the XIP code as Alexandre's patch does.

[1] http://lists.infradead.org/pipermail/linux-riscv/2021-December/010607.html

Since v1:
- collect Reviewed-by tag.
- remove the __maybe_unused used in max_mapped_addr declaration.
- remove the BUG_ON check of mapping the last 4K bytes of the addressable memory since "this is true for every kernel actually" as pointed out by Alexandre.

Jisheng Zhang (5):
riscv: mm: init: remove unnecessary "#ifdef CONFIG_CRASH_DUMP"
riscv: mm: init: try best to use IS_ENABLED(CONFIG_64BIT) instead of

    #ifdef

riscv: mm: init: remove _pt_ops and use pt_ops directly
riscv: mm: init: try IS_ENABLED(CONFIG_XIP_KERNEL) instead of #ifdef
riscv: mm: init: try best to remove #ifdef CONFIG_XIP_KERNEL usage

 arch/riscv/mm/init.c | 76 ++++++++++++++++----------------------------
 1 file changed, 27 insertions(+), 49 deletions(-)
Signature · 7 lines
2.34.1


_______________________________________________
linux-riscv mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-riscv