Big buffer/frame refactoring patch set v3
Status from this message: NAK, as this breaks about everything :-o - I tried applying this on top
Get series with b4
b4 am [email protected]...Versions newest first · linked by author and title
- v3 Latest14 patches 13 repliesNAK
- v121 patches 25 repliesSuperseded
Patches in v3
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/14 | Deprecate link-mtudoc/ src/ | +7 | 1 reply | |
| 2/14 | Fix mssfix and frame calculation in CBC modesrc/ src/ src/ +4 more | +203 | 3 replies | |
| 3/14 | Change buffer allocation calculation and checks to be more staticsrc/ src/ src/ +11 more | +187 | 1 reply | |
| 4/14 | Fix datagram_overhead and assorted functionssrc/ src/ src/ | +15 | 1 reply | |
| 5/14 | Implement optional mtu parameter for mssfixChanges.rst doc/ src/ +8 more | +98 | 1 reply | |
| 6/14 | Update fragment and mssfix related warningssrc/ | +10 | 1 reply | |
| 7/14 | Change the default for mssfix to mssfix 1492 mtusrc/ src/ src/ | +43 | 0 replies | |
| 8/14 | Remove link_mtu parameter when running up/down scriptsChanges.rst src/ | +5 | 1 reply | |
| 9/14 | Add mtu paramter to --fragment and change fragment calculationChanges.rst doc/ src/ +12 more | +178 | 3 replies | |
| 10/14 | Use new frame header methods to calculate OCC_MTU_LOAD payload sizesrc/ | +23 | 0 replies | |
| 11/14 | Remove extra_link from framesrc/ src/ src/ +3 more | +1 | 0 replies | |
| 12/14 | Replace TUN_MTU_SIZE with frame->tun_mtusrc/ src/ src/ | +9 | 1 reply | |
| 13/14 | Remove frame->link_mtusrc/ src/ src/ +4 more | +5 | 0 replies | |
| 14/14 | Remove frame.extra_frame and frame.extra_buffersrc/ src/ src/ +12 more | +2 | 0 replies |
Reviews trailers per patch
5 of 14 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Gert Doering |
|---|---|
| Series | A-b A-b |
| 1/14 | A-b |
| 2/14 | A-b |
| 3/14 | |
| 4/14 | A-b |
| 5/14 | A-b |
| 6/14 | |
| 7/14 | |
| 8/14 | A-b |
| 9/14 | |
| 10/14 | |
| 11/14 | |
| 12/14 | |
| 13/14 | |
| 14/14 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [Openvpn-devel] [PATCH v3 00/14] Big buffer/frame refactoring patch set v3
This version of the patchset adds the CBC fix to correct the CBC calculation. This patch introduces a lot of rebase conflicts and therefore the whole patchset is resent as v3.
Arne Schwabe (14):
Deprecate link-mtu
Fix mssfix and frame calculation in CBC mode
Change buffer allocation calculation and checks to be more static Fix datagram_overhead and assorted functions
Implement optional mtu parameter for mssfix
Update fragment and mssfix related warnings
Change the default for mssfix to mssfix 1492 mtu
Remove link_mtu parameter when running up/down scripts Add mtu paramter to --fragment and change fragment calculation Use new frame header methods to calculate OCC_MTU_LOAD payload size Remove extra_link from frame
Replace TUN_MTU_SIZE with frame->tun_mtu
Remove frame->link_mtu
Remove frame.extra_frame and frame.extra_buffer
Changes.rst | 9 + doc/man-sections/link-options.rst | 65 ++++-- src/openvpn/comp-lz4.c | 4 +- src/openvpn/comp.c | 15 -- src/openvpn/comp.h | 4 - src/openvpn/crypto.c | 59 +----- src/openvpn/crypto.h | 14 +- src/openvpn/forward.c | 25 +-- src/openvpn/fragment.c | 7 +- src/openvpn/init.c | 274 ++++++++++++------------- src/openvpn/integer.h | 9 + src/openvpn/lzo.c | 2 +- src/openvpn/mss.c | 159 ++++++++++++-- src/openvpn/mss.h | 12 +- src/openvpn/mtu.c | 143 +++++-------- src/openvpn/mtu.h | 204 +++++++----------- src/openvpn/multi.c | 7 +- src/openvpn/multi.h | 2 +- src/openvpn/occ.c | 33 ++- src/openvpn/options.c | 85 +++++--- src/openvpn/options.h | 6 +- src/openvpn/ping.c | 2 +- src/openvpn/reliable.c | 7 - src/openvpn/reliable.h | 3 - src/openvpn/socket.c | 31 --- src/openvpn/socket.h | 19 +- src/openvpn/socks.c | 11 +- src/openvpn/socks.h | 2 - src/openvpn/ssl.c | 89 +++----- src/openvpn/ssl.h | 10 +- src/openvpn/ssl_common.h | 3 +- src/openvpn/tls_crypt.c | 10 - src/openvpn/tls_crypt.h | 5 - tests/unit_tests/openvpn/test_crypto.c | 86 +++++++- 34 files changed, 733 insertions(+), 683 deletions(-)
Signature · 1 line
2.33.0