Skip to content

Big buffer/frame refactoring patch set v3

Arne Schwabe openvpn-devel 2 versions – NAK

Status from this message: NAK, as this breaks about everything :-o - I tried applying this on top

Get series with b4
b4 am [email protected]...

Versions newest first · linked by author and title

  1. v3 Latest14 patches 13 repliesNAK
  2. v121 patches 25 repliesSuperseded

Patches in v3

#Subject and filesSizeRepliesApplied
1/14Deprecate link-mtudoc/man-sections/link-options.rst src/openvpn/options.c+7 -41 reply
2/14Fix mssfix and frame calculation in CBC modesrc/openvpn/crypto.c src/openvpn/crypto.h src/openvpn/integer.h +4 more+203 -623 replies
3/14Change buffer allocation calculation and checks to be more staticsrc/openvpn/comp-lz4.c src/openvpn/crypto.c src/openvpn/forward.c +11 more+187 -711 reply
4/14Fix datagram_overhead and assorted functionssrc/openvpn/forward.c src/openvpn/socket.c src/openvpn/socket.h+15 -281 reply
5/14Implement optional mtu parameter for mssfixChanges.rst doc/man-sections/link-options.rst src/openvpn/init.c +8 more+98 -271 reply
6/14Update fragment and mssfix related warningssrc/openvpn/init.c+10 -51 reply
7/14Change the default for mssfix to mssfix 1492 mtusrc/openvpn/mtu.h src/openvpn/options.c src/openvpn/options.h+43 -210 replies
8/14Remove link_mtu parameter when running up/down scriptsChanges.rst src/openvpn/init.c+5 -131 reply
9/14Add mtu paramter to --fragment and change fragment calculationChanges.rst doc/man-sections/link-options.rst src/openvpn/forward.c +12 more+178 -1103 replies
10/14Use new frame header methods to calculate OCC_MTU_LOAD payload sizesrc/openvpn/occ.c+23 -80 replies
11/14Remove extra_link from framesrc/openvpn/init.c src/openvpn/mtu.c src/openvpn/mtu.h +3 more+1 -460 replies
12/14Replace TUN_MTU_SIZE with frame->tun_mtusrc/openvpn/forward.c src/openvpn/init.c src/openvpn/mtu.h+9 -141 reply
13/14Remove frame->link_mtusrc/openvpn/comp.c src/openvpn/comp.h src/openvpn/forward.c +4 more+5 -1050 replies
14/14Remove frame.extra_frame and frame.extra_buffersrc/openvpn/comp.c src/openvpn/comp.h src/openvpn/crypto.c +12 more+2 -2220 replies

Reviews trailers per patch

5 of 14 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchGert Doering
SeriesA-b A-b
1/14A-b
2/14A-b
3/14
4/14A-b
5/14A-b
6/14
7/14
8/14A-b
9/14
10/14
11/14
12/14
13/14
14/14

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [Openvpn-devel] [PATCH v3 00/14] Big buffer/frame refactoring patch set v3

This version of the patchset adds the CBC fix to correct the CBC calculation. This patch introduces a lot of rebase conflicts and therefore the whole patchset is resent as v3.

Arne Schwabe (14):
Deprecate link-mtu
Fix mssfix and frame calculation in CBC mode
Change buffer allocation calculation and checks to be more static Fix datagram_overhead and assorted functions
Implement optional mtu parameter for mssfix
Update fragment and mssfix related warnings
Change the default for mssfix to mssfix 1492 mtu
Remove link_mtu parameter when running up/down scripts Add mtu paramter to --fragment and change fragment calculation Use new frame header methods to calculate OCC_MTU_LOAD payload size Remove extra_link from frame
Replace TUN_MTU_SIZE with frame->tun_mtu
Remove frame->link_mtu
Remove frame.extra_frame and frame.extra_buffer

 Changes.rst                            |   9 +
 doc/man-sections/link-options.rst      |  65 ++++--
 src/openvpn/comp-lz4.c                 |   4 +-
 src/openvpn/comp.c                     |  15 --
 src/openvpn/comp.h                     |   4 -
 src/openvpn/crypto.c                   |  59 +-----
 src/openvpn/crypto.h                   |  14 +-
 src/openvpn/forward.c                  |  25 +--
 src/openvpn/fragment.c                 |   7 +-
 src/openvpn/init.c                     | 274 ++++++++++++-------------
 src/openvpn/integer.h                  |   9 +
 src/openvpn/lzo.c                      |   2 +-
 src/openvpn/mss.c                      | 159 ++++++++++++--
 src/openvpn/mss.h                      |  12 +-
 src/openvpn/mtu.c                      | 143 +++++--------
 src/openvpn/mtu.h                      | 204 +++++++-----------
 src/openvpn/multi.c                    |   7 +-
 src/openvpn/multi.h                    |   2 +-
 src/openvpn/occ.c                      |  33 ++-
 src/openvpn/options.c                  |  85 +++++---
 src/openvpn/options.h                  |   6 +-
 src/openvpn/ping.c                     |   2 +-
 src/openvpn/reliable.c                 |   7 -
 src/openvpn/reliable.h                 |   3 -
 src/openvpn/socket.c                   |  31 ---
 src/openvpn/socket.h                   |  19 +-
 src/openvpn/socks.c                    |  11 +-
 src/openvpn/socks.h                    |   2 -
 src/openvpn/ssl.c                      |  89 +++-----
 src/openvpn/ssl.h                      |  10 +-
 src/openvpn/ssl_common.h               |   3 +-
 src/openvpn/tls_crypt.c                |  10 -
 src/openvpn/tls_crypt.h                |   5 -
 tests/unit_tests/openvpn/test_crypto.c |  86 +++++++-
 34 files changed, 733 insertions(+), 683 deletions(-)
Signature · 1 line
2.33.0