Refactor perf cpumap
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v4 Latest48 patches 37 repliesIn review
- v348 patches 13 repliesSuperseded
- v248 patches 9 repliesSuperseded
Earlier versions · 1
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v1 | 22 patches | 17 replies | Superseded |
Patches in v4 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/48 | libperf: Add comments to perf_cpu_map.tools/ | +9 | 2 replies | |
| 2/48 | perf stat: Add aggr creators that are passed a cpu.tools/ tools/ | +51 | 11 replies | |
| 3/48 | perf stat: Correct aggregation CPU maptools/ | +1 | 1 reply | |
| 4/48 | perf stat: Switch aggregation to use for_each looptools/ | +27 | 2 replies | |
| 5/48 | perf stat: Switch to cpu version of cpu_map__gettools/ tools/ tools/ | +57 | 3 replies | |
| 6/48 | perf cpumap: Switch cpu_map__build_map to cpu functiontools/ tools/ tools/ | +11 | 0 replies | |
| 7/48 | perf cpumap: Remove map+index get_sockettools/ tools/ tools/ +1 more | +2 | 0 replies | |
| 8/48 | perf cpumap: Remove map+index get_dietools/ tools/ tools/ +1 more | +2 | 0 replies | |
| 9/48 | perf cpumap: Remove map+index get_coretools/ tools/ tools/ | +1 | 0 replies | |
| 10/48 | perf cpumap: Remove map+index get_nodetools/ tools/ tools/ | +1 | 0 replies | |
| 11/48 | perf cpumap: Add comments to aggr_cpu_idtools/ | +9 | 0 replies | |
| 12/48 | perf cpumap: Remove unused cpu_map__sockettools/ | +0 | 0 replies | |
| 13/48 | perf cpumap: Simplify equal function name.tools/ tools/ tools/ | +18 | 0 replies | |
| 14/48 | perf cpumap: Rename empty functions.tools/ tools/ tools/ +1 more | +25 | 0 replies | |
| 15/48 | perf cpumap: Document cpu__get_node and remove redundant functiontools/ tools/ | +9 | 0 replies | |
| 16/48 | perf cpumap: Remove map from function names that don't use a map.tools/ tools/ tools/ +1 more | +27 | 0 replies | |
| 17/48 | perf cpumap: Remove cpu_map__cpu, use libperf function.tools/ tools/ tools/ | +3 | 3 replies | |
| 18/48 | perf cpumap: Refactor cpu_map__build_maptools/ tools/ tools/ | +130 | 0 replies | |
| 19/48 | perf cpumap: Rename cpu_map__get_X_aggr_by_cpu functionstools/ tools/ tools/ +1 more | +45 | 0 replies | |
| 20/48 | perf cpumap: Move 'has' function to libperftools/ tools/ tools/ +8 more | +23 | 0 replies | |
| 21/48 | perf cpumap: Add some comments to cpu_aggr_maptools/ | +9 | 0 replies | |
| 22/48 | perf cpumap: Trim the cpu_aggr_maptools/ | +9 | 0 replies | |
| 23/48 | perf stat: Fix memory leak in check_per_pkgtools/ | +3 | 0 replies | |
| 24/48 | perf cpumap: Add CPU to aggr_cpu_idtools/ tools/ tools/ | +48 | 0 replies | |
| 25/48 | perf stat-display: Avoid use of core for CPU.tools/ | +22 | 0 replies | |
| 26/48 | perf evsel: Derive CPUs and threads in alloc_countstools/ tools/ tools/ +2 more | +15 | 2 replies | |
| 27/48 | libperf: Switch cpu to more accurate cpu_map_idxtools/ tools/ | +50 | 0 replies | |
| 28/48 | libperf: Use cpu not index for evsel mmaptools/ | +2 | 0 replies | |
| 29/48 | perf counts: Switch name cpu to cpu_map_idxtools/ | +6 | 0 replies | |
| 30/48 | perf stat: Rename aggr_data cpu to imply it's an indextools/ | +5 | 0 replies | |
| 31/48 | perf stat: Use perf_cpu_map__for_each_cputools/ | +6 | 0 replies | |
| 32/48 | perf script: Use for each cpu to aid readabilitytools/ | +3 | 0 replies | |
| 33/48 | libperf: Allow NULL in perf_cpu_map__idxtools/ | +6 | 0 replies | |
| 34/48 | perf evlist: Refactor evlist__for_each_cpu.tools/ tools/ tools/ +1 more | +210 | 0 replies | |
| 35/48 | perf evsel: Pass cpu not cpu map index to synthesizetools/ | +3 | 0 replies | |
| 36/48 | perf stat: Correct variable name for read countertools/ tools/ tools/ | +35 | 0 replies | |
| 37/48 | perf evsel: Rename CPU around get_group_fdtools/ | +11 | 0 replies | |
| 38/48 | perf evsel: Reduce scope of evsel__ignore_missing_threadtools/ tools/ | +4 | 0 replies | |
| 39/48 | perf evsel: Rename variable cpu to indextools/ tools/ tools/ +1 more | +48 | 0 replies | |
| 40/48 | perf test: Use perf_cpu_map__for_each_cputools/ | +14 | 0 replies | |
| 41/48 | perf stat: Correct check_per_pkg cputools/ | +3 | 0 replies | |
| 42/48 | perf stat: Swap variable name cpu to indextools/ tools/ tools/ | +164 | 0 replies | |
| 43/48 | libperf: Sync evsel documentationtools/ | +5 | 0 replies | |
| 44/48 | perf bpf: Rename cpu to cpu_map_idxtools/ tools/ | +9 | 2 replies | |
| 45/48 | perf c2c: Use more intention revealing iteratortools/ | +5 | 0 replies | |
| 46/48 | perf script: Fix flipped index and cputools/ | +1 | 0 replies | |
| 47/48 | perf stat: Correct first_shadow_cpu to return indextools/ | +7 | 0 replies | |
| 48/48 | perf cpumap: Give CPUs their own type.tools/ tools/ tools/ +56 more | +408 | 8 replies |
Reviews trailers per patch
22 of 48 patches have a Reviewed-by or Acked-by.
| Patch | James Clark | John Garry | Kajol Jain |
|---|---|---|---|
| 1/48 | R-b | R-b | R-b |
| 2/48 | R-b | ||
| 3/48 | T-b | ||
| 4/48 | R-b | ||
| 5/48 | R-b | ||
| 6/48 | R-b | ||
| 7/48 | R-b | ||
| 8/48 | R-b | ||
| 9/48 | R-b | ||
| 10/48 | R-b | ||
| 11/48 | R-b | ||
| 12/48 | R-b | ||
| 13/48 | R-b | ||
| 14/48 | R-b | ||
| 15/48 | R-b | ||
| 16/48 | R-b | ||
| 17/48 | R-b | ||
| 18/48 | R-b | ||
| 19/48 | R-b | ||
| 20/48 | R-b | ||
| 21/48 | R-b | ||
| 22/48 | R-b | ||
| 23/48 | R-b | ||
| 24/48 | |||
| 25/48 | |||
| 26/48 | |||
| 27/48 | |||
| 28/48 | |||
| 29/48 | |||
| 30/48 | |||
| 31/48 | |||
| 32/48 | |||
| 33/48 | |||
| 34/48 | |||
| 35/48 | |||
| 36/48 | |||
| 37/48 | |||
| 38/48 | |||
| 39/48 | |||
| 40/48 | |||
| 41/48 | |||
| 42/48 | |||
| 43/48 | |||
| 44/48 | |||
| 45/48 | |||
| 46/48 | |||
| 47/48 | |||
| 48/48 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.
Cover letter [PATCH v4 00/48] Refactor perf cpumap
Perf cpu map has various functions where a cpumap and index are passed in order to load the cpu. A problem with this is that the wrong index may be passed for the cpumap, causing problems like aggregation on the wrong CPU:
https://lore.kernel.org/lkml/[email protected]/
This patch set refactors the cpu map API, reducing it and explicitly passing the cpu (rather than the pair) to functions that need it. Comments are added at the same time. Changes modify the same file/function more than once as refactoring and fixes are broken apart for the sake of bisection.
v2. Incorproates fixes suggested Jiri Olsa, rewrites the evlist CPU
iterator in part in a way suggested by Riccardo Mancini. The new fixes start at patch 23. The final change was suggested by John Garry to make the CPUs have their own struct wrapper.
v3. Incorporates fixes suggested by Namhyung Kim.
v4. Rebases and incorporates fixes suggested by Jiri Olsa.
Ian Rogers (48):
libperf: Add comments to perf_cpu_map.
perf stat: Add aggr creators that are passed a cpu. perf stat: Correct aggregation CPU map
perf stat: Switch aggregation to use for_each loop perf stat: Switch to cpu version of cpu_map__get
perf cpumap: Switch cpu_map__build_map to cpu function perf cpumap: Remove map+index get_socket
perf cpumap: Remove map+index get_die
perf cpumap: Remove map+index get_core
perf cpumap: Remove map+index get_node
perf cpumap: Add comments to aggr_cpu_id
perf cpumap: Remove unused cpu_map__socket
perf cpumap: Simplify equal function name.
perf cpumap: Rename empty functions.
perf cpumap: Document cpu__get_node and remove redundant function perf cpumap: Remove map from function names that don't use a map. perf cpumap: Remove cpu_map__cpu, use libperf function. perf cpumap: Refactor cpu_map__build_map
perf cpumap: Rename cpu_map__get_X_aggr_by_cpu functions perf cpumap: Move 'has' function to libperf
perf cpumap: Add some comments to cpu_aggr_map
perf cpumap: Trim the cpu_aggr_map
perf stat: Fix memory leak in check_per_pkg
perf cpumap: Add CPU to aggr_cpu_id
perf stat-display: Avoid use of core for CPU.
perf evsel: Derive CPUs and threads in alloc_counts
libperf: Switch cpu to more accurate cpu_map_idx
libperf: Use cpu not index for evsel mmap
perf counts: Switch name cpu to cpu_map_idx
perf stat: Rename aggr_data cpu to imply it's an index perf stat: Use perf_cpu_map__for_each_cpu
perf script: Use for each cpu to aid readability
libperf: Allow NULL in perf_cpu_map__idx
perf evlist: Refactor evlist__for_each_cpu.
perf evsel: Pass cpu not cpu map index to synthesize perf stat: Correct variable name for read counter
perf evsel: Rename CPU around get_group_fd
perf evsel: Reduce scope of evsel__ignore_missing_thread perf evsel: Rename variable cpu to index
perf test: Use perf_cpu_map__for_each_cpu
perf stat: Correct check_per_pkg cpu
perf stat: Swap variable name cpu to index
libperf: Sync evsel documentation
perf bpf: Rename cpu to cpu_map_idx
perf c2c: Use more intention revealing iterator
perf script: Fix flipped index and cpu
perf stat: Correct first_shadow_cpu to return index perf cpumap: Give CPUs their own type.
tools/lib/perf/Documentation/libperf.txt | 11 +- tools/lib/perf/cpumap.c | 131 +++-- tools/lib/perf/evlist.c | 4 +- tools/lib/perf/evsel.c | 92 ++-- tools/lib/perf/include/internal/cpumap.h | 18 +- tools/lib/perf/include/internal/evlist.h | 3 +- tools/lib/perf/include/internal/evsel.h | 4 +- tools/lib/perf/include/internal/mmap.h | 5 +- tools/lib/perf/include/perf/cpumap.h | 8 +- tools/lib/perf/include/perf/evsel.h | 10 +- tools/lib/perf/libperf.map | 1 + tools/lib/perf/mmap.c | 2 +- tools/perf/arch/arm/util/cs-etm.c | 16 +- tools/perf/bench/epoll-ctl.c | 2 +- tools/perf/bench/epoll-wait.c | 2 +- tools/perf/bench/futex-hash.c | 2 +- tools/perf/bench/futex-lock-pi.c | 2 +- tools/perf/bench/futex-requeue.c | 2 +- tools/perf/bench/futex-wake-parallel.c | 2 +- tools/perf/bench/futex-wake.c | 2 +- tools/perf/builtin-c2c.c | 15 +- tools/perf/builtin-ftrace.c | 2 +- tools/perf/builtin-kmem.c | 2 +- tools/perf/builtin-record.c | 2 +- tools/perf/builtin-sched.c | 71 +-- tools/perf/builtin-script.c | 10 +- tools/perf/builtin-stat.c | 516 +++++++++--------- tools/perf/tests/attr.c | 6 +- tools/perf/tests/bitmap.c | 2 +- tools/perf/tests/cpumap.c | 6 +- tools/perf/tests/event_update.c | 6 +- tools/perf/tests/mem2node.c | 2 +- tools/perf/tests/mmap-basic.c | 4 +- tools/perf/tests/openat-syscall-all-cpus.c | 39 +- tools/perf/tests/stat.c | 3 +- tools/perf/tests/topology.c | 43 +- tools/perf/util/affinity.c | 2 +- tools/perf/util/auxtrace.c | 12 +- tools/perf/util/auxtrace.h | 5 +- tools/perf/util/bpf_counter.c | 16 +- tools/perf/util/bpf_counter.h | 4 +- tools/perf/util/counts.c | 8 +- tools/perf/util/counts.h | 14 +- tools/perf/util/cpumap.c | 253 ++++----- tools/perf/util/cpumap.h | 116 ++-- tools/perf/util/cputopo.c | 6 +- tools/perf/util/env.c | 29 +- tools/perf/util/env.h | 3 +- tools/perf/util/evlist.c | 148 ++--- tools/perf/util/evlist.h | 50 +- tools/perf/util/evsel.c | 143 ++--- tools/perf/util/evsel.h | 27 +- tools/perf/util/expr.c | 2 +- tools/perf/util/header.c | 6 +- tools/perf/util/mmap.c | 19 +- tools/perf/util/mmap.h | 3 +- tools/perf/util/perf_api_probe.c | 15 +- tools/perf/util/python.c | 4 +- tools/perf/util/record.c | 11 +- .../scripting-engines/trace-event-python.c | 6 +- tools/perf/util/session.c | 10 +- tools/perf/util/stat-display.c | 138 ++--- tools/perf/util/stat-shadow.c | 308 +++++------ tools/perf/util/stat.c | 47 +- tools/perf/util/stat.h | 9 +- tools/perf/util/svghelper.c | 6 +- tools/perf/util/synthetic-events.c | 12 +- tools/perf/util/synthetic-events.h | 3 +- tools/perf/util/util.h | 5 +- 69 files changed, 1333 insertions(+), 1155 deletions(-)
Signature · 1 line
2.34.1.448.ga2b2bfdf31-goog