amdgpu/pm: Implement parallel sysfs_emit solution for navi10
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v3 Latest3 patches 3 repliesIn review
- v23 patches 3 repliesSuperseded
- v13 patches 2 repliesSuperseded
Patches in v3 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | amdgpu/pm: Implement new API function "emit" that accepts buffer base and write offsetdrivers/ drivers/ drivers/ +2 more | +77 | 0 replies | |
| 2/3 | amdgpu/pm: Implemention of emit_clk_levels for navi10 that accepts buffer base and write offsetdrivers/ | +188 | 0 replies | |
| 3/3 | amdgpu/pm: Linked emit_clock_levels to use cases amdgpu_get_pp_{dpm_clock, od_clk_voltage}drivers/ | +35 | 1 reply |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.
Cover letter [PATCH v3 0/3] amdgpu/pm: Implement parallel sysfs_emit solution for navi10
== Description ==
Scnprintf use within the kernel is not recommended, but simple sysfs_emit replacement has not been successful due to the page alignment requirement of the function. This patch set implements a new api "emit_clock_levels" to facilitate passing both the base and offset to the device rather than just the write pointer.
This patch is only implemented for navi10 for some clocks to seek comment on the implementation before extending the implementation to other clock values and devices.
Needs to be verified on a platform that supports the overclocking
(v3)
Rewrote patchset to order patches as (API, hw impl, usecase)
(v2)
Update to apply on commit 801771de03
adjust printing of empty carriage return only if size == 0 change return from amdgpu_dpm_emit_clock_levels if emit_clock_levels not found
== Patch Summary ==
linux: ([email protected]:agd5f) origin/amd-staging-drm-next @ 28907fd9e048
+ f3c1d971ea17 amdgpu/pm: Implement new API function "emit" that accepts buffer base and write offset
+ c67ac3384682 amdgpu/pm: Implemention of emit_clk_levels for navi10 that accepts buffer base and write offset
+ 734cca28fed3 amdgpu/pm: Linked emit_clock_levels to use cases amdgpu_get_pp_{dpm_clock,od_clk_voltage}
== System Summary ==
* DESKTOP(AMD FX-8350 + NAVI10(731F/ca), BIOS: F2)
+ ISO(Ubuntu 20.04.3 LTS)
+ Kernel(5.13.0-fdoagd5f-20220112-g28907fd9e0)
== Test ==
LOGFILE=pp_clk.test.log
AMDGPU_PCI_ADDR=lspci -nn | grep "VGA\|Display" | cut -d " " -f 1 AMDGPU_HWMON=ls -la /sys/class/hwmon | grep $AMDGPU_PCI_ADDR | awk '{print $9}' HWMON_DIR=/sys/class/hwmon/${AMDGPU_HWMON}
lspci -nn | grep "VGA\|Display" > $LOGFILE
FILES="pp_od_clk_voltagepp_dpm_sclkpp_dpm_mclkpp_dpm_pciepp_dpm_socclkpp_dpm_fclkpp_dpm_dcefclkpp_dpm_vclkpp_dpm_dclk "
for f in $FILES
do
echo === $f === >> $LOGFILE
cat $HWMON_DIR/device/$f >> $LOGFILE
done
cat $LOGFILE
Darren Powell (3):
amdgpu/pm: Implement new API function "emit" that accepts buffer base
and write offset
amdgpu/pm: Implemention of emit_clk_levels for navi10 that accepts
buffer base and write offset
amdgpu/pm: Linked emit_clock_levels to use cases
amdgpu_get_pp_{dpm_clock,od_clk_voltage}.../gpu/drm/amd/include/kgd_pp_interface.h | 1 + drivers/gpu/drm/amd/pm/amdgpu_dpm.c | 21 ++ drivers/gpu/drm/amd/pm/amdgpu_pm.c | 49 +++-- drivers/gpu/drm/amd/pm/inc/amdgpu_dpm.h | 4 + drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c | 42 +++- drivers/gpu/drm/amd/pm/swsmu/inc/amdgpu_smu.h | 14 ++ .../gpu/drm/amd/pm/swsmu/smu11/navi10_ppt.c | 188 ++++++++++++++++++ 7 files changed, 300 insertions(+), 19 deletions(-)
base-commit: 28907fd9e04859fab86a143271d29ff0ff043154
Signature · 1 line
2.34.1