Skip to content

DRM kmap() fixes and kmap_local_page() conversions

[email protected] amd-gfx dri-devel intel-gfx linux-arm-msm lkml 3 versions – Applied

Status from this message: Applied to drm-misc-next, the others should all have full time maintainers

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest posting 2/27 patches 3 repliesApplied
  2. v2 posting 1/21 patch 0 repliesSuperseded
  3. v17 patches 15 repliesSuperseded

Changes in v2 from the cover letter

Use memcpy_to_page() where appropriate
Rebased to latest

Patches in v2 posting 2/2 Applied

#Subject and filesSizeRepliesApplied
1/7drm/i915: Replace kmap() with kmap_local_page()drivers/gpu/drm/i915/gem/i915_gem_shmem.c drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c drivers/gpu/drm/i915/gt/intel_ggtt_fencing.c +3 more+16 -210 replies
2/7drm/amd: Replace kmap() with kmap_local_page()drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c+4 -40 replies
3/7drm/gma: Remove calls to kmap()drivers/gpu/drm/gma500/gma_display.c drivers/gpu/drm/gma500/mmu.c+6 -81 reply
4/7drm/radeon: Replace kmap() with kmap_local_page()drivers/gpu/drm/radeon/radeon_ttm.c+2 -20 replies
5/7drm/msm: Alter comment to use kmap_local_page()drivers/gpu/drm/msm/msm_gem_submit.c+2 -20 replies
6/7drm/amdgpu: Ensure kunmap is called on errordrivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c+1 -00 replies
7/7drm/radeon: Ensure kunmap is called on errordrivers/gpu/drm/radeon/radeon_uvd.c+1 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH V2 0/7] DRM kmap() fixes and kmap_local_page() conversions

From: Ira Weiny <[email protected]>

Changes from V1:
Use memcpy_to_page() where appropriate
Rebased to latest

The kmap() call may cause issues with work being done with persistent memory. For this and other reasons it is being deprecated.

This series starts by converting the last easy kmap() uses in the drm tree to kmap_local_page().

The final 2 patches fix bugs found while working on the ttm_bo_kmap_ttm() conversion. They are valid fixes but were found via code inspection not because of any actual bug so don't require a stable tag.[1]

There is one more call to kmap() used in ttm_bo_kmap_ttm(). Unfortunately, fixing this is not straight forward so it is left to future work.[2]

[1] https://lore.kernel.org/lkml/[email protected]/
[2] https://lore.kernel.org/lkml/[email protected]/

Ira Weiny (7):
drm/i915: Replace kmap() with kmap_local_page()
drm/amd: Replace kmap() with kmap_local_page()
drm/gma: Remove calls to kmap()
drm/radeon: Replace kmap() with kmap_local_page()
drm/msm: Alter comment to use kmap_local_page()
drm/amdgpu: Ensure kunmap is called on error
drm/radeon: Ensure kunmap is called on error

drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 8 ++++---- drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c | 1 + drivers/gpu/drm/gma500/gma_display.c | 6 ++---- drivers/gpu/drm/gma500/mmu.c | 8 ++++---- drivers/gpu/drm/i915/gem/i915_gem_shmem.c | 6 ++---- drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c | 8 ++++---- drivers/gpu/drm/i915/gt/intel_ggtt_fencing.c | 4 ++-- drivers/gpu/drm/i915/gt/shmem_utils.c | 7 ++----- drivers/gpu/drm/i915/i915_gem.c | 8 ++++---- drivers/gpu/drm/i915/i915_gpu_error.c | 4 ++-- drivers/gpu/drm/msm/msm_gem_submit.c | 4 ++-- drivers/gpu/drm/radeon/radeon_ttm.c | 4 ++-- drivers/gpu/drm/radeon/radeon_uvd.c | 1 +

13 files changed, 32 insertions(+), 37 deletions(-)

--
2.31.1