Skip to content

Introduce ancillary links

Daniel Scally linux-media 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest5 patches 9 repliesIn review
  2. v26 patches 8 repliesSuperseded
  3. v15 patches 27 repliesSuperseded

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5media: entity: Skip non-data links in graph iterationdrivers/media/mc/mc-entity.c+6 -01 reply
2/5media: media.h: Add new media link typeDocumentation/userspace-api/media/mediactl/media-controller-model.rst Documentation/userspace-api/media/mediactl/media-types.rst include/uapi/linux/media.h+19 -51 reply
3/5media: entity: Add link_type_name() helperdrivers/media/mc/mc-entity.c+15 -31 reply
4/5media: entity: Add support for ancillary linksdrivers/media/mc/mc-entity.c include/media/media-entity.h+41 -01 reply
5/5media: v4l2-async: Create links during v4l2_async_match_notify()drivers/media/v4l2-core/v4l2-async.c+31 -02 replies

Reviews trailers per patch

All 5 patches have a Reviewed-by or Acked-by.

PatchLaurent PinchartJean-Michel Hautbois
1/5R-b R-b
2/5R-b R-b
3/5R-b R-b
4/5R-b R-b
5/5R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/5] Introduce ancillary links

Hello all

At present there's no means in the kernel of describing the supporting relationship between subdevices that work together to form an effective single unit - the type example in this case being a camera sensor and its corresponding vcm. To attempt to solve that, this series adds a new type of media link called MEDIA_LNK_FL_ANCILLARY_LINK, which connects two instances of struct media_entity.

The mechanism of connection I have modelled as a notifier and async subdev, which seemed the best route since sensor drivers already typically will call v4l2_async_register_subdev_sensor() on probe, and that function already looks for a reference to a firmware node with the reference named "lens-focus". To avoid boilerplate in the sensor drivers, I added some new functions in v4l2-async that are called in v4l2_async_match_notify() to create the ancillary links. I haven't gone further than that yet, but I suspect we could cut down on code elsewhere by, for example, also creating pad-to-pad links in the same place

Series level changes since v2:

- Squashed #2 and #3

Series-level changes since v1:

- New patch adding some documentation to the uAPI pages.

Dan

Daniel Scally (5):
media: entity: Skip non-data links in graph iteration
media: media.h: Add new media link type
media: entity: Add link_type_name() helper
media: entity: Add support for ancillary links
media: v4l2-async: Create links during v4l2_async_match_notify()

 .../media/mediactl/media-controller-model.rst |  6 +++
 .../media/mediactl/media-types.rst            | 17 +++++--
 drivers/media/mc/mc-entity.c                  | 46 +++++++++++++++++--
 drivers/media/v4l2-core/v4l2-async.c          | 31 +++++++++++++
 include/media/media-entity.h                  | 19 ++++++++
 include/uapi/linux/media.h                    |  1 +
 6 files changed, 112 insertions(+), 8 deletions(-)
Signature · 1 line
2.25.1