Skip to content

tools: kwbimage: Load address fixes

Pali Rohár u-boot 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest20 patches 21 repliesIn review
  2. v116 patches 9 repliesSuperseded

Changes in v2 from the cover letter

* Fix base address for Sheeva CPUs (A370, AXP), it is 0x40004000
* Fix information about mapped area of load address (it is L2, not CESA)
* Add new kwbimage config option CPU

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/20tools: kwbimage: Mark all local functions as statictools/kwbimage.c+19 -181 reply
2/20tools: kwbimage: Deduplicate v1 regtype header finishingtools/kwbimage.c+22 -191 reply
3/20tools: kwbimage: Fix generating image with multiple DATA_DELAY commandstools/kwbimage.c+15 -31 reply
4/20tools: kwbimage: Preserve order of BINARY, DATA and DATA_DELAY commandstools/kwbimage.c+38 -201 reply
5/20arm: mvebu: Generate kwbimage.cfg with $(call cmd, ...)arch/arm/mach-mvebu/Makefile+5 -21 reply
6/20tools: kwbimage: Add support for specifying CPU coretools/kwbimage.c+26 -01 reply
7/20tools: kwbimage: Add support for specifying LOAD_ADDRESS for BINARY commandtools/kwbimage.c+93 -161 reply
8/20tools: kwbimage: Check the return value of image_headersz_v1()tools/kwbimage.c+4 -01 reply
9/20tools: kwbimage: Check for maximal kwbimage header sizetools/kwbimage.c+5 -01 reply
10/20arm: mvebu: Set CPU for U-Boot SPL binary in kwbimagearch/arm/mach-mvebu/Makefile arch/arm/mach-mvebu/kwbimage.cfg.in+11 -01 reply
11/20arm: mvebu: Correctly set LOAD_ADDRESS for U-Boot SPL binary in kwbimagearch/arm/mach-mvebu/Makefile arch/arm/mach-mvebu/kwbimage.cfg.in+6 -31 reply
12/20tools: kwbimage: Enforce 128-bit boundary alignment only for Sheeva CPUtools/kwbimage.c+8 -41 reply
13/20arm: mvebu: Enable BootROM output on A38xarch/arm/mach-mvebu/Makefile arch/arm/mach-mvebu/kwbimage.cfg.in+10 -01 reply
14/20tools: kwbimage: Add missing check for maximal value for DATA_DELAYtools/kwbimage.c+4 -01 reply
15/20tools: kwbimage: Show binary image offset in mkimage -l, in addition to sizetools/kwbimage.c+4 -11 reply
16/20tools: kwbimage: Dump kwbimage config file on '-p -1' optiontools/kwbimage.c+176 -01 reply
17/20tools: kwbimage: Do not cast const pointers to non-const pointerstools/kwbimage.h+2 -21 reply
18/20tools: kwbimage/kwboot: Check ext field for non-zero valuetools/kwbimage.c tools/kwbimage.h tools/kwboot.c+6 -61 reply
19/20tools: kwbimage: Extract main data image without -p arg for dumpimagetools/kwbimage.c+40 -271 reply
20/20tools: kwbimage: Fix mkimage/dumpimage -l argumenttools/kwbimage.c+2 -11 reply

Reviews trailers per patch

All 20 patches have a Reviewed-by or Acked-by.

PatchMarek BehúnStefan Roese
1/20R-b R-b
2/20R-b R-b
3/20R-b R-b
4/20R-b R-b
5/20R-b R-b
6/20R-b
7/20R-b R-b
8/20R-b R-b
9/20R-b
10/20R-b
11/20R-b R-b
12/20R-b
13/20R-b R-b
14/20R-b R-b
15/20R-b
16/20R-b R-b
17/20R-b R-b
18/20R-b R-b
19/20R-b R-b
20/20R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH u-boot-marvell v2 00/20] tools: kwbimage: Load address fixes

This patch series fixes generating images in kwbimage format, main fix is setting correct load address of U-Boot SPL. Also it adds support for generating kwbimage config file from existing kwbimage file via dumpimage tool.

Changes in v2:
* Fix base address for Sheeva CPUs (A370, AXP), it is 0x40004000
* Fix information about mapped area of load address (it is L2, not CESA)
* Add new kwbimage config option CPU

Pali Rohár (20):
tools: kwbimage: Mark all local functions as static
tools: kwbimage: Deduplicate v1 regtype header finishing
tools: kwbimage: Fix generating image with multiple DATA_DELAY
commands
tools: kwbimage: Preserve order of BINARY, DATA and DATA_DELAY
commands
arm: mvebu: Generate kwbimage.cfg with $(call cmd, ...)
tools: kwbimage: Add support for specifying CPU core
tools: kwbimage: Add support for specifying LOAD_ADDRESS for BINARY
command
tools: kwbimage: Check the return value of image_headersz_v1()
tools: kwbimage: Check for maximal kwbimage header size
arm: mvebu: Set CPU for U-Boot SPL binary in kwbimage
arm: mvebu: Correctly set LOAD_ADDRESS for U-Boot SPL binary in
kwbimage
tools: kwbimage: Enforce 128-bit boundary alignment only for Sheeva
CPU
arm: mvebu: Enable BootROM output on A38x
tools: kwbimage: Add missing check for maximal value for DATA_DELAY
tools: kwbimage: Show binary image offset in mkimage -l, in addition
to size
tools: kwbimage: Dump kwbimage config file on '-p -1' option
tools: kwbimage: Do not cast const pointers to non-const pointers
tools: kwbimage/kwboot: Check ext field for non-zero value
tools: kwbimage: Extract main data image without -p arg for dumpimage
tools: kwbimage: Fix mkimage/dumpimage -l argument

 arch/arm/mach-mvebu/Makefile        |  25 +-
 arch/arm/mach-mvebu/kwbimage.cfg.in |  10 +-
 tools/kwbimage.c                    | 549 +++++++++++++++++++++++-----
 tools/kwbimage.h                    |  10 +-
 tools/kwboot.c                      |   4 +-
 5 files changed, 486 insertions(+), 112 deletions(-)
Signature · 1 line
2.20.1