Skip to content

user creatable pnv-phb4 devices

Daniel Henrique Barboza qemu-devel 5 versions – Applied

Status from this message: Applied to ppc7.0.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest5 patches 11 repliesApplied
  2. v45 patches 6 repliesSuperseded
  3. v310 patches 10 repliesSuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v218 patches20 repliesSuperseded
v117 patches20 repliesApplied

Changes in v5 from the cover letter

- patches 1,3,5: unchanged
- patch 2:
* renamed function to pnv_phb4_xscom_realize()
* pnv4_phb4_xscom_realize() is now called at the end of phb4_realize()
- patch 4:
* changed pnv_phb4_get_stack signature to use chip and phb
* added a new helper called pnv_pec_stk_default_phb_realize() to
realize the default phb when running with defaults
- v4 link: https://lists.gnu.org/archive/html/qemu-devel/2022-01/msg02148.html

Patches in v5 Applied

#Subject and filesSizeRepliesApplied
1/5ppc/pnv: set phb4 properties in stk_realize()hw/pci-host/pnv_phb4_pec.c+3 -30 replies
2/5ppc/pnv: move PHB4 XSCOM init to phb4_realize()hw/pci-host/pnv_phb4.c hw/pci-host/pnv_phb4_pec.c+304 -2920 replies
3/5ppc/pnv: turn 'phb' into a pointer in struct PnvPhb4PecStackhw/pci-host/pnv_phb4.c hw/pci-host/pnv_phb4_pec.c include/hw/pci-host/pnv_phb4.h+13 -160 replies
4/5ppc/pnv: Introduce user creatable pnv-phb4 deviceshw/pci-host/pnv_phb4.c hw/pci-host/pnv_phb4_pec.c hw/ppc/pnv.c+89 -45 replies
5/5ppc/pnv: turn pnv_phb4_update_regions() into statichw/pci-host/pnv_phb4.c include/hw/pci-host/pnv_phb4.h+26 -270 replies

Reviews trailers per patch

All 5 patches have a Reviewed-by or Acked-by.

PatchCédric Le Goater
1/5R-b
2/5R-b
3/5R-b
4/5R-b
5/5R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v5 thread

Cover letter [PATCH v5 0/5] user creatable pnv-phb4 devices

Hi,

This version implements Cedric's review suggestions from v4. No drastic design changes were made.

Changes from v4:
- patches 1,3,5: unchanged
- patch 2:
* renamed function to pnv_phb4_xscom_realize()
* pnv4_phb4_xscom_realize() is now called at the end of phb4_realize()
- patch 4:
* changed pnv_phb4_get_stack signature to use chip and phb
* added a new helper called pnv_pec_stk_default_phb_realize() to
realize the default phb when running with defaults
- v4 link: https://lists.gnu.org/archive/html/qemu-devel/2022-01/msg02148.html

Daniel Henrique Barboza (5):
ppc/pnv: set phb4 properties in stk_realize() ppc/pnv: move PHB4 XSCOM init to phb4_realize() ppc/pnv: turn 'phb' into a pointer in struct PnvPhb4PecStack ppc/pnv: Introduce user creatable pnv-phb4 devices ppc/pnv: turn pnv_phb4_update_regions() into static

 hw/pci-host/pnv_phb4.c         | 430 ++++++++++++++++++++++++++++++---
 hw/pci-host/pnv_phb4_pec.c     | 329 ++-----------------------
 hw/ppc/pnv.c                   |   2 +
 include/hw/pci-host/pnv_phb4.h |   8 +-
 4 files changed, 431 insertions(+), 338 deletions(-)
Signature · 1 line
2.33.1