Skip to content

IIO: accel/st-sensors move into separate symbol namespaces

Jonathan Cameron linux-iio 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest13 patches 5 repliesIn review
  2. v113 patches 9 repliesSuperseded

Changes in v2 from the cover letter

* Add IIO_ prefix to namespaces.

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/13iio:accel:mma9551_core: Move exports into IIO_MMA9551 namespacedrivers/iio/accel/mma9551.c drivers/iio/accel/mma9551_core.c drivers/iio/accel/mma9553.c+20 -180 replies
2/13iio:accel:mma7455_core: Move exports into IIO_MMA7455 namespacedrivers/iio/accel/mma7455_core.c drivers/iio/accel/mma7455_i2c.c drivers/iio/accel/mma7455_spi.c+5 -30 replies
3/13iio:accel:kxsd9: Move exports into IIO_KDSD9 namespacedrivers/iio/accel/kxsd9-i2c.c drivers/iio/accel/kxsd9-spi.c drivers/iio/accel/kxsd9.c+5 -30 replies
4/13iio:accel:bma400: Move exports into IIO_BMA400 namespacedrivers/iio/accel/bma400_core.c drivers/iio/accel/bma400_i2c.c drivers/iio/accel/bma400_spi.c+5 -30 replies
5/13iio:accel:adxl313: Move exports into IIO_ADXL313 namespacedrivers/iio/accel/adxl313_core.c drivers/iio/accel/adxl313_i2c.c drivers/iio/accel/adxl313_spi.c+5 -30 replies
6/13iio:accel:adxl345: Move exports into IIO_ADXL345 namespacedrivers/iio/accel/adxl345_core.c drivers/iio/accel/adxl345_i2c.c drivers/iio/accel/adxl345_spi.c+3 -10 replies
7/13iio:accel:adxl355: Move exports into IIO_ADXL355 namespacedrivers/iio/accel/adxl355_core.c drivers/iio/accel/adxl355_i2c.c drivers/iio/accel/adxl355_spi.c+5 -30 replies
8/13iio:accel:adxl372: Move exports into IIO_ADXL372 namespacedrivers/iio/accel/adxl372.c drivers/iio/accel/adxl372_i2c.c drivers/iio/accel/adxl372_spi.c+4 -20 replies
9/13iio:accel:bmc150: Move exports into IIO_BMC150 namespacedrivers/iio/accel/bmc150-accel-core.c drivers/iio/accel/bmc150-accel-i2c.c drivers/iio/accel/bmc150-accel-spi.c+6 -40 replies
10/13iio:accel:bmi088: Move exports into IIO_BMI088 namespacedrivers/iio/accel/bmi088-accel-core.c drivers/iio/accel/bmi088-accel-spi.c+5 -40 replies
11/13iio:accel:fxl8962af: Move exports into IIO_FXL8962AF namespacedrivers/iio/accel/fxls8962af-core.c drivers/iio/accel/fxls8962af-i2c.c drivers/iio/accel/fxls8962af-spi.c+5 -31 reply
12/13iio:st-sensors: Remove duplicate MODULE_*drivers/iio/accel/st_accel_buffer.c drivers/iio/common/st_sensors/st_sensors_buffer.c drivers/iio/common/st_sensors/st_sensors_trigger.c +3 more+0 -280 replies
13/13iio:st-sensors: Move exports into IIO_ST_SENSORS namespacedrivers/iio/accel/st_accel_core.c drivers/iio/accel/st_accel_i2c.c drivers/iio/accel/st_accel_spi.c +17 more+43 -280 replies

Reviews trailers per patch

3 of 13 patches have a Reviewed-by or Acked-by.

PatchSrinivas PandruvadaLinus WalleijSean Nyekjaer
1/13
2/13
3/13
4/13
5/13
6/13
7/13
8/13
9/13A-b
10/13
11/13R-b
12/13R-b
13/13

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v2 thread

Cover letter [PATCH v2 00/13] IIO: accel/st-sensors move into separate symbol namespaces

From: Jonathan Cameron <[email protected]>

Changes since v1:
* Add IIO_ prefix to namespaces.

https://lwn.net/Articles/760045/ provides a good overview of this feature and why it might be used. In this particular case we fall under the multi module case. For each group of modules, I've moved the exports into an independent namespace.

Whilst I'm not entirely sure it is worth the noise of moving the main IIO exports into a namespace, it is definitely worthwhile for these small clusters of related modules (typically a core + i2c and spi modules).

I've just done those within drivers/accel (including all of st-sensors as I did not want to do that piecemeal) as an initial set to get feedback on what people think of the approach and in particular naming of the namespaces.

As you can see it is a straight forward change to makes so I'll do the rest of the IIO drivers once we are agreed on the generic details. Note that I'll be expecting this for any new cases of this pattern going forwards.

Includes a small diversion in st-sensors where we had a bunch of duplicated MODULE_* macros for some of the core modules which were made up of multiple c files.

Cc Uwe Kleine-König <[email protected]
Cc Linus Walleij <[email protected]>
Cc Lucas Stankus <[email protected]>
Cc Puranjay Mohan <[email protected]>
Cc Srinivas Pandruvada <[email protected]>
Cc Mike Looijmans <[email protected]>
Cc Sean Nyekjaer <[email protected]>
Cc Andy Shevchenko <[email protected]>
Cc Linus Walleij <[email protected]>
Cc Denis Ciocca <[email protected]>

Jonathan Cameron (13):
iio:accel:mma9551_core: Move exports into IIO_MMA9551 namespace iio:accel:mma7455_core: Move exports into IIO_MMA7455 namespace iio:accel:kxsd9: Move exports into IIO_KDSD9 namespace iio:accel:bma400: Move exports into IIO_BMA400 namespace iio:accel:adxl313: Move exports into IIO_ADXL313 namespace iio:accel:adxl345: Move exports into IIO_ADXL345 namespace iio:accel:adxl355: Move exports into IIO_ADXL355 namespace iio:accel:adxl372: Move exports into IIO_ADXL372 namespace iio:accel:bmc150: Move exports into IIO_BMC150 namespace iio:accel:bmi088: Move exports into IIO_BMI088 namespace iio:accel:fxl8962af: Move exports into IIO_FXL8962AF namespace iio:st-sensors: Remove duplicate MODULE_* iio:st-sensors: Move exports into IIO_ST_SENSORS namespace

 drivers/iio/accel/adxl313_core.c              |  6 ++--
 drivers/iio/accel/adxl313_i2c.c               |  1 +
 drivers/iio/accel/adxl313_spi.c               |  1 +
 drivers/iio/accel/adxl345_core.c              |  2 +-
 drivers/iio/accel/adxl345_i2c.c               |  1 +
 drivers/iio/accel/adxl345_spi.c               |  1 +
 drivers/iio/accel/adxl355_core.c              |  6 ++--
 drivers/iio/accel/adxl355_i2c.c               |  1 +
 drivers/iio/accel/adxl355_spi.c               |  1 +
 drivers/iio/accel/adxl372.c                   |  4 +--
 drivers/iio/accel/adxl372_i2c.c               |  1 +
 drivers/iio/accel/adxl372_spi.c               |  1 +
 drivers/iio/accel/bma400_core.c               |  6 ++--
 drivers/iio/accel/bma400_i2c.c                |  1 +
 drivers/iio/accel/bma400_spi.c                |  1 +
 drivers/iio/accel/bmc150-accel-core.c         |  8 ++---
 drivers/iio/accel/bmc150-accel-i2c.c          |  1 +
 drivers/iio/accel/bmc150-accel-spi.c          |  1 +
 drivers/iio/accel/bmi088-accel-core.c         |  8 ++---
 drivers/iio/accel/bmi088-accel-spi.c          |  1 +
 drivers/iio/accel/fxls8962af-core.c           |  6 ++--
 drivers/iio/accel/fxls8962af-i2c.c            |  1 +
 drivers/iio/accel/fxls8962af-spi.c            |  1 +
 drivers/iio/accel/kxsd9-i2c.c                 |  1 +
 drivers/iio/accel/kxsd9-spi.c                 |  1 +
 drivers/iio/accel/kxsd9.c                     |  6 ++--
 drivers/iio/accel/mma7455_core.c              |  6 ++--
 drivers/iio/accel/mma7455_i2c.c               |  1 +
 drivers/iio/accel/mma7455_spi.c               |  1 +
 drivers/iio/accel/mma9551.c                   |  1 +
 drivers/iio/accel/mma9551_core.c              | 36 +++++++++----------
 drivers/iio/accel/mma9553.c                   |  1 +
 drivers/iio/accel/st_accel_buffer.c           |  5 ---
 drivers/iio/accel/st_accel_core.c             |  5 +--
 drivers/iio/accel/st_accel_i2c.c              |  1 +
 drivers/iio/accel/st_accel_spi.c              |  1 +
 .../iio/common/st_sensors/st_sensors_buffer.c |  7 +---
 .../iio/common/st_sensors/st_sensors_core.c   | 28 +++++++--------
 .../iio/common/st_sensors/st_sensors_i2c.c    |  2 +-
 .../iio/common/st_sensors/st_sensors_spi.c    |  2 +-
 .../common/st_sensors/st_sensors_trigger.c    |  9 ++---
 drivers/iio/gyro/st_gyro_buffer.c             |  4 ---
 drivers/iio/gyro/st_gyro_core.c               |  5 +--
 drivers/iio/gyro/st_gyro_i2c.c                |  1 +
 drivers/iio/gyro/st_gyro_spi.c                |  1 +
 drivers/iio/imu/st_lsm9ds0/st_lsm9ds0_core.c  |  3 +-
 drivers/iio/imu/st_lsm9ds0/st_lsm9ds0_i2c.c   |  1 +
 drivers/iio/imu/st_lsm9ds0/st_lsm9ds0_spi.c   |  1 +
 drivers/iio/magnetometer/st_magn_buffer.c     |  4 ---
 drivers/iio/magnetometer/st_magn_core.c       |  5 +--
 drivers/iio/magnetometer/st_magn_i2c.c        |  1 +
 drivers/iio/magnetometer/st_magn_spi.c        |  1 +
 drivers/iio/pressure/st_pressure_buffer.c     |  5 ---
 drivers/iio/pressure/st_pressure_core.c       |  5 +--
 drivers/iio/pressure/st_pressure_i2c.c        |  1 +
 drivers/iio/pressure/st_pressure_spi.c        |  1 +
 56 files changed, 111 insertions(+), 103 deletions(-)
Signature · 1 line
2.34.1