Skip to content

staging: r8188eu: clean up struct hal_data_8188e

Michael Straube linux-staging lkml 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest7 patches 7 repliesIn review
  2. v27 patches 1 replySuperseded
  3. v17 patches 2 repliesSuperseded

Changes in v3 from the cover letter

- Remove INTERRUPT_MSG_FORMAT_LEN from rtl8188e_recv.h.

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7staging: r8188eu: bRDGEnable is always falsedrivers/staging/r8188eu/hal/usb_halinit.c drivers/staging/r8188eu/include/rtl8188e_hal.h+0 -131 reply
2/7staging: r8188eu: UsbRxHighSpeedMode is set but never useddrivers/staging/r8188eu/hal/usb_halinit.c drivers/staging/r8188eu/include/rtl8188e_hal.h+0 -81 reply
3/7staging: r8188eu: bTXPowerDataReadFromEEPORM is set but never useddrivers/staging/r8188eu/hal/rtl8188e_hal_init.c drivers/staging/r8188eu/include/rtl8188e_hal.h+0 -41 reply
4/7staging: r8188eu: bAPKThermalMeterIgnore is set but never useddrivers/staging/r8188eu/hal/rtl8188e_hal_init.c drivers/staging/r8188eu/include/rtl8188e_hal.h+2 -41 reply
5/7staging: r8188eu: remove unused fields from struct hal_data_8188edrivers/staging/r8188eu/include/rtl8188e_hal.h+0 -301 reply
6/7staging: r8188eu: IntArray and C2hArray are set but never useddrivers/staging/r8188eu/hal/usb_ops_linux.c drivers/staging/r8188eu/include/rtl8188e_hal.h drivers/staging/r8188eu/include/rtl8188e_recv.h +1 more+0 -311 reply
7/7staging: r8188eu: FwRsvdPageStartOffset is set but never useddrivers/staging/r8188eu/hal/rtl8188e_cmd.c drivers/staging/r8188eu/include/rtl8188e_hal.h+0 -51 reply

Reviews trailers per patch

All 7 patches have a Reviewed-by or Acked-by.

PatchMartin Kaiser
1/7A-b
2/7A-b
3/7A-b
4/7A-b
5/7A-b
6/7A-b
7/7A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/7] staging: r8188eu: clean up struct hal_data_8188e

This series removes unused and set but never used fields from the hal_data_8188e structure.

Tested on x86_64 with Inter-Tech DMG-02.

v3:
- Remove INTERRUPT_MSG_FORMAT_LEN from rtl8188e_recv.h.

v2:
- Remove interrupt_handler_8188eu() since it does nothing now.
- Fixed typo in cover letter. hal_data_r8188e -> hal_data_8188e

Michael Straube (7):
staging: r8188eu: bRDGEnable is always false
staging: r8188eu: UsbRxHighSpeedMode is set but never used
staging: r8188eu: bTXPowerDataReadFromEEPORM is set but never used
staging: r8188eu: bAPKThermalMeterIgnore is set but never used
staging: r8188eu: remove unused fields from struct hal_data_8188e
staging: r8188eu: IntArray and C2hArray are set but never used
staging: r8188eu: FwRsvdPageStartOffset is set but never used

 drivers/staging/r8188eu/hal/rtl8188e_cmd.c    |  3 --
 .../staging/r8188eu/hal/rtl8188e_hal_init.c   |  8 +---
 drivers/staging/r8188eu/hal/usb_halinit.c     | 15 -------
 drivers/staging/r8188eu/hal/usb_ops_linux.c   | 20 ---------
 .../staging/r8188eu/include/rtl8188e_hal.h    | 43 -------------------
 .../staging/r8188eu/include/rtl8188e_recv.h   |  1 -
 .../staging/r8188eu/include/rtl8188e_spec.h   |  7 ---
 7 files changed, 2 insertions(+), 95 deletions(-)
Signature · 1 line
2.34.1

Read the cover letter in its thread