of: unittest: re-implement overlay tracking
Status from this message: Applied, thanks!
Get series with b4
b4 am [email protected]Versions newest first
Patches in v1 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/2 | of: unittest: change references to obsolete overlay iddrivers/ | +27 | 1 reply | |
| 2/2 | of: unittest: re-implement overlay trackingdrivers/ | +49 | 1 reply |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH 0/2] of: unittest: re-implement overlay tracking
From: Frank Rowand <[email protected]>
Some overlays are tracked when they are applied. The tracked overlays are later removed after the overlay tests are completed. The old implementation makes assumptions about the expected values for overlay changeset id created by the overlay apply which result in fragile code. The new code removes the assumptions.
A symptom that exposes a problem with the tracking code is a warning "UBSAN: shift-out-of-bounds in drivers/of/unittest.c:1933:36", Kernel Version: 5.15-rc7, PPC-64, Talos II. This results from variable "id" value of -1 in the final line of of_unittest_untrack_overlay().
The first patch in the series cleans up the inconsistent use of overlay changeset id and the obsolete overlay id. The id is a core concept in the overlay tracking that is re-implemented in the second patch in the series.
Frank Rowand (2):
of: unittest: change references to obsolete overlay id
of: unittest: re-implement overlay tracking
drivers/of/unittest.c | 154 +++++++++++++++++++----------------------- 1 file changed, 71 insertions(+), 83 deletions(-)
Signature · 1 line
Frank Rowand <[email protected]>