Skip to content

RFC common/mlx5: refactor devargs management

[email protected] dpdk-dev 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest3 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3net/mlx5: remove some duplicationsdrivers/common/mlx5/mlx5_common.h drivers/common/mlx5/mlx5_common_pci.c drivers/common/mlx5/version.map +14 more+327 -3830 replies
2/3net/mlx5: refactor devargs handling in spawndrivers/net/mlx5/linux/mlx5_os.c drivers/net/mlx5/linux/mlx5_vlan_os.c drivers/net/mlx5/mlx5.c +15 more+1471 -10760 replies
3/3common/mlx5: refactore devargs managementdrivers/common/mlx5/mlx5_common.c drivers/common/mlx5/mlx5_common.h drivers/common/mlx5/version.map +8 more+703 -3490 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [RFC 0/3] common/mlx5: refactor devargs management

From: Michael Baum <[email protected]>

These patches rearrange the management of the devargs on two different levels.

The first splits the net driver's devargs into two categories, device-dependent devargs and port-dependent devargs. Arguments that depend on the device are updated once in the creation of the shared device context structure, and do not change even if the user has sent new devargs in the probe again. In contrast, the arguments that depend on the port are updated separately for each port.

The second layer deals with the parsing of devargs in the common driver. The common driver once parses the devargs into a dictionary, and sends it to all the drivers that will use it during the probe and update within it which keys they used. The shared driver then receives the dictionary and reports about unknown devargs to the user.

Michael Baum (3):
net/mlx5: remove some duplications
net/mlx5: refactor devargs handling in spawn
common/mlx5: refactore devargs management

 drivers/common/mlx5/mlx5_common.c     |  313 ++++++-
 drivers/common/mlx5/mlx5_common.h     |   51 +-
 drivers/common/mlx5/mlx5_common_pci.c |   18 +
 drivers/common/mlx5/version.map       |    3 +
 drivers/compress/mlx5/mlx5_compress.c |   38 +-
 drivers/crypto/mlx5/mlx5_crypto.c     |   39 +-
 drivers/net/mlx5/linux/mlx5_os.c      | 1233 +++++++++++++------------
 drivers/net/mlx5/linux/mlx5_verbs.c   |    4 +-
 drivers/net/mlx5/linux/mlx5_vlan_os.c |    3 +-
 drivers/net/mlx5/mlx5.c               |  713 +++++++-------
 drivers/net/mlx5/mlx5.h               |  275 ++++--
 drivers/net/mlx5/mlx5_devx.c          |   12 +-
 drivers/net/mlx5/mlx5_ethdev.c        |   26 +-
 drivers/net/mlx5/mlx5_flow.c          |  103 ++-
 drivers/net/mlx5/mlx5_flow.h          |    2 +-
 drivers/net/mlx5/mlx5_flow_dv.c       |  138 +--
 drivers/net/mlx5/mlx5_flow_flex.c     |    4 +-
 drivers/net/mlx5/mlx5_flow_meter.c    |  126 +--
 drivers/net/mlx5/mlx5_rxmode.c        |    8 +-
 drivers/net/mlx5/mlx5_rxq.c           |   47 +-
 drivers/net/mlx5/mlx5_trigger.c       |   27 +-
 drivers/net/mlx5/mlx5_tx.c            |    2 +-
 drivers/net/mlx5/mlx5_txpp.c          |   14 +-
 drivers/net/mlx5/mlx5_txq.c           |   45 +-
 drivers/net/mlx5/mlx5_vlan.c          |    4 +-
 drivers/net/mlx5/windows/mlx5_os.c    |  524 +++++++----
 drivers/regex/mlx5/mlx5_regex.c       |    3 +-
 drivers/vdpa/mlx5/mlx5_vdpa.c         |   32 +-
 28 files changed, 2250 insertions(+), 1557 deletions(-)
Signature · 1 line
2.25.1